Re: [Mesa-dev] [PATCH] nouveau: avoid queueing too much work onto a single fence

2015-11-05 Thread Jan Vesely
On Fri, 2015-11-06 at 00:46 -0500, Ilia Mirkin wrote: > Force the fence to get kicked off, which won't actually wait for its > completion, but any additional work will be put onto a fresh list. > > This fixes crashes in teximage-colors --benchmark with too many > active > maps. > > Signed-off-by:

Re: [Mesa-dev] [PATCH 13/16] nvc0: enable compute support by default on Fermi

2015-10-18 Thread Jan Vesely
On Sat, 2015-10-17 at 16:34 -0400, Ilia Mirkin wrote: > On Sat, Oct 17, 2015 at 4:31 PM, Ilia Mirkin > wrote: > > On Sat, Oct 17, 2015 at 4:24 PM, Jan Vesely > > wrote: > > > On Sat, 2015-10-17 at 15:24 -0400, Ilia Mirkin wrote: > > > > "compute"

Re: [Mesa-dev] [PATCH 13/16] nvc0: enable compute support by default on Fermi

2015-10-17 Thread Jan Vesely
h even if someone did the work" to "it's feasible if you find someone with plenty of time on his/her hands" is still nice. Jan > > On Sat, Oct 17, 2015 at 3:11 PM, Jan Vesely > wrote: > > Does this mean it should be possible to hook up clover with > > nouv

Re: [Mesa-dev] [PATCH 13/16] nvc0: enable compute support by default on Fermi

2015-10-17 Thread Jan Vesely
Does this mean it should be possible to hook up clover with nouveau? Jan On Fri, 2015-10-16 at 19:22 +0200, Samuel Pitoiset wrote: > Compute support was not enabled by default because weird effects > on 3D state happened, but I can't reproduce them anymore. > > This also enables MP performance c

Re: [Mesa-dev] [PATCH] c11/threads: initialize timeout structure

2015-10-07 Thread Jan Vesely
sed > uninitialized. > > This patch is > > Reviewed-by: Ian Romanick thanks, can I also bug you to push it? I won't have commit access back until dec. Jan > > On 10/03/2015 05:19 PM, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > --- > >

[Mesa-dev] [PATCH] c11/threads: initialize timeout structure

2015-10-03 Thread Jan Vesely
Signed-off-by: Jan Vesely --- include/c11/threads_posix.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/c11/threads_posix.h b/include/c11/threads_posix.h index 3def6c4..ce9853b 100644 --- a/include/c11/threads_posix.h +++ b/include/c11/threads_posix.h @@ -136,8 +136,14

Re: [Mesa-dev] [PATCH 00/15] Resolve further GCC sign-compare warnings

2015-09-08 Thread Jan Vesely
> src/mesa/program/prog_to_nir.c| 2 +- > 8 files changed, 17 insertions(+), 17 deletions(-) > I have some of these fixed locally. I think the series should be squashed to 2 or 3 patches. patches 1-7,15 squashed into two are: Reviewed-by: Jan Vesely (I c

Re: [Mesa-dev] [PATCH 0/4] Resolve GCC missing field initializer warnings

2015-09-08 Thread Jan Vesely
ng field initializer warning. > > src/mesa/main/get_hash_params.py | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > I have had the same patch applied locally for some time. squash to one patch and you can add Reviewed-by: Jan Vesely

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-05 Thread Jan Vesely
ailure only builds the state tracker with no usable pipe drivers. jan > > On Wed, Aug 5, 2015 at 5:21 AM, Jan Vesely > wrote: > > On Tue, 2015-08-04 at 22:40 +0200, Zoltan Gilian wrote: > > > There is no MDOperand in llvm 3.5. > > > > thanks, this fixes the bu

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-04 Thread Jan Vesely
> + auto ty = get_operand_checked(kernel_node, 3, "kernel_arg_type", > +num_args + 1); > >std::vector res; >res.reserve(num_args); -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] clover: pass image attributes to the kernel

2015-08-03 Thread Jan Vesely
gt; + > >>> +typename module::argument::type marg_type; > >>> + if (is_image2d && is_read_only) { > >>> + marg_type = module::argument::image2d_rd; > >>> +} else if (is_image2d && is_

Re: [Mesa-dev] [PATCH] radeon/llvm: don't use a static array size for radeon_llvm_context::arrays

2015-06-08 Thread Jan Vesely
are volunteers, please > discuss it with Dave Airlie. > So the main work would be to add GL specific opcodes/intrinsics to the backend? I'd volunteer, but I think lack of time and GL knowledge would prevent me from making any kind of commitment. Jan > > Marek > > On Fri, J

[Mesa-dev] [PATCH v2 3/4] r600,compute: Plug memory leaks

2015-06-06 Thread Jan Vesely
v2: drop inline keyword drop radeon_llvm_dispose_kernel_module wrapper Signed-off-by: Jan Vesely --- I decided to keep radeon_shader_binary_clean,a nd dropped the other one. src/gallium/drivers/r600/evergreen_compute.c | 24 +--- src/gallium/drivers/r600/r600_llvm.c

Re: [Mesa-dev] [PATCH] radeon/llvm: don't use a static array size for radeon_llvm_context::arrays

2015-06-05 Thread Jan Vesely
On Tue, May 26, 2015 at 5:45 PM, Marek Olšák wrote: > On Wed, May 27, 2015 at 12:39 AM, Jan Vesely > wrote: > > On Wed, 2015-05-27 at 00:36 +0200, Marek Olšák wrote: > >> On Tue, May 26, 2015 at 10:19 PM, Emil Velikov < > emil.l.veli...@gmail.com> wrote: > &g

Re: [Mesa-dev] [PATCH 3/3] r600, compute: Plug couple of memory leaks

2015-06-05 Thread Jan Vesely
der_binary_clean look nicer then using memset in place of the first one. Similarly radeon_llvm_get_kernel_module radeon_llvm_dispose_kernel_module If that's not desirable, I'll remove the one-liners (binary_init, dispose_kernel_modules). Jan > > Marek > > On Tue, May 26, 2

Re: [Mesa-dev] [PATCH] radeon/llvm: don't use a static array size for radeon_llvm_context::arrays

2015-05-26 Thread Jan Vesely
7,8 @@ void radeon_llvm_dispose(struct radeon_llvm_context > >> * ctx) > >> { > >> LLVMDisposeModule(ctx->soa.bld_base.base.gallivm->module); > >> LLVMContextDispose(ctx->soa.bld_base.base.gallivm->con

[Mesa-dev] [PATCH 4/3] radeon, elf: Concatenate all rodata sections.

2015-05-25 Thread Jan Vesely
This prevents leaks and makes sure all data are available. In case there is only one section it works as before. Signed-off-by: Jan Vesely --- This might break stuff if something relied on previous rodata locations. src/gallium/drivers/radeon/radeon_elf_util.c | 9 ++--- 1 file changed, 6

[Mesa-dev] [PATCH 3/3] r600,compute: Plug couple of memory leaks

2015-05-25 Thread Jan Vesely
Signed-off-by: Jan Vesely --- src/gallium/drivers/r600/evergreen_compute.c | 24 +--- src/gallium/drivers/r600/r600_llvm.c | 14 +- src/gallium/drivers/r600/r600_llvm.h | 2 ++ src/gallium/drivers/radeon/r600_pipe_common.h | 17

[Mesa-dev] [PATCH 1/3] r600: Typos and whitespace fixes

2015-05-25 Thread Jan Vesely
Signed-off-by: Jan Vesely --- src/gallium/drivers/r600/evergreen_compute.c | 6 +++--- src/gallium/drivers/r600/evergreen_state.c | 4 ++-- src/gallium/drivers/r600/r600_asm.h | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/r600

[Mesa-dev] [PATCH 2/3] r600,compute: Upload rodata

2015-05-25 Thread Jan Vesely
reserve buffer id 2 for rodata Signed-off-by: Jan Vesely --- This needs coresponding LLVM changes (see [0], also posted) to work, but it does not break anything (except waste a buffer) without. Both series fix table based builtins (acosh, atanh, cosh, log1p), as well as gegl's f

Re: [Mesa-dev] [PATCH] clover: replace --enable-opencl-icd with --with-opencl-icd

2015-05-07 Thread Jan Vesely
t; --with-opencl-icd]) > >> +;; > >> +esac > >> + > >> +AM_CONDITIONAL(HAVE_CLOVER_ICD, test "x$OPENCL_ICD" != xno) > >> +AC_SUBST([OPENCL_LIBNAME]) > >> +AC_SUBST([ICD_FILE_DIR]) > >> + > >> dnl > >> d

Re: [Mesa-dev] llvmpipe support for ARM?

2015-04-15 Thread Jan Vesely
_ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Vjtt0vs_iqoI31UfJxBl7yv9I2FeiaeAYgMTLKRBc_I&m=5qZ4KpVhu_wXA8-dT

Re: [Mesa-dev] [PATCH] gallivm: Fix build since llvm-3.7.0svn r234495

2015-04-10 Thread Jan Vesely
e great. I have no push access. > > > > Thanks > > Nick Sarnie > > -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/1] gallivm: Fix build since llvm r233411

2015-03-27 Thread Jan Vesely
Signed-off-by: Jan Vesely --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp b/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp index bf6268b..d4d453d 100644 --- a/src/gallium/auxiliary/gallivm

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-26 Thread Jan Vesely
On Thu, 2015-03-26 at 22:27 -0400, Ilia Mirkin wrote: > On Thu, Mar 26, 2015 at 10:17 PM, Jan Vesely wrote: > > On Thu, 2015-03-26 at 21:11 -0400, Rob Clark wrote: > >> On Thu, Mar 26, 2015 at 8:59 PM, Ilia Mirkin wrote: > >> > On Thu, Mar 26, 2015 at 8:50 PM, Ro

Re: [Mesa-dev] Summer of Code ideas (maybe just an idea wishlist?)

2015-03-26 Thread Jan Vesely
into trouble... that > > was a few years back. > > yeah, spir-v is another good option.. I would hope that by the time > freedreno's compiler backend is sophisticated enough to be useful for > compute, we have a spir-v -> nir translation of some sort. Possibly > clover support for spir-v is the mo

Re: [Mesa-dev] [PATCH v2] egl/dri2: Fix GCC maybe-uninitialized warning.

2015-03-25 Thread Jan Vesely
On Wed, 2015-03-25 at 18:55 -0400, Ilia Mirkin wrote: > On Wed, Mar 25, 2015 at 6:51 PM, Jan Vesely wrote: > > On Fri, 2015-03-06 at 23:54 -0800, Vinson Lee wrote: > >> egl_dri2.c: In function ‘dri2_bind_tex_image’: > >> egl_dri2.c:1240:4: warning: ‘format’ may be

Re: [Mesa-dev] [PATCH v2] egl/dri2: Fix GCC maybe-uninitialized warning.

2015-03-25 Thread Jan Vesely
bind_tex_image(_EGLDriver *drv, >target = GL_TEXTURE_2D; >break; > default: > - assert(0); > + _eglError(EGL_BAD_SURFACE, "unrecognized target"); > + return EGL_FALSE; > } > > (*dri2_dpy->tex_buffer->setTexBuffer2)(dri2_ctx-

Re: [Mesa-dev] [PATCH] clover: Return CL_BUILD_ERROR for CL_PROGRAM_BUILD_STATUS when compilation fails

2015-03-24 Thread Jan Vesely
On Tue, 2015-03-24 at 22:36 +0200, Francisco Jerez wrote: > Jan Vesely writes: > > > On Tue, 2015-03-24 at 22:24 +0200, Francisco Jerez wrote: > >> Tom Stellard writes: > >> > >> > Cc: 10.5 10.4 > >> > --- > >> > src/gal

Re: [Mesa-dev] [PATCH] clover: Return CL_BUILD_ERROR for CL_PROGRAM_BUILD_STATUS when compilation fails

2015-03-24 Thread Jan Vesely
> > --- a/src/gallium/state_trackers/clover/core/program.hpp > > +++ b/src/gallium/state_trackers/clover/core/program.hpp > > @@ -73,6 +73,7 @@ namespace clover { > >std::map _binaries; > >std::map _logs; > >std::map _opts; > > + std::set _errs; > >

Re: [Mesa-dev] [PATCH] clover: Return 0 as storage size for local kernel args that are not set v2

2015-03-23 Thread Jan Vesely
virtual void unbind(exec_context &ctx); > >private: > - size_t _storage; > + size_t _storage = 0; > }; > > class constant_argument : public argument { Reviewed-by: Jan Vesely -- Jan Vesely signature.asc Description: This is a d

Re: [Mesa-dev] [PATCH] clover: Return 0 as storage size for local kernel args that are not set

2015-03-21 Thread Jan Vesely
On Sat, 2015-03-21 at 14:57 +0200, Francisco Jerez wrote: > Jan Vesely writes: > > > On Fri, 2015-03-20 at 23:29 +, Tom Stellard wrote: > >> The storage size for local kernel args can be queried before the > >> arguments are set by using the CL_KERNE

Re: [Mesa-dev] [PATCH 2/3] clover: Add all the mandatory 1.1 extensions to the extension string

2015-03-20 Thread Jan Vesely
+ " cl_khr_local_int32_base_atomics" > + " cl_khr_local_int32_extended_atomics" > + " cl_khr_byte_addressable_store" > + + std::string(dev.has_doubles() ? " cl_khr_fp64" : ""); >break; > > case CL_DEVICE_PLATFORM:

Re: [Mesa-dev] [PATCH 1/3] clover: Add a space at the end of CL_DEVICE_OPENCL_C_VERSION

2015-03-20 Thread Jan Vesely
m, >break; > > case CL_DEVICE_OPENCL_C_VERSION: > - buf.as_string() = "OpenCL C 1.1"; > + buf.as_string() = "OpenCL C 1.1 "; >break; > > case CL_DEVICE_PARENT_DEVICE: I guess since we don't provide any vendor specific info, thi

Re: [Mesa-dev] [PATCH] clover: The unit for CL_DEVICE_MEM_BASE_ADDR_ALIGN is bits not bytes

2015-03-20 Thread Jan Vesely
R_ALIGN: > + buf.as_scalar() = 128 * 8; > + break; > + > case CL_DEVICE_MIN_DATA_TYPE_ALIGN_SIZE: > buf.as_scalar() = 128; >break; Reviewed-by: Jan Vesely -- Jan Vesely signature.asc Description: This is a digitally signed message part

Re: [Mesa-dev] [PATCH] clover: Return 0 as storage size for local kernel args that are not set

2015-03-20 Thread Jan Vesely
nst { > + if (!_set) > + return 0; Shouldn't _storage be 0 before anybody calls local_argument::set anyway? maybe initializing it in a constructor would suffice? jan > return _storage; > } > -- Jan Vesely signature.asc Description: This is a digitally sig

Re: [Mesa-dev] [PATCH 1/2] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG v2

2015-03-06 Thread Jan Vesely
. jan >buf.as_scalar() = > - CL_FP_DENORM | CL_FP_INF_NAN | CL_FP_ROUND_TO_NEAREST; > + CL_FP_INF_NAN | CL_FP_ROUND_TO_NEAREST; >break; > > case CL_DEVICE_DOUBLE_FP_CONFIG: -- Jan Vesely signature.asc Description: This is a digitally signe

Re: [Mesa-dev] [PATCH] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG

2015-03-05 Thread Jan Vesely
ce_id d_dev, cl_device_info param, >break; > > case CL_DEVICE_SINGLE_FP_CONFIG: > + // This is the "mandated minimum single precision floating-point > + // capability" OCL 1.2 adds: "for devices that are not of type CL_DEVICE_TYPE_CUSTOM" Reviewed-

Re: [Mesa-dev] [PATCH v2 6/6] i965: Don't write past the end of the application supplied buffer

2015-03-04 Thread Jan Vesely
e calculation. Noticed by Jan. > > Signed-off-by: Ian Romanick > Cc: Kenneth Graunke > Cc: Jan Vesely > --- > src/mesa/drivers/dri/i965/brw_performance_monitor.c | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/d

Re: [Mesa-dev] replace __FUNCTION__ with __func__ task

2015-03-03 Thread Jan Vesely
t; > > _______ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/6] i965: Silence unused parameter warning

2015-02-28 Thread Jan Vesely
solution for this, but > it's really elegant. and it's also illegal in C (only allowed in C++) see 6.9.1 of c specs jan > > -Carl > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freede

Re: [Mesa-dev] [PATCH 6/6] i965: Don't write past the end of the application supplied buffer

2015-02-28 Thread Jan Vesely
S; > -data[offset++] = i; > -*((uint64_t *) (&data[offset])) = > monitor->pipeline_stats_results[i]; > -offset += 2; > +if (data + 4 <= data_end) { Same here. > + data[offset++] = PIPELINE_STATS_COUNTERS; >

Re: [Mesa-dev] [PATCH] st/nine: Mark end of non-void function unreachable

2015-02-09 Thread Jan Vesely
case D3DFMT_INTZ: > return PIPE_BIND_DEPTH_STENCIL | PIPE_BIND_SAMPLER_VIEW; > -default: assert(0); > +default: unreachable(0); Isn't unreachable supposed to use a string instead of 0? > } > } > -- Jan Vesely sign

[Mesa-dev] [PATCH 1/1] clover: Fix build with llvm after r226981

2015-01-25 Thread Jan Vesely
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88783 Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm

Re: [Mesa-dev] [PATCH] configure: Link against all LLVM targets when building clover

2015-01-25 Thread Jan Vesely
On Sun, 2015-01-25 at 01:02 +0100, Niels Ole Salscheider wrote: > On Saturday 24 January 2015, 18:24:16, Jan Vesely wrote: > > On Sat, 2015-01-24 at 22:49 +0100, Niels Ole Salscheider wrote: > > > Since 8e7df519bd8556591794b2de08a833a67e34d526, we initialise all targets > >

Re: [Mesa-dev] [PATCH] configure: Link against all LLVM targets when building clover

2015-01-24 Thread Jan Vesely
already had Tom's rb. you can add mine as well Reviewed-by: Jan Vesely > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 1cce517..2b7f576 100644 > --- a/configure.ac > +++ b/

Re: [Mesa-dev] [PATCH 2/3] mesa: Add initializer macros to fix missing initializer warnings

2015-01-22 Thread Jan Vesely
On Wed, 2015-01-21 at 15:55 -0800, Matt Turner wrote: > On Wed, Jan 21, 2015 at 3:49 PM, Jan Vesely wrote: > > On Wed, 2015-01-21 at 12:34 -0800, Ian Romanick wrote: > >> On 01/21/2015 10:33 AM, Jan Vesely wrote: > >> > NFC. > >> > >> NFC? I'm

Re: [Mesa-dev] [PATCH] configure: Link against all LLVM targets when building clover

2015-01-22 Thread Jan Vesely
On Thu, 2015-01-22 at 21:11 +0100, Niels Ole Salscheider wrote: > On Thursday 22 January 2015, 13:46:14, Jan Vesely wrote: > > On Thu, 2015-01-22 at 16:45 +, Emil Velikov wrote: > > > On 15/01/15 21:38, Tom Stellard wrote: > > > > On Thu, Jan 15, 2015 at 07:25:56P

Re: [Mesa-dev] [PATCH] configure: Link against all LLVM targets when building clover

2015-01-22 Thread Jan Vesely
jan > > Thanks > Emil > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Jan Vesely signature.asc Description: This is a digitally signed message

Re: [Mesa-dev] [PATCH 1/1] r600: upload implicit arguments even if there are no explicit args

2015-01-22 Thread Jan Vesely
On Tue, 2014-12-02 at 14:52 -0500, Jan Vesely wrote: > On Tue, 2014-12-02 at 11:33 -0500, Tom Stellard wrote: > > On Mon, Nov 03, 2014 at 08:29:37PM -0500, Jan Vesely wrote: > > > Signed-off-by: Jan Vesely > > > --- > > > > > > moreover, the condit

Re: [Mesa-dev] [PATCH 2/3] mesa: Add initializer macros to fix missing initializer warnings

2015-01-21 Thread Jan Vesely
On Wed, 2015-01-21 at 12:34 -0800, Ian Romanick wrote: > On 01/21/2015 10:33 AM, Jan Vesely wrote: > > NFC. > > NFC? I'm assuming this doesn't mean Near Field Communications or "no > 'fine' clue." No functional change. seen that in other commits

[Mesa-dev] [PATCH 3/3] mesa: more missing initializers

2015-01-21 Thread Jan Vesely
NFC. Signed-off-by: Jan Vesely --- src/mesa/state_tracker/st_extensions.c | 47 ++ 1 file changed, 31 insertions(+), 16 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 48ed9d2..f2bcf64 100644 --- a

[Mesa-dev] [PATCH 2/3] mesa: Add initializer macros to fix missing initializer warnings

2015-01-21 Thread Jan Vesely
NFC. Signed-off-by: Jan Vesely --- src/mesa/main/texcompress_bptc.c | 40 ++-- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/src/mesa/main/texcompress_bptc.c b/src/mesa/main/texcompress_bptc.c index c944ac2..56ca320 100644 --- a/src/mesa

[Mesa-dev] [PATCH 1/3] mesa: get_hash: Add missing field initializers

2015-01-21 Thread Jan Vesely
NFC. Signed-off-by: Jan Vesely --- This series fixes 38 -Wmissing-field-initializers warnings reported by gcc src/mesa/main/get_hash_params.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index

Re: [Mesa-dev] [PATCH] mesa: fix no return in two format functions

2015-01-16 Thread Jan Vesely
On Thu, 2015-01-15 at 20:49 +0100, Tobias Klausmann wrote: > On 15.01.2015 19:35, Jan Vesely wrote: > > On Thu, 2015-01-15 at 19:26 +0100, Tobias Klausmann wrote: > >> I: Program returns random data in a function > >> E: Mesa no-return-in-nonvoid-function > >>

Re: [Mesa-dev] [PATCH 0/2] low hanging warning fixes

2015-01-15 Thread Jan Vesely
On Thu, 2015-01-15 at 14:47 +, Jose Fonseca wrote: > On 14/01/15 20:53, Jan Vesely wrote: > > these two patches fix cca 90 warnings when compiling src/mesa. > > The idea is to reduce warning bloat so that the remaining stuff > > can be looked into to check whether the wa

[Mesa-dev] [PATCH v2 1/1] mesa: Fix some signed-unsigned comparison warnings

2015-01-15 Thread Jan Vesely
v2: s/unsigned int/unsigned/ in prog_optimize.c Signed-off-by: Jan Vesely --- src/mesa/main/bufferobj.c | 18 +- src/mesa/main/buffers.c | 2 +- src/mesa/main/clear.c | 2 +- src/mesa/main/dlist.c | 2

Re: [Mesa-dev] [PATCH] mesa: fix no return in two format functions

2015-01-15 Thread Jan Vesely
5 @@ _mesa_format_from_format_and_type(GLenum format, GLenum > type) > * format in that case. > */ > assert(!"Unsupported format"); > + return MESA_FORMAT_NONE; > } -- Jan Vesely signature.asc Description: This is a digitally signed me

Re: [Mesa-dev] [PATCH 2/2] mesa: Fix some signed-unsigned comparison warnings

2015-01-14 Thread Jan Vesely
On Wed, 2015-01-14 at 22:12 +0100, David Heidelberg wrote: > On 01/14/2015 09:53 PM, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > --- > > src/mesa/main/bufferobj.c | 18 +- > > src/mesa/main/buffers.c | 2 +-

[Mesa-dev] [PATCH 3/2] mesa: Add assert to check number of vector elements

2015-01-14 Thread Jan Vesely
The below code crashes when vector_elements <= 0 Fixes Warray-bounds warnings Signed-off-by: Jan Vesely --- src/mesa/program/ir_to_mesa.cpp| 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/program/ir_to_mesa.cpp b/

[Mesa-dev] [PATCH 0/2] low hanging warning fixes

2015-01-14 Thread Jan Vesely
-field-initializers 200 -Wsign-compare 16 -Wtype-limits to 2 -Warray-bounds 29 -Wmaybe-uninitialized 38 -Wmissing-field-initializers 125 -Wsign-compare Jan Vesely (2): mesa: remove comparisons that are always true mesa: Fix some signed-unsigned comparison warnings

[Mesa-dev] [PATCH 2/2] mesa: Fix some signed-unsigned comparison warnings

2015-01-14 Thread Jan Vesely
Signed-off-by: Jan Vesely --- src/mesa/main/bufferobj.c | 18 +- src/mesa/main/buffers.c | 2 +- src/mesa/main/clear.c | 2 +- src/mesa/main/dlist.c | 2 +- src/mesa/main/errors.c| 8

[Mesa-dev] [PATCH 1/2] mesa: remove comparisons that are always true

2015-01-14 Thread Jan Vesely
Signed-off-by: Jan Vesely --- src/mesa/program/prog_execute.c | 1 - src/mesa/program/prog_statevars.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/src/mesa/program/prog_execute.c b/src/mesa/program/prog_execute.c index 33c1751..85aba00 100644 --- a/src/mesa/program/prog_execute.c

Re: [Mesa-dev] [PATCH 1/1] util: Silence signed-unsigned comparison warnings

2014-12-16 Thread Jan Vesely
On Fri, 2014-12-12 at 17:30 +, Jose Fonseca wrote: > On 11/12/14 20:05, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > --- > > src/util/register_allocate.c | 12 ++-- > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --g

[Mesa-dev] [PATCH 1/1] util: Silence signed-unsigned comparison warnings

2014-12-11 Thread Jan Vesely
Signed-off-by: Jan Vesely --- src/util/register_allocate.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/util/register_allocate.c b/src/util/register_allocate.c index 1cfd66f..af7a20c 100644 --- a/src/util/register_allocate.c +++ b/src/util

[Mesa-dev] [PATCH 1/1] clover: Use switch

2014-12-05 Thread Jan Vesely
THis way we get a warning if an enum value is not handled v2: codestyle Signed-off-by: Jan Vesely Reviewed-by: Francisco Jerez --- src/gallium/state_trackers/clover/core/kernel.cpp | 44 ++- 1 file changed, 19 insertions(+), 25 deletions(-) diff --git a/src/gallium

Re: [Mesa-dev] [PATCH 1/1] st/xvmc: Fix compiler warnings

2014-12-03 Thread Jan Vesely
On Wed, 2014-12-03 at 11:15 +0100, Christian König wrote: > Am 02.12.2014 um 21:14 schrieb Jan Vesely: > > Mostly signed/unsigned comparison > > > > Signed-off-by: Jan Vesely > > Reviewed-by: Christian König > > Feel free to commit this patch or if you don&#

[Mesa-dev] [PATCH 1/1] st/xvmc: Fix compiler warnings

2014-12-02 Thread Jan Vesely
Mostly signed/unsigned comparison Signed-off-by: Jan Vesely --- src/gallium/state_trackers/xvmc/context.c | 6 +++--- src/gallium/state_trackers/xvmc/subpicture.c | 2 +- src/gallium/state_trackers/xvmc/xvmc_private.h | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 1/1] clover: Use switch when creating kernel arguments

2014-12-02 Thread Jan Vesely
This way we get a warning when an enum value is not handled Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/core/kernel.cpp | 45 ++- 1 file changed, 20 insertions(+), 25 deletions(-) diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp b/src

Re: [Mesa-dev] [PATCH 1/1] r600: upload implicit arguments even if there are no explicit args

2014-12-02 Thread Jan Vesely
On Tue, 2014-12-02 at 11:33 -0500, Tom Stellard wrote: > On Mon, Nov 03, 2014 at 08:29:37PM -0500, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > --- > > > > moreover, the condition is never true now that clover appends dim info > > > > src/galli

[Mesa-dev] [PATCH 1/1] r600, llvm: Don't leak global symbol offsets

2014-12-02 Thread Jan Vesely
Signed-off-by: Jan Vesely --- You were right, this one was leaking too. src/gallium/drivers/r600/r600_llvm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/r600/r600_llvm.c b/src/gallium/drivers/r600/r600_llvm.c index 3a3ee3a..a928fb8 100644 --- a/src/gallium/drivers

Re: [Mesa-dev] [PATCH 1/1] r600, llvm: Fix mem leak

2014-12-01 Thread Jan Vesely
ping On Mon, 2014-11-03 at 20:29 -0500, Jan Vesely wrote: > Signed-off-by: Jan Vesely > --- > src/gallium/drivers/r600/r600_llvm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/drivers/r600/r600_llvm.c > b/src/gallium/drivers/r600/r600_llvm.c >

[Mesa-dev] [PATCH libdrm 1/1] Fix some gcc -Wextra warnings

2014-11-30 Thread Jan Vesely
Signed-off-by: Jan Vesely --- Two warning remain in my setup (radeon only): tests/modeprint/modeprint.c:127 (-Wempty-body) I'm not sure what should happen here, or why the if is even there. Didn't feel right to add {} to shut up gcc xf86drm.c:322 (-Wtype-limits) Not sure what the se

[Mesa-dev] [PATCH libdrm 1/1] random: Use unsigned long for seed

2014-11-30 Thread Jan Vesely
This is more consistent with the rest of the code, and avoids potential undefined behavior (signed overflow) in drmRandom() Signed-off-by: Jan Vesely --- The output of test program with RANDOM_MAIN is unchanged. xf86drmRandom.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions

Re: [Mesa-dev] [PATCH 3/9] scons: Disable MSVC signed/unsigned mismatch warnings.

2014-11-26 Thread Jan Vesely
> '/wd4244', # conversion from 'type1' to 'type2', possible loss > of data > '/wd4305', # truncation from 'type1' to 'type2' > '/wd4800', # forcing value to bool 'true' or &#x

Re: [Mesa-dev] [PATCH 1/1] r600: upload implicit arguments even if there are no explicit args

2014-11-18 Thread Jan Vesely
ping On Mon, 2014-11-03 at 20:29 -0500, Jan Vesely wrote: > Signed-off-by: Jan Vesely > --- > > moreover, the condition is never true now that clover appends dim info > > src/gallium/drivers/r600/evergreen_compute.c | 4 > 1 file changed, 4 deletions(-) > &g

Re: [Mesa-dev] [10.4] git describe points to 10.2-branchpoint-3617-ga4ffc2a

2014-11-17 Thread Jan Vesely
AD > > 10.2-branchpoint-3007-ge1c5444 > > $ git describe --tags HEAD > > 10.3-branchpoint-937-ge1c5444 > > > I would assume that you had something based off 10.3 checked out ? > > $ git describe --tags origin/master > 10.4-branchpoint-25-gae4536b > > > -Emil > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH WIP 1/1] configure: include llvm systemlibs when using static llvm

2014-11-07 Thread Jan Vesely
On Wed, 2014-10-29 at 19:00 +, Emil Velikov wrote: > On 27/10/14 21:03, Jan Vesely wrote: > > On Mon, 2014-10-27 at 20:22 +, Emil Velikov wrote: > >> On 27/10/14 18:05, Jan Vesely wrote: > >>> On Mon, 2014-10-27 at 02:24 +, Emil Velikov wrote: > >>

[Mesa-dev] [PATCH 1/1] clover: Fix build after llvm r221375

2014-11-06 Thread Jan Vesely
Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp index e953822..3a4fcf0 100644 --- a/src

[Mesa-dev] [PATCH 1/1] r600: upload implicit arguments even if there are no explicit args

2014-11-03 Thread Jan Vesely
Signed-off-by: Jan Vesely --- moreover, the condition is never true now that clover appends dim info src/gallium/drivers/r600/evergreen_compute.c | 4 1 file changed, 4 deletions(-) diff --git a/src/gallium/drivers/r600/evergreen_compute.c b/src/gallium/drivers/r600/evergreen_compute.c

[Mesa-dev] [PATCH 1/1] r600, llvm: Fix mem leak

2014-11-03 Thread Jan Vesely
Signed-off-by: Jan Vesely --- src/gallium/drivers/r600/r600_llvm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/r600/r600_llvm.c b/src/gallium/drivers/r600/r600_llvm.c index c19693a..5f74bf7 100644 --- a/src/gallium/drivers/r600/r600_llvm.c +++ b/src/gallium/drivers

Re: [Mesa-dev] [PATCH WIP 1/1] configure: include llvm systemlibs when using static llvm

2014-10-27 Thread Jan Vesely
On Mon, 2014-10-27 at 20:22 +, Emil Velikov wrote: > On 27/10/14 18:05, Jan Vesely wrote: > > On Mon, 2014-10-27 at 02:24 +, Emil Velikov wrote: > >> On 26/10/14 19:36, Jan Vesely wrote: > >>> On Fri, 2014-10-24 at 23:54 +, Emil Velikov wrote: > >>

Re: [Mesa-dev] [PATCH WIP 1/1] configure: include llvm systemlibs when using static llvm

2014-10-27 Thread Jan Vesely
On Mon, 2014-10-27 at 02:24 +, Emil Velikov wrote: > On 26/10/14 19:36, Jan Vesely wrote: > > On Fri, 2014-10-24 at 23:54 +, Emil Velikov wrote: > >> On 24/10/14 17:03, Jan Vesely wrote: > >>> -Wl,--exclude-libs prevents automatic export of symbols > &

Re: [Mesa-dev] [PATCH WIP 1/1] configure: include llvm systemlibs when using static llvm

2014-10-26 Thread Jan Vesely
On Fri, 2014-10-24 at 23:54 +, Emil Velikov wrote: > On 24/10/14 17:03, Jan Vesely wrote: > > -Wl,--exclude-libs prevents automatic export of symbols > > > > > > CC: Kai Wasserbach > > CC: Emil Velikov > > Signed-off-by: Jan Vesely > > ---

Re: [Mesa-dev] [PATCH WIP 1/1] configure: include llvm systemlibs when using static llvm

2014-10-24 Thread Jan Vesely
On Fri, 2014-10-24 at 23:48 +0200, Kai Wasserbäch wrote: > Hi Jan, > Jan Vesely wrote on 24.10.2014 23:30: > > On Fri, 2014-10-24 at 22:42 +0200, Kai Wasserbäch wrote: > >> Jan Vesely wrote on 24.10.2014 19:03: > >>> -Wl,--exclude-libs prevents automatic export of

Re: [Mesa-dev] [PATCH WIP 1/1] configure: include llvm systemlibs when using static llvm

2014-10-24 Thread Jan Vesely
On Fri, 2014-10-24 at 22:42 +0200, Kai Wasserbäch wrote: > Hi Jan, > Jan Vesely wrote on 24.10.2014 19:03: > > -Wl,--exclude-libs prevents automatic export of symbols > > > > > > CC: Kai Wasserbach > > CC: Emil Velikov > > Signed-off-by: Jan Vesely

[Mesa-dev] [PATCH WIP 1/1] configure: include llvm systemlibs when using static llvm

2014-10-24 Thread Jan Vesely
-Wl,--exclude-libs prevents automatic export of symbols CC: Kai Wasserbach CC: Emil Velikov Signed-off-by: Jan Vesely --- Kai, can you try this patch with your setup, and check whether LLVM symbols are exported from mesa library? (and it's still working) Emil, would it help to

[Mesa-dev] [PATCH 1/1] configure: fix typos

2014-10-24 Thread Jan Vesely
Signed-off-by: Jan Vesely --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 93b25a2..a588d55 100644 --- a/configure.ac +++ b/configure.ac @@ -1970,7 +1970,7 @@ if test -n "$with_gallium_drivers"; then fi

Re: [Mesa-dev] [PATCH RFC 1/1] configure: Drop LLVM_COMPONENTS

2014-10-23 Thread Jan Vesely
myself (with shared libs) and discussed it with Tom few days ago. so it was not that quick :) since the --as-needed trick does not work I don't know what the correct solution is jan > > Cheers, > Kai > > > Jan Vesely wrote on 23.10.2014 21:58: > > Use -Wl,--as-ne

[Mesa-dev] [PATCH RFC 1/1] configure: Drop LLVM_COMPONENTS

2014-10-23 Thread Jan Vesely
Use -Wl,--as-needed instead This should fix the problem of using llvm split libraries. Since the component split may change it's safer to list everything and let linker filter out the unneeded ones. CC: Tom Stellard CC: Emil Velikov CC: k...@dev.carbon-project.org Signed-off-by: Jan V

Re: [Mesa-dev] [PATCH 1/1] glapi: Fix compiler warning and script name

2014-10-23 Thread Jan Vesely
On Thu, 2014-10-23 at 16:04 +0100, Emil Velikov wrote: > On 25/09/14 23:45, Jan Vesely wrote: > > On Wed, 2014-08-13 at 16:47 -0400, Jan Vesely wrote: > >> Signed-off-by: Jan Vesely > >> --- > >> src/mapi/glapi/gen/gl_gentable.py | 4 ++-- > >>

Re: [Mesa-dev] [PATCH v2 1/1] clover: Require libelf

2014-10-22 Thread Jan Vesely
On Wed, 2014-10-22 at 19:16 +0100, Emil Velikov wrote: > On 21/10/14 16:59, Jan Vesely wrote: > > v2: test for libelf once, check in both radeon and clover > > > > CC: Tom Stellard > > CC: Emil Velikov > > CC: Francisco Jerez > > Signed-off-by:

Re: [Mesa-dev] [PATCH 3/5] clover: Add support for compiling to native object code v3

2014-10-21 Thread Jan Vesely
d, we may end up > pulling in all the libraries due to the way the library dependencies work > (I'm not 100% sure about this, though). I think --as-needed could at least strip out non-backend libs, LLVMInitializeAll* will need all of the backends anyway (or selected ba

Re: [Mesa-dev] [PATCH 3/5] clover: Add support for compiling to native object code v3

2014-10-21 Thread Jan Vesely
s(mod, kernels); > + optimize(mod, optimization_level, kernels); > > module m; > // Build the clover::module > @@ -439,9 +624,14 @@ clover::compile_program_llvm(const compat::string > &source, > assert(0); > m = module(); > break; > - default: > + case PIPE_SHADER_IR_LLVM: > m = build_module_llvm(mod, kernels, address_spaces); > break; > + case PIPE_SHADER_IR_NATIVE: { > + std::vector code = compile_native(mod, triple, processor, > r_log); > + m = build_module_native(code, mod, kernels, address_spaces, r_log); > + break; > + } > } > #if HAVE_LLVM >= 0x0306 > // LLVM 3.6 and newer, the user takes ownership of the module. > diff --git a/src/gallium/targets/opencl/Makefile.am > b/src/gallium/targets/opencl/Makefile.am > index 43ba5dd..1c5a908 100644 > --- a/src/gallium/targets/opencl/Makefile.am > +++ b/src/gallium/targets/opencl/Makefile.am > @@ -23,6 +23,7 @@ lib@OPENCL_LIBNAME@_la_LIBADD = \ > $(top_builddir)/src/util/libmesautil.la \ > $(GALLIUM_PIPE_LOADER_WINSYS_LIBS) \ > $(GALLIUM_PIPE_LOADER_CLIENT_LIBS) \ > + $(ELF_LIB) \ > -ldl \ > -lclangCodeGen \ > -lclangFrontendTool \ -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2 1/1] clover: Require libelf

2014-10-21 Thread Jan Vesely
v2: test for libelf once, check in both radeon and clover CC: Tom Stellard CC: Emil Velikov CC: Francisco Jerez Signed-off-by: Jan Vesely --- configure.ac | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 0ed9325..93b25a2 100644

[Mesa-dev] [PATCH] clover: Require libelf

2014-10-20 Thread Jan Vesely
From: Jan Vesely CC: Tom Stellard CC: Emil Velikov CC: Francisco Jerez Signed-off-by: Jan Vesely --- This fixes clover build failures when building without radeon configure.ac | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure.ac b/configure.ac index 0ed9325..c3c42af 100644

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-10-11 Thread Jan Vesely
On Sun, 2014-10-12 at 01:56 +0300, Francisco Jerez wrote: > Jan Vesely writes: > > > On Sat, 2014-10-11 at 12:47 +0300, Francisco Jerez wrote: > >> Jan Vesely writes: > >> > >> > On Wed, 2014-10-08 at 18:02 +0300, Francisco Jerez wrote: > >&

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-10-11 Thread Jan Vesely
On Sun, 2014-10-12 at 01:56 +0300, Francisco Jerez wrote: > Jan Vesely writes: > > > On Sat, 2014-10-11 at 12:47 +0300, Francisco Jerez wrote: > >> Jan Vesely writes: > >> > >> > On Wed, 2014-10-08 at 18:02 +0300, Francisco Jerez wrote: > >&

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-10-11 Thread Jan Vesely
On Sat, 2014-10-11 at 12:47 +0300, Francisco Jerez wrote: > Jan Vesely writes: > > > On Wed, 2014-10-08 at 18:02 +0300, Francisco Jerez wrote: > >> Jan Vesely writes: > >> > >> > [SNIP] > >> >> > > >> >> > > I

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-10-10 Thread Jan Vesely
On Wed, 2014-10-08 at 18:02 +0300, Francisco Jerez wrote: > Jan Vesely writes: > > > [SNIP] > >> > > >> > > I also don't like that this way there is no difference between > >> > > explicit and implicit kernel arguments. On the other

<    1   2   3   4   5   6   >