Re: [Mesa-dev] [PATCH 0/2] Restore optional xf86vidmode

On 08/01/2019 23:54, Rhys Kidd wrote: On Tue, 11 Dec 2018 at 10:22, Jon Turney wrote: Restore optional xf86vidmode, and fix the meson build to actually use it. Jon Turney (2): Revert "glx: make xf86vidmode mandatory for direct rendering" Fix typo preventing xxf86vm being use

Re: [Mesa-dev] [PATCH] glx: Fix compilation with GLX_USE_WINDOWSGL

On 14/12/2018 19:22, Jon Turney wrote: On 14/12/2018 15:15, Emil Velikov wrote: On Fri, 14 Dec 2018 at 14:56, Jon Turney wrote: Sadly, the GLX_USE_APPLEGL and GLX_USE_WINDOWSGL cases are not identical (because GLX_USE_WINDOWSGL uses vtables rather than a maze of ifdefs) Include again

Re: [Mesa-dev] [PATCH] glx: Fix compilation with GLX_USE_WINDOWSGL

On 14/12/2018 15:15, Emil Velikov wrote: On Fri, 14 Dec 2018 at 14:56, Jon Turney wrote: Sadly, the GLX_USE_APPLEGL and GLX_USE_WINDOWSGL cases are not identical (because GLX_USE_WINDOWSGL uses vtables rather than a maze of ifdefs) Include again, as functions prototyped by it are used

[Mesa-dev] [PATCH 2/2] appveyor: Add a Cygwin build script

Signed-off-by: Jon Turney --- appveyor.yml| 19 +- scripts/appveyor_cygwin.bat | 40 + 2 files changed, 54 insertions(+), 5 deletions(-) create mode 100644 scripts/appveyor_cygwin.bat diff --git a/appveyor.yml b/appveyor.yml

[Mesa-dev] [PATCH 1/2] appveyor: put build steps in a script, rather than inline in appveyor.yml

Signed-off-by: Jon Turney --- appveyor.yml | 32 +++- scripts/appveyor_msvc.bat | 38 ++ 2 files changed, 41 insertions(+), 29 deletions(-) create mode 100644 scripts/appveyor_msvc.bat diff --git a/appveyor.yml b

[Mesa-dev] [PATCH 0/2] appveyor: add Cygwin

This is a refresh of my patch set from [1], which I posted, and then kind of forgot about. [1] https://lists.freedesktop.org/archives/mesa-dev/2018-February/185066.html Jon Turney (2): appveyor: put build steps in a script, rather than inline in appveyor.yml appveyor: Add a Cygwin build

[Mesa-dev] [PATCH] glx: Fix compilation with GLX_USE_WINDOWSGL

match the one at it's declaration again, as it's referenced from dri_common.c which is built for GLX_USE_WINDOWSGL. Cc: Emil Velikov Fixes: a95ec138 ("glx: mandate xf86vidmode only for "drm" dri platforms") Signed-off-by: Jon Turney --- src/glx/glxcmds.c | 6 -- 1 file c

Re: [Mesa-dev] [PATCH 2/2] glx: make xf86vidmode mandatory for direct rendering

On 16/11/2018 15:12, Eric Engestrom wrote: On Friday, 2018-11-16 13:59:01 +, Emil Velikov wrote: From: Emil Velikov Currently we detect the module and if missing, the glXGetMsc* API is effectively a stub, always returning false. This is what effectively has been happening with our meson

[Mesa-dev] [PATCH 2/2] Fix typo preventing xxf86vm being used in meson build

Also add now needed xxf86vm to the dependencies of libGL Signed-off-by: Jon Turney --- src/glx/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glx/meson.build b/src/glx/meson.build index 1de35fca6bc..2507993ed52 100644 --- a/src/glx/meson.build +++ b/src

[Mesa-dev] [PATCH 1/2] Revert "glx: make xf86vidmode mandatory for direct rendering"

This reverts commit 5bc509363b6dbc42af72668fe500b6aec988dbf0. Signed-off-by: Jon Turney --- configure.ac| 12 +++- meson.build | 6 -- src/glx/Makefile.am | 5 + src/glx/SConscript | 5 - src/glx/glxcmds.c | 7 ++- src/glx/meson.build | 6

[Mesa-dev] [PATCH 0/2] Restore optional xf86vidmode

Restore optional xf86vidmode, and fix the meson build to actually use it. Jon Turney (2): Revert "glx: make xf86vidmode mandatory for direct rendering" Fix typo preventing xxf86vm being used in meson build configure.ac| 12 +++- meson.build | 6 -

[Mesa-dev] [PATCH] meson: use correct keyword to fix a meson warning

With a sufficently recent meson, the following warning is produced: WARNING: Passed invalid keyword argument "extra_args". WARNING: This will become a hard error in the future. It seems that compiler.links(args:) is meant here. Signed-off-by: Jon Turney --- meson.build | 2 +- 1 fi

[Mesa-dev] [PATCH] Make glXChooseFBConfig handle unspecified sRGB correctly

Make glXChooseFBConfig properly handle the case where the only matching configs have the sRGB flag set, but no sRGB attribute is specified. Since 6e06e281, the sRGBcapable flag is now actually compared, using MATCH_DONT_CARE. 7b0f912e added defaulting of sRGBcapable to GL_FALSE in

Re: [Mesa-dev] [PATCH] vma/tests: Fix compilation if limits.h defines PAGE_SIZE

On 05/07/2018 16:13, Eric Engestrom wrote: On Thursday, 2018-07-05 15:52:01 +0100, Jon Turney wrote: per POSIX, limits.h may define PAGE_SIZE when the value is not indeterminate "may define" -> don't you need #ifdef around #undef? Annoyingly, I though exactly this, and then for

[Mesa-dev] [PATCH] vma/tests: Fix compilation if limits.h defines PAGE_SIZE (v2)

per POSIX, limits.h may define PAGE_SIZE when the value is not indeterminate v2: just change the variable name, since there's no intended correlation here between this value and the machine's actual page size. Cc: Scott D Phillips Signed-off-by: Jon Turney --- src/util/tests/vma

[Mesa-dev] [PATCH] vma/tests: Fix compilation if limits.h defines PAGE_SIZE

per POSIX, limits.h may define PAGE_SIZE when the value is not indeterminate Cc: Scott D Phillips Signed-off-by: Jon Turney --- src/util/tests/vma/vma_random_test.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/tests/vma/vma_random_test.cpp b/src/util/tests/vma

Re: [Mesa-dev] [PATCH 41/48] meson: Fix gtest linkage on msvc

On 11/06/2018 23:56, Dylan Baker wrote: We need to add an extra flag (/SUBSYSTEM:CONSOLE) to get the msvc linker to find main() in a static library. --- src/gtest/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gtest/meson.build b/src/gtest/meson.build index

Re: [Mesa-dev] [PATCH mesa] meson: add GL/glext.h warning fix for MacOS

On 12/06/2018 16:53, Dylan Baker wrote: Quoting Eric Engestrom (2018-06-12 04:25:10) Copied from configure.ac:1950 Signed-off-by: Eric Engestrom --- Is it still needed? We've been building on MacOS for a while, yet nobody noticed anything (Dylan?) If not, we should probably avoid unnecessary

Re: [Mesa-dev] [PATCH] vbo: Use alloca for _vbo_draw_indirect.

sa-dev/2018-January/184030.html https://lists.freedesktop.org/archives/mesa-dev/2017-December/180073.html https://lists.freedesktop.org/archives/mesa-dev/2016-July/122346.html From 8599fd9109d59adc541ab06570732776e2c098d6 Mon Sep 17 00:00:00 2001 From: Jon Turney <jon.tur...@dronecode.org.uk>

Re: [Mesa-dev] [PATCH] u_endian.h: make endianness check libc agnostic

On 21/03/2018 15:09, Emil Velikov wrote: Hi Maxin, Welcome back ;-) On 21 March 2018 at 14:52, wrote: From: Khem Raj endianness check is OS wide and not specific to libc. Fixes build with musl libc Signed-off-by: Khem Raj

Re: [Mesa-dev] [PATCH 0/5] Fix meson omx compilation

/meson.build| 2 +- 7 files changed, 95 insertions(+), 84 deletions(-) Thanks for fixing this. Reviewed-by: Jon Turney <jon.tur...@dronecode.org.uk> ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 2/2] appveyor: Add a Cygwin build script

v2: Use ccache build using meson, rather than autotools --- appveyor.yml| 19 ++- scripts/appveyor_cygwin.bat | 39 +++ 2 files changed, 53 insertions(+), 5 deletions(-) create mode 100644 scripts/appveyor_cygwin.bat diff --git

[Mesa-dev] [PATCH 1/2] appveyor: put build steps in a script, rather than inline in appveyor.yml

--- appveyor.yml | 29 +++-- scripts/appveyor_msvc.bat | 35 +++ 2 files changed, 38 insertions(+), 26 deletions(-) create mode 100644 scripts/appveyor_msvc.bat diff --git a/appveyor.yml b/appveyor.yml index

[Mesa-dev] [PATCH 0/2] appveyor: add Cygwin

Jon Turney (2): appveyor: put build steps in a script, rather than inline in appveyor.yml appveyor: Add a Cygwin build script appveyor.yml| 40 +--- scripts/appveyor_cygwin.bat | 39 +++ scripts

[Mesa-dev] [PATCH] meson: ensure xmlpool/options.h is generated for libgallium

In file included from ../src/gallium/targets/dri/target.c:1: In file included from ../src/gallium/auxiliary/target-helpers/drm_helper.h:8: ../src/util/xmlpool.h:103:10: fatal error: 'xmlpool/options.h' file not found See also 26bde1e3. Signed-off-by: Jon Turney <jon.tur...@dronecode.org

Re: [Mesa-dev] [PATCH] meson: better defaults for osx, windows and cygwin

On 05/02/2018 17:34, Dylan Baker wrote: Quoting Jon Turney (2018-02-03 13:19:20) On 03/02/2018 18:07, Dylan Baker wrote: Quoting Jon Turney (2018-02-03 05:49:40) - if not ['darwin', 'windows'].contains(host_machine.system()) + if not ['darwin', 'windows', 'cygwin'].contains

Re: [Mesa-dev] [PATCH] meson: better defaults for osx, windows and cygwin

On 03/02/2018 18:07, Dylan Baker wrote: Quoting Jon Turney (2018-02-03 05:49:40) - if not ['darwin', 'windows'].contains(host_machine.system()) + if not ['darwin', 'windows', 'cygwin'].contains(host_machine.system()) +# TODO: PPC, Sparc if ['x86', 'x86_64'].contains

Re: [Mesa-dev] [PATCH 6/6] travis: add macOS meson build

On 01/02/2018 13:13, Emil Velikov wrote: On 28 January 2018 at 14:24, Jon Turney wrote: --- .travis.yml | 5 + 1 file changed, 5 insertions(+) diff --git a/.travis.yml b/.travis.yml index 9cecf2f615f..7e6bbfe306b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -403,6 +403,11 @@ matrix

[Mesa-dev] [PATCH] meson: better defaults for osx, windows and cygwin

set suitable defaults for 'dri-drivers', 'gallium-drivers', 'vulkan-drivers' and 'platforms' options for osx, windows and cygwin, adding cygwin where appropriate. Signed-off-by: Jon Turney <jon.tur...@dronecode.org.uk> --- meson.build | 15 --- 1 file changed, 8 insertions

Re: [Mesa-dev] [PATCH 1/6] meson: find python2 on macOS

On 01/02/2018 11:49, Emil Velikov wrote: On 28 January 2018 at 14:24, Jon Turney <jon.tur...@dronecode.org.uk> wrote: From: Dylan Baker <dy...@pnwbakers.com> --- meson.build | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson

[Mesa-dev] [PATCH 2/4] travis: conditionalize building of prerequisites on if OS=linux

Use a '|' YAML literal block to avoid the convoluted syntax needed to put the entire conditional on a single line. Signed-off-by: Jon Turney <jon.tur...@dronecode.org.uk> --- .travis.yml | 91 +++-- 1 file changed, 47 insertions(

[Mesa-dev] [PATCH 4/4] travis: add osx autotools build

Signed-off-by: Jon Turney <jon.tur...@dronecode.org.uk> --- .travis.yml | 30 ++ 1 file changed, 30 insertions(+) diff --git a/.travis.yml b/.travis.yml index e18327bec9..fc137c9667 100644 --- a/.travis.yml +++ b/.travis.yml @@ -396,6 +396,36 @@

[Mesa-dev] [PATCH 0/4] Fix osx build and add to CI (reprise)

Jon Turney (4): glx/test: fix building for osx travis: conditionalize building of prerequisites on if OS=linux travis: pip -> pip2 travis: add osx autotools build .travis.yml | 123 -- src/glx/tests/fake_glx_screen.cpp |

[Mesa-dev] [PATCH 3/4] travis: pip -> pip2

-off-by: Jon Turney <jon.tur...@dronecode.org.uk> --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 1d6cf98519..e18327bec9 100644 --- a/.travis.yml +++ b/.travis.yml @@ -398,7 +398,7 @@ matrix: - libelf-dev i

[Mesa-dev] [PATCH 1/4] glx/test: fix building for osx

An additional stub for applegl_create_context() is needed Cannot test indirect API as it's not built on osx, currently Signed-off-by: Jon Turney <jon.tur...@dronecode.org.uk> --- src/glx/tests/fake_glx_screen.cpp | 11 +++ src/glx/tests/indirect_api.cpp| 4 2 files chang

Re: [Mesa-dev] [PATCH 4/6] meson: osx doesn't have librt, so don't require it

On 31/01/2018 15:21, Emil Velikov wrote: On 30 January 2018 at 20:27, Dylan Baker <dy...@pnwbakers.com> wrote: Quoting Emil Velikov (2018-01-30 10:56:42) Hi Jon, On 28 January 2018 at 14:24, Jon Turney <jon.tur...@dronecode.org.uk> wrote: --- meson.build | 2 +- 1 fil

Re: [Mesa-dev] [PATCH 12/20] mesa: implement buffer/texture barriers for semaphore signal/wait v2

se of alloca(), without a corresponding #include. Patch attached. See also: https://lists.freedesktop.org/archives/mesa-dev/2017-December/180073.html https://lists.freedesktop.org/archives/mesa-dev/2016-July/122346.html From 46a2c9bbd03234120594d50b48cbad73a355d240 Mon Sep 17 00:00:00 2001 Fro

[Mesa-dev] [PATCH 5/6] meson: osx ld doesn't support --build-id

--- meson.build | 4 src/mesa/drivers/dri/meson.build | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 8fdbaa8b8d8..655a93cecef 100644 --- a/meson.build +++ b/meson.build @@ -914,6 +914,10 @@ if cc.links('int main() {

[Mesa-dev] [PATCH 6/6] travis: add macOS meson build

--- .travis.yml | 5 + 1 file changed, 5 insertions(+) diff --git a/.travis.yml b/.travis.yml index 9cecf2f615f..7e6bbfe306b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -403,6 +403,11 @@ matrix: - MAKE_CHECK_COMMAND="make check" - DRI_LOADERS="--with-platforms=x11

[Mesa-dev] [PATCH 0/6] meson: build src/glx/apple

This also requires my "fix osx" series to actually build Dylan Baker (2): meson: find python2 on macOS meson: set apple glx defines Jon Turney (4): meson: build src/glx/apple meson: osx doesn't have librt, so don't require it meson: osx ld doesn't support --build-id travis:

[Mesa-dev] [PATCH 4/6] meson: osx doesn't have librt, so don't require it

--- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 7e194a9f10d..8fdbaa8b8d8 100644 --- a/meson.build +++ b/meson.build @@ -935,7 +935,7 @@ elif with_dri_i965 and get_option('shader-cache') endif # Determine whether or not the rt

[Mesa-dev] [PATCH 2/6] meson: set apple glx defines

From: Dylan Baker --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index 178743eddb1..7e194a9f10d 100644 --- a/meson.build +++ b/meson.build @@ -616,6 +616,8 @@ if with_platform_x11 endif if with_dri_platform == 'drm'

[Mesa-dev] [PATCH 3/6] meson: build src/glx/apple

000..f69803713e0 --- /dev/null +++ b/src/glx/apple/meson.build @@ -0,0 +1,62 @@ +# Copyright © 2017 Jon Turney + +# Permission is hereby granted, free of charge, to any person obtaining a copy +# of this software and associated documentation files (the "Software"), to deal +# in th

[Mesa-dev] [PATCH 6/6] travis: add osx autotools build

--- .travis.yml | 123 ++-- 1 file changed, 78 insertions(+), 45 deletions(-) diff --git a/.travis.yml b/.travis.yml index 211df3ec1ef..9cecf2f615f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -396,9 +396,39 @@ matrix: -

[Mesa-dev] [PATCH 1/6] meson: find python2 on macOS

From: Dylan Baker --- meson.build | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 824e3c46bc5..178743eddb1 100644 --- a/meson.build +++ b/meson.build @@ -642,7 +642,13 @@ if with_platform_android pre_args +=

[Mesa-dev] [PATCH 4/6] glx/apple: locate dispatch table functions to wrap by name

Avoid reaching into the dispatch table internals (and thus having to deal with the complexities of remap etc.) by identifying functions to wrap by name. See: https://lists.freedesktop.org/archives/mesa-dev/2015-June/086721.html et seq. https://bugs.freedesktop.org/show_bug.cgi?id=90311 ---

[Mesa-dev] [PATCH 0/6] Fix osx build and add to CI

Jon Turney (6): configure: Default to gbm=no on osx osx: ld doesn't support --build-id glx/apple: include util/debug.h for env_var_as_boolean prototype glx/apple: locate dispatch table functions to wrap by name glx/test: fix building for osx travis: add osx autotools build

[Mesa-dev] [PATCH 1/6] configure: Default to gbm=no on osx

--- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index ae5162319d1..daa040d3194 100644 --- a/configure.ac +++ b/configure.ac @@ -1270,10 +1270,10 @@ AC_ARG_ENABLE([xa], [enable_xa=no]) AC_ARG_ENABLE([gbm],

[Mesa-dev] [PATCH 2/6] osx: ld doesn't support --build-id

--- configure.ac | 13 + src/mesa/drivers/dri/Makefile.am | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index daa040d3194..a54b7cb6650 100644 --- a/configure.ac +++ b/configure.ac @@ -685,6 +685,19 @@

[Mesa-dev] [PATCH 3/6] glx/apple: include util/debug.h for env_var_as_boolean prototype

mesa/src/glx/glxcmds.c:1295:21: error: implicit declaration of function 'env_var_as_boolean' is invalid in C99 [-Werror,-Wimplicit-function-declaration] mesa/src/glx/apple/apple_visual.c:85:28: error: implicit declaration of function 'env_var_as_boolean' is invalid in C99

[Mesa-dev] [PATCH] meson: libdrm shouldn't appear in Requires.private: if it wasn't found

Signed-off-by: Jon Turney <jon.tur...@dronecode.org.uk> --- meson.build | 6 -- src/mesa/drivers/dri/meson.build | 7 ++- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index bc5996992a3..824e3c46bc5 100644 --- a/meson

Re: [Mesa-dev] [PATCH v2] meson: correctly set sysconfdir for drirc

On 24/01/2018 19:35, Dylan Baker wrote: v2: - Also fix drirc install path Fixes: d1992255bb29 ("meson: Add build Intel "anv" vulkan driver") Reported-by: Marc Dietrich Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom

Re: [Mesa-dev] [PATCH] meson: correctly set SYSCONFDIR for loading dirrc

On 24/01/2018 18:19, Dylan Baker wrote: Quoting Emil Velikov (2018-01-24 03:53:35) On 24 January 2018 at 10:39, Marc Dietrich wrote: Hi Dylan, Am Dienstag, 23. Januar 2018, 19:28:08 CET schrieb Dylan Baker: Fixes: d1992255bb29 ("meson: Add build Intel "anv" vulkan driver")

Re: [Mesa-dev] [PATCH 1/2] meson: Fix configuring dri glx with only gallium drivers

, that's all it does (due to some badness I have some half-finished patches to fix...) Quoting Adam Jackson (2018-01-12 09:06:37) On Fri, 2018-01-12 at 13:18 +, Jon Turney wrote: 'meson -Ddri-drivers= -Dgallium-drivers=swrast -Dglx=dri' fails with 'dri based GLX requires at least one DRI driver

Re: [Mesa-dev] [PATCH 1/2] meson: Fix configuring dri glx with only gallium drivers

, be simpler, and avoid accidentally adding dri sources when we shouldn't. Ah, yes. I'd completely failed to spot that in the 'auto' case above. How about the attached? From f6d27e04bd7d8581b2cb723edaf6449eddb77cc8 Mon Sep 17 00:00:00 2001 From: Jon Turney <jon.tur...@dronecode.org.uk> Date: Mon,

[Mesa-dev] [PATCH 2/2] meson: Fix install and linking of gallium swrast only driver

When configured 'meson -Ddri-drivers= -Dgallium-drivers=swrast -Dglx=dri' link and install a galliumized swrast_dri.so Also install dri.pc and internal/dri_interface.h Signed-off-by: Jon Turney <jon.tur...@dronecode.org.uk> --- include/meson.build| 2 +- src/g

[Mesa-dev] [PATCH 0/2] meson: Fixes when gallium swarast is the only driver configured

Jon Turney (2): meson: Fix configuring dri glx with only gallium drivers meson: Fix install and linking of gallium swrast only driver include/meson.build| 2 +- meson.build| 2 +- src/gallium/meson.build| 2 +- src

[Mesa-dev] [PATCH 1/2] meson: Fix configuring dri glx with only gallium drivers

'meson -Ddri-drivers= -Dgallium-drivers=swrast -Dglx=dri' fails with 'dri based GLX requires at least one DRI driver' Signed-off-by: Jon Turney <jon.tur...@dronecode.org.uk> --- meson.build | 2 +- src/glx/meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [Mesa-dev] [PATCH v2 05/25] mesa: implement SPIR-V loading in glShaderBinary

f (!sh) { + _mesa_error(ctx, GL_OUT_OF_MEMORY, "glShaderBinary"); + return; + } + This adds a use of alloca() without a corresponding #include. Patch attached. From 3b00c72a92ca1091d11ecffd8db404dcd598e63d Mon Sep 17 00:00:00 2001 From: Jon Turney <jon.tur...@dronecode.or

Re: [Mesa-dev] [PATCH 0/3] Fix linkage for libEGL and libGLX without dri3

/egl/meson.build| 2 +- src/glx/meson.build| 14 +- src/loader/meson.build | 3 +-- 3 files changed, 11 insertions(+), 8 deletions(-) Great, thanks! Reviewed-by: Jon Turney <jon.tur...@dronecode.org.uk> ___ mesa-dev mailin

Re: [Mesa-dev] [PATCH 7/7] meson: fix deps and underlinkage of libGL

On 30/11/2017 16:46, Emil Velikov wrote: On 30 November 2017 at 15:13, Jon Turney wrote: On 29/11/2017 17:34, Dylan Baker wrote: [...] Maybe it's me that's missing something... There are references to functions provided by these libraries (xcb_glx, xcb, x11_xcb) in common code. Having

Re: [Mesa-dev] [PATCH 7/7] meson: fix deps and underlinkage of libGL

On 29/11/2017 17:34, Dylan Baker wrote: Quoting Jon Turney (2017-11-29 08:22:54) On 28/11/2017 18:21, Dylan Baker wrote: Quoting Emil Velikov (2017-11-27 06:31:35) IIRC Windows mandates binaries with unresolved symbols. Other platforms allow such behaviour. I think we want to set b_lundef

Re: [Mesa-dev] [PATCH 5/7] meson: build src/glx/windows

On 27/11/2017 18:35, Dylan Baker wrote: Quoting Jon Turney (2017-11-27 05:58:32) --- src/glx/meson.build | 25 +-- src/glx/windows/meson.build | 48 + 2 files changed, 63 insertions(+), 10 deletions(-) create mode

Re: [Mesa-dev] [PATCH 7/7] meson: fix deps and underlinkage of libGL

On 28/11/2017 18:21, Dylan Baker wrote: Quoting Emil Velikov (2017-11-27 06:31:35) IIRC Windows mandates binaries with unresolved symbols. Other platforms allow such behaviour. I think we want to set b_lundef=true, to catch these issues as part of the build process. We already do so in the

[Mesa-dev] [PATCH 3/7] meson: set windows glx defines

--- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index c24225c0297..d0618f97344 100644 --- a/meson.build +++ b/meson.build @@ -378,6 +378,8 @@ if with_platform_x11 endif if with_dri_platform == 'drm' pre_args += '-DGLX_USE_DRM' +

[Mesa-dev] [PATCH 0/7] [RFC] meson: build src/glx/windows

source inclusion on macOS and Windows meson: Don't build egl on macOS or Windows Jon Turney (5): meson: set windows glx defines meson: set _GNU_SOURCE on cygwin meson: build src/glx/windows meson: don't require dri2proto for darwin or windows meson: fix deps and underlinkage of libGL

[Mesa-dev] [PATCH 6/7] meson: don't require dri2proto for darwin or windows

--- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index cf6e028746a..68361fc4606 100644 --- a/meson.build +++ b/meson.build @@ -888,7 +888,9 @@ if with_platform_x11 endif endif if with_glx == 'dri' -dep_dri2proto =

[Mesa-dev] [PATCH 2/7] meson: Don't build egl on macOS or Windows

From: Dylan Baker --- meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 53013e47ec4..c24225c0297 100644 --- a/meson.build +++ b/meson.build @@ -261,7 +261,10 @@ endif _egl = get_option('egl') if _egl ==

[Mesa-dev] [PATCH 5/7] meson: build src/glx/windows

--- src/glx/meson.build | 25 +-- src/glx/windows/meson.build | 48 + 2 files changed, 63 insertions(+), 10 deletions(-) create mode 100644 src/glx/windows/meson.build diff --git a/src/glx/meson.build b/src/glx/meson.build

[Mesa-dev] [PATCH 1/7] meson: fix generated source inclusion on macOS and Windows

From: Dylan Baker --- src/mapi/glapi/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/glapi/meson.build b/src/mapi/glapi/meson.build index 14ffa68ad0d..8856a95fb66 100644 --- a/src/mapi/glapi/meson.build +++

[Mesa-dev] [PATCH 4/7] meson: set _GNU_SOURCE on cygwin

--- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index d0618f97344..cf6e028746a 100644 --- a/meson.build +++ b/meson.build @@ -467,7 +467,7 @@ if cc.compiles('int foo(void) { return 0; } int bar(void) __attribute__((alias(" endif #

[Mesa-dev] [PATCH 7/7] meson: fix deps and underlinkage of libGL

--- meson.build | 6 -- src/glx/meson.build | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 68361fc4606..524a03eaa97 100644 --- a/meson.build +++ b/meson.build @@ -866,7 +866,7 @@ if with_platform_x11 dep_x11 =

Re: [Mesa-dev] [PATCH 1/3] util: Fix SHA1 implementation on big endian

fails when built for the wrong endianess, so there is some hope to notice this... From e5c6197bdb4dec926ab31534b8533dd1bf14dfa1 Mon Sep 17 00:00:00 2001 From: Jon Turney <jon.tur...@dronecode.org.uk> Date: Mon, 27 Nov 2017 13:32:53 + Subject: [PATCH] Also include endian.h on

Re: [Mesa-dev] [PATCH 1/3] util: Fix SHA1 implementation on big endian

On 25/11/2017 04:24, Matt Turner wrote: diff --git a/src/util/u_endian.h b/src/util/u_endian.h index 7bbd7dc215..3d5c006f35 100644 --- a/src/util/u_endian.h +++ b/src/util/u_endian.h @@ -67,4 +67,7 @@ #endif +#warn Unknown Endianness for this platform. Assuming little endian +#define

Re: [Mesa-dev] [PATCH 5/6] meson: add logic to select apple and windows dri

On 21/11/2017 00:50, Dylan Baker wrote: This is still not fully correct (haiku and BSD are probably not correct), but Linux is not regressed and this should be correct for macOS and Windows. Signed-off-by: Dylan Baker --- meson.build | 15 +-- 1 file

[Mesa-dev] [PATCH] mapi: Teach es{1, 2}api/ABI-check shared library names on Cygwin

Ideally we'd be able to get the library filename from libtool, but that doesn't seem to be a feature... Use of ${uname} is presumably ok here as we won't be running 'make check' if we are cross-compiling Signed-off-by: Jon Turney <jon.tur...@dronecode.org.uk> --- src/mapi/es1api/ABI-chec

Re: [Mesa-dev] [PATCH v2] threads, configure.ac, meson.build: define and use HAVE_TIMESPEC_GET

On 15/11/2017 14:35, Nicolai Hähnle wrote: From: Nicolai Hähnle <nicolai.haeh...@amd.com> v2: add HAVE_TIMESPEC_GET for non-Windows Scons builds Cc: Jon Turney <jon.tur...@dronecode.org.uk> Cc: Rob Herring <r...@kernel.org> Cc: Alexander von Gluck IV <kallis...@unixzen

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

On 15/11/2017 11:21, Nicolai Hähnle wrote: On 13.11.2017 23:55, Rob Herring wrote: On Fri, Nov 10, 2017 at 12:39 PM, Jon Turney <jon.tur...@dronecode.org.uk> wrote: On 10/11/2017 15:42, Nicolai Hähnle wrote: On 10.11.2017 14:00, Jon Turney wrote: On 09/11/2017 21:41, Nicolai Hähnle

[Mesa-dev] [PATCH] meson: Don't define HAVE_PTHREAD only on linux

s just means we can't build at all. When we are building for Windows, I'm not sure if dependency('threads') would ever find anything, or defining HAVE_PTHREAD has any effect, but avoid defining it there, just in case. Signed-off-by: Jon Turney <jon.tur...@dronecode.org.uk> --- meson.build |

Re: [Mesa-dev] [PATCH] meson: if dep_dl is an empty list, it's not a dependency object

r uses of [] for a dependency. Quoting Jon Turney (2017-11-13 02:28:27) It's ok to use an empty list for dependencies:, but it's not ok to try to use the found() method of it. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/m

[Mesa-dev] [PATCH] meson: if dep_dl is an empty list, it's not a dependency object

It's ok to use an empty list for dependencies:, but it's not ok to try to use the found() method of it. See also https://github.com/mesonbuild/meson/issues/2324 Signed-off-by: Jon Turney <jon.tur...@dronecode.org.uk> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

On 10/11/2017 15:42, Nicolai Hähnle wrote: On 10.11.2017 14:00, Jon Turney wrote: On 09/11/2017 21:41, Nicolai Hähnle wrote: Sorry for the mess. I'm going to suggest that the fallback declaration of timespec_get() also needs to be provided for POSIX systems which don't have

[Mesa-dev] [PATCH] glx/windows: Fix building libwindowsdri when libX11 headers are installed in a non-standard location

Signed-off-by: Jon Turney <jon.tur...@dronecode.org.uk> --- src/glx/windows/Makefile.am | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glx/windows/Makefile.am b/src/glx/windows/Makefile.am index f84288b935c..f4f8e9664d7 100644 --- a/src/glx/windows/Makefile.am +++ b/src/glx/w

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

to this series. Patch attached. From e04c7cfa3a3a560476d361a828070f7785da8bf0 Mon Sep 17 00:00:00 2001 From: Jon Turney <jon.tur...@dronecode.org.uk> Date: Fri, 10 Nov 2017 12:22:25 + Subject: [PATCH] Also provide timespec_get fallback if a POSIX platform doesn't have it ... not just on W

Re: [Mesa-dev] [PATCH v2 01/26] util: move os_time.[ch] to src/util

sa-mesa/builds/5790) Patch attached. From a186f46272c9677f9c33764cbd9d8dc9d442b473 Mon Sep 17 00:00:00 2001 From: Jon Turney <jon.tur...@dronecode.org.uk> Date: Fri, 10 Nov 2017 11:41:13 + Subject: [PATCH] util: include unistd.h, which may be required for usleep prototype MIME-Version: 1

Re: [Mesa-dev] [PATCH mesa 1/6] glx: use ARRAY_SIZE macro

onMap); i++) { if (strstr(wgl_extensions, extensionMap[i].wglext)) { __glXEnableDirectExtension(>base, extensionMap[i].glxext); InfoMessageF("enabled %s\n", extensionMap[i].glxext); Reviewed-by: Jon Turney <jon.tur...@dronecode.org.uk> ___

Re: [Mesa-dev] [PATCH 13/16] st/dri: implement v2 of DRI_ConfigOptions

built if HAVE_LIBDRM is defined. I guess something like the attached is needed? From b9286109b7037af043ba5d6ebb37f620f530e578 Mon Sep 17 00:00:00 2001 From: Jon Turney <jon.tur...@dronecode.org.uk> Date: Thu, 17 Aug 2017 22:10:52 +0100 Subject: [PATCH] Fix build when HAVE_LIBDRM isn't def

Re: [Mesa-dev] [PATCH 1/2] configure.ac: require pthread-stubs only where available

On 02/03/2017 19:02, Emil Velikov wrote: From: Emil Velikov The project is a thing only for BSD platforms. Or in other words - for any other platforms building/installing pthread-stubs results only in a pthread-stub.pc file. And even where it provides a DSO,

Re: [Mesa-dev] [PATCH] glx/windows: Add wgl.h to the sources list

On 02/11/2016 11:13, Andreas Boll wrote: Otherwise it won't be picked in the tarball and the build will fail. Thanks, my bad. Reviewed-by: Jon Turney <jon.tur...@dronecode.org.uk> Fixes: 533b3530c12 ("direct-to-native-GL for GLX clients on Cygwin ("Windows-DRI")&q

[Mesa-dev] [PATCH] direct-to-native-GL for GLX clients on Cygwin ("Windows-DRI")

. The server is queried for a native handle for the drawable (which is of a different type for windows, pixmaps and pbuffers), which is used to augment __GLXDRIdrawable. Various GLX extensions are enabled depending on if the equivalent WGL extension is available. Signed-off-by: Jon Turney <jon.

Re: [Mesa-dev] [PATCH 2/6] ddebug: record and dump apitrace call numbers

On 05/07/2016 11:17, Marek Olšák wrote: On Tue, Jul 5, 2016 at 12:13 PM, Jon Turney wrote: On 01/07/2016 00:21, Marek Olšák wrote: [...] This adds a use of alloca(), without a corresponding #include This fails to build, for me: In file included from dd_pipe.h:34:0, from

Re: [Mesa-dev] [PATCH 2/6] ddebug: record and dump apitrace call numbers

oca(len + 1); Perhaps the attached is needed? From 5f606bff8e5ed92a42956c10ee6b2b77360feaf5 Mon Sep 17 00:00:00 2001 From: Jon Turney <jon.tur...@dronecode.org.uk> Date: Tue, 5 Jul 2016 10:40:05 +0100 Subject: [PATCH] Add alloca.h include to fix compilation on Cygwin Fix compilation

[Mesa-dev] [PATCH 2/4] Use correct names for dlopen()ed files on Cygwin

From: Yaakov Selkowitz <yselk...@redhat.com> Signed-off-by: Yaakov Selkowitz <yselk...@redhat.com> Reviewed-by: Jon Turney <jon.tur...@dronecode.org.uk> --- src/egl/drivers/dri2/egl_dri2.c| 2 ++ src/gallium/auxiliary/util/u_format_s3tc.c | 2 ++ sr

[Mesa-dev] [PATCH 1/4] configure: Define _GNU_SOURCE for Cygwin as well

y mesa in places) Signed-off-by: Yaakov Selkowitz <yselk...@redhat.com> Reviewed-by: Jon Turney <jon.tur...@dronecode.org.uk> --- configure.ac | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 33d1fef..4967c56 100644 --- a/configure.ac

[Mesa-dev] [PATCH 3/4] configure: Don't require pthread-stubs on Cygwin

Commit 1f4869a2 unconditionally requires pthread-stubs. Unfortunately, the cleverness that pthread-stubs is doesn't work with PE/COFF, and historically Cygwin doesn't have a pthread-stubs.pc. Don't require pthread-stubs on Cygwin. Signed-off-by: Jon Turney <jon.tur...@dronecode.org

[Mesa-dev] [PATCH 4/4] Disable use of weak in threads_posix.h on Cygwin

Weak doesn't work the same on PE/COFF as on ELF, they are only weak references. Specifically, since nothing else pulls in the object which contains pthread_mutexattr_init() (and coming from the C library, that is the only thing that object contains), means that it ends up as 0 Signed-off-by: Jon

[Mesa-dev] [PATCH 0/4] Various Cygwin fixes

Jon Turney (2): configure: Don't require pthread-stubs on Cygwin Disable use of weak in threads_posix.h on Cygwin Yaakov Selkowitz (2): configure: Define _GNU_SOURCE for Cygwin as well Use correct names for dlopen()ed files on Cygwin configure.ac | 23

Re: [Mesa-dev] [PATCH 00/11] Generated GLX dispatch updates

On 24/03/2016 18:09, Adam Jackson wrote: This long-overdue series synchronizes the GLX dispatch scripts with the state of the world in xserver. We no longer use the CALL_* pattern instead emitting gl* calls directly (or thunking through GetProcAddress if needed). We also use overflow-paranoid

Re: [Mesa-dev] [PATCH 1/4] glcpp: Implicitly resolve version after the first non-space/hash token.

On 10/03/2016 19:26, Kenneth Graunke wrote: On Wednesday, March 9, 2016 3:18:50 PM PST Jon Turney wrote: On 05/03/2016 03:33, Kenneth Graunke wrote: We resolved the implicit version directive when processing control lines, such as #ifdef, to ensure any built-in macros exist. However, we

Re: [Mesa-dev] [PATCH 1/4] glcpp: Implicitly resolve version after the first non-space/hash token.

On 05/03/2016 03:33, Kenneth Graunke wrote: We resolved the implicit version directive when processing control lines, such as #ifdef, to ensure any built-in macros exist. However, we failed to resolve it when handling ordinary text. [...] diff --git

  1   2   3   >