Re: [Mesa-dev] [PATCH] mesa/main: remove unused strndup.h include

Reviewed-by: Juha-Pekka Heikkila :) /Juha-Pekka 22. maaliskuuta 2017 18.58.13 GMT+02:00 Emil Velikov kirjoitti: >From: Emil Velikov > >No longer needed as of commit ac257f1070a ("glsl: calculate

Re: [Mesa-dev] [PATCH 0/2] Simple Klocwork patches

Hi Iago, I know there are lot of places where there is malloc unchecked still -- and then there is ralloc which is a story of its own. Reason why I think checking these would be remotely useful in windows only (or other way around, not under linux kernel) is on Windows one can get the null

Re: [Mesa-dev] [PATCH 13/13] mesa/main: Verify context creation on progress

perjantai 8. toukokuuta 2015 Ian Romanick i...@freedesktop.org kirjoitti: On 05/07/2015 05:21 AM, Pohjolainen, Topi wrote: On Tue, May 05, 2015 at 02:25:29PM +0300, Juha-Pekka Heikkila wrote: Stop context creation if something failed. If something errored during context creation we'd

Re: [Mesa-dev] [PATCH 0/3] Pixman for Mesa

On Wed, Sep 3, 2014 at 7:31 PM, Brian Paul bri...@vmware.com wrote: On 08/28/2014 06:51 AM, Juha-Pekka Heikkila wrote: Here is new version of my patch set for using Pixman in Mesa for texture format conversions, mostly complete rewrite after recent changes in src/mesa/main/texstore.c. This

Re: [Mesa-dev] [PATCH 1/5] glsl: Set ir_instruction::ir_type in the base class constructor

this set 1..5 are Reviewed-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com On Sun, Jun 1, 2014 at 10:58 PM, Matt Turner matts...@gmail.com wrote: From: Ian Romanick ian.d.roman...@intel.com This has the added perk that if you forget to set ir_type in the constructor of a new subclass

Re: [Mesa-dev] [PATCH] glcpp: link with tests/common.c

Reviewed-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com On Fri, May 30, 2014 at 7:47 AM, Tapani Pälli tapani.pa...@intel.com wrote: So that prog_hash_table can use _mesa_error_no_memory function. Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/glsl/Makefile.am | 1 + 1

Re: [Mesa-dev] [PATCH] scons: add common.c as part of glcpp build

Reviewed-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com On Fri, May 30, 2014 at 10:11 AM, Tapani Pälli tapani.pa...@intel.com wrote: to have _mesa_error_no_memory function available Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79440 Signed-off-by: Tapani Pälli

Re: [Mesa-dev] [PATCH 04/23] i965/fs+blorp: Remove left over dump_file arguments.

Reviewed-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com On Mon, May 19, 2014 at 9:55 PM, Matt Turner matts...@gmail.com wrote: Were used by the blorp unit test programs. --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp| 20

Re: [Mesa-dev] [PATCH 06/23] i965/fs: Make patch_discard_jumps_to_fb_writes return bool.

Reviewed-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com On Mon, May 19, 2014 at 9:55 PM, Matt Turner matts...@gmail.com wrote: ... to tell us whether it emitted any code. Will be used to determine whether we need to skip an annotation for it. --- src/mesa/drivers/dri/i965/brw_fs.h

Re: [Mesa-dev] [PATCH 07/23] i965/fs: Print disassembly after compaction.

On Mon, May 19, 2014 at 9:55 PM, Matt Turner matts...@gmail.com wrote: --- src/mesa/drivers/dri/i965/brw_fs.h | 4 +- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 156 - 2 files changed, 77 insertions(+), 83 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 08/23] i965/vec4: Print disassembly after compaction.

On Mon, May 19, 2014 at 9:55 PM, Matt Turner matts...@gmail.com wrote: --- src/mesa/drivers/dri/i965/brw_vec4.h | 4 +- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 109 +-- 2 files changed, 66 insertions(+), 47 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 0/2] i965: Simulate MAD opcode with gen6

On Tue, May 6, 2014 at 7:32 PM, Eric Anholt e...@anholt.net wrote: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com writes: These patches allow MAD opcode to be used with pre gen6 hardware. Instead of failing on emitting MAD there will be emitted MUL and ADD to simulate MAD. I tried this

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Simulate MAD opcode with gen6

On Tue, May 6, 2014 at 7:37 PM, Matt Turner matts...@gmail.com wrote: On Tue, May 6, 2014 at 3:53 AM, Juha-Pekka Heikkila juhapekka.heikk...@gmail.com wrote: Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 15 ++-

Re: [Mesa-dev] [PATCH 1/5] i965: Add writes_accumulator flag

it or is there some more convenient way? On Thu, Apr 10, 2014 at 3:48 PM, Juha-Pekka Heikkilä juhapekka.heikk...@gmail.com wrote: Hi Matt, the changed set looks good to me, I did side by side comparison on what had changed but did not try to run it today. I realized immediately when seeing your comment

Re: [Mesa-dev] [PATCH 1/5] i965: Add writes_accumulator flag

Hi Matt, the changed set looks good to me, I did side by side comparison on what had changed but did not try to run it today. I realized immediately when seeing your comment I had not understood to consider the WAR vs. RAW comments in the scheduler. I was thinking when I made the latest set the

Re: [Mesa-dev] [PATCH 3/3] i965: Add writes_accumulator flag

On Thu, Apr 10, 2014 at 1:18 AM, Kenneth Graunke kenn...@whitecape.org wrote: On 04/09/2014 01:47 PM, Matt Turner wrote: From: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com Our hardware has an accumulator register, which can be used to store intermediate results across multiple

Re: [Mesa-dev] [PATCH 00/12] Again Klocwork patches

Hmm... Wonder where my patches 9..12 vanished. They show in git send-email as Result: 250 ok: Message ### accepted. If they don't magically show up here I will resend entire set tomorrow from better connection. /Juha-Pekka On Mon, Apr 7, 2014 at 10:48 PM, Juha-Pekka Heikkila

Re: [Mesa-dev] [PATCH 00/12] Again Klocwork patches

On Mon, Apr 7, 2014 at 11:21 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 07/04/14 21:06, Juha-Pekka Heikkilä wrote: Hmm... Wonder where my patches 9..12 vanished. They show in git send-email as Result: 250 ok: Message ### accepted. If they don't magically show up here I will resend

Re: [Mesa-dev] [PATCH 00/14] Klocwork patches

On Tue, Mar 25, 2014 at 7:46 PM, Matt Turner matts...@gmail.com wrote: On Tue, Mar 25, 2014 at 5:40 AM, Juha-Pekka Heikkila juhapekka.heikk...@gmail.com wrote: Again fixed my Klocwork set. I reworked Ian's patch because my set depend on it and Ian's patch seem to have vanished in the void. It

Re: [Mesa-dev] [RFC PATCH 1/5] i965: Add writes_accumulator flag

I think I would need some hints here, I don't know how to test my changes now properly. On Sat, Mar 22, 2014 at 8:26 AM, Matt Turner matts...@gmail.com wrote: On Fri, Mar 21, 2014 at 11:17 PM, Matt Turner matts...@gmail.com wrote: On Fri, Mar 21, 2014 at 7:33 AM, Juha-Pekka Heikkila

Re: [Mesa-dev] [PATCH] mesa: Add _mesa_error_no_memory for logging out-of-memory messages

=\ libglcpp.la \ -lm I did not see anything that would have changed to affect this from my earlier rebases thus I am puzzled how make check did work earlier for me. :/ /Juha-Pekka On Tue, Mar 4, 2014 at 4:04 PM, Juha-Pekka

Re: [Mesa-dev] [PATCH] mesa: Add _mesa_error_no_memory for logging out-of-memory messages

On Tue, Mar 4, 2014 at 3:41 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com This can be called from locations that don't have a context pointer handy. This patch also adds enough infrastructure so that the unit tests for the GLSL compiler and the

Re: [Mesa-dev] [PATCH 00/10] Klocwork related pathes

On Mon, Feb 17, 2014 at 11:03 PM, Ian Romanick i...@freedesktop.org wrote: On 02/17/2014 08:21 AM, Juha-Pekka Heikkila wrote: Resend of the earlier glx patches with the issue pointed out by Petri fixed. Patch number five is a bit special. hash_table_insert() and hash_table_replace() don't

Re: [Mesa-dev] [PATCH 5/9] glsl: Fix memcpy size in ir_constant

On Wed, Feb 19, 2014 at 4:35 AM, Ian Romanick i...@freedesktop.org wrote: On 02/09/2014 01:50 AM, Juha-Pekka Heikkilä wrote: The place which cause Klocwork to highlight this is at src/mesa/main/ff_fragment_shader.cpp around line 897 where it says: ... float const_data[4

Re: [Mesa-dev] [PATCH 04/10] egl: Unhide functionality in _eglInitSync()

On Tue, Feb 18, 2014 at 9:40 AM, Chia-I Wu olva...@gmail.com wrote: On Tue, Feb 18, 2014 at 12:21 AM, Juha-Pekka Heikkila juhapekka.heikk...@gmail.com wrote: _eglInitResource() was used to memset entire _EGLSync by writing more than size of pointed target. This does work as long as Resource

Re: [Mesa-dev] [PATCH 3/3] glx: add missing null check in SendMakeCurrentRequest

Ah, you're correct. I'll fix that. /Juha-Pekka On Tue, Feb 11, 2014 at 4:18 PM, Petri Latvala petri.latv...@intel.com wrote: On 02/11/2014 04:07 PM, Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/indirect_glx.c | 2 +- 1 file

Re: [Mesa-dev] [PATCH 5/9] glsl: Fix memcpy size in ir_constant

The place which cause Klocwork to highlight this is at src/mesa/main/ff_fragment_shader.cpp around line 897 where it says: ... float const_data[4] = { float(1 rgb_shift), float(1 rgb_shift), float(1 rgb_shift), float(1 alpha_shift) }; shift =

Re: [Mesa-dev] [PATCH] glsl: Assert buildin uniform variables

On Thu, Jan 16, 2014 at 8:48 PM, Matt Turner matts...@gmail.com wrote: On Thu, Jan 16, 2014 at 2:59 AM, Juha-Pekka Heikkila juhapekka.heikk...@gmail.com wrote: Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glsl/builtin_variables.cpp | 24 1

Re: [Mesa-dev] [PATCH 1/5] Mesa: Change save_attrib_data() to return boolean

On Thu, Dec 12, 2013 at 3:14 AM, Brian Paul bri...@vmware.com wrote: On 12/11/2013 02:05 AM, Juha-Pekka Heikkila wrote: Change save_attrib_data() to return true/false depending on success. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com I'd like to reconsider these changes

Re: [Mesa-dev] [PATCH 1/3] glx: Check malloc return value before accessing memory in glx/clientattrib.c

On Tue, Dec 3, 2013 at 6:39 PM, Brian Paul bri...@vmware.com wrote: On 12/02/2013 02:39 AM, Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/glx/clientattrib.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 3/3] mesa: Verify memory allocations success in _mesa_PushAttrib

On Tue, Dec 3, 2013 at 6:51 PM, Ian Romanick i...@freedesktop.org wrote: On 12/02/2013 01:39 AM, Juha-Pekka Heikkila wrote: Check if any of the callocs fail and report it with _mesa_error if needed. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c

Re: [Mesa-dev] [PATCH 2/3] mesa: Verify memory allocations success in _mesa_PushClientAttrib

On Tue, Dec 3, 2013 at 6:42 PM, Brian Paul bri...@vmware.com wrote: On 12/02/2013 02:39 AM, Juha-Pekka Heikkila wrote: Check if any of the callocs fail and report it with _mesa_error if needed. Signed-off-by: Juha-Pekka Heikkila juhapekka.heikk...@gmail.com --- src/mesa/main/attrib.c |

Re: [Mesa-dev] [PATCH] glx: Extra gc null check for glXMakeCurrent

On Mon, Nov 25, 2013 at 7:12 PM, Ian Romanick i...@freedesktop.org wrote: On 11/25/2013 07:23 AM, Juha-Pekka Heikkila wrote: Extra null check before accessing user given context pointer. oldGC can never be NULL. If there is no current context, it will point to dummyContext. Ah, ok. I was