Reviewed-by: Lionel Landwerlin
On 29/08/2018 16:07, Jason Ekstrand wrote:
Fixes: 8c048af5890d4 "anv: Copy the appliation info into the instance"
---
src/intel/vulkan/anv_device.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/intel/vulkan/anv_device.c b/src/in
On 27/08/2018 23:48, Jason Ekstrand wrote:
On Mon, Aug 27, 2018 at 12:50 PM Lionel Landwerlin
mailto:lionel.g.landwer...@intel.com>>
wrote:
On 23/08/2018 16:13, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_device.c | 9 +
> 1 file change
AM Lionel Landwerlin
mailto:lionel.g.landwer...@intel.com>>
wrote:
Newer blit tests are enabling depth blits. We currently don't
support it but can do by iterating over the aspects masks (copy some
logic from the CopyImage function).
Signed-off-by: Lionel Landwerlin mailto:l
Newer blit tests are enabling depth blits. We currently don't
support it but can do by iterating over the aspects masks (copy some
logic from the CopyImage function).
Signed-off-by: Lionel Landwerlin
Fixes: 9f44745eca0e41 ("anv: Use blorp to implement VkBlitImage")
---
src/in
Thanks Andres,
Please see my response to Re: [Mesa-dev] [PATCH] intel: decoder: unify
MI_BB_START field naming
On 27/08/2018 22:20, Andres Gomez wrote:
Lionel, should we also include this in the stable queues ?
On Sat, 2018-08-25 at 18:23 +0100, Lionel Landwerlin wrote:
Gen7.5 has
Yes, I think so. You asked on another commit too, both are related and
this depends on other commits from Jason.
Here is a list in order of cherry picking :
commit f430a37fa75f534c3a114b0ec546fa14f05f5da1
Author: Lionel Landwerlin
Date: Tue Aug 14 11:22:12 2018 +0100
intel: decoder
On 23/08/2018 16:13, Jason Ekstrand wrote:
---
src/intel/vulkan/anv_device.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index 0357fc7c0ea..5a63592f7ca 100644
--- a/src/intel/vulkan/anv_device.c
+++
I don't know how you find this stuff...
Reviewed-by: Lionel Landwerlin
On 25/08/2018 23:17, Jason Ekstrand wrote:
Cc: mesa-sta...@lists.freedesktop.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104809
---
src/intel/vulkan/genX_pipeline.c | 29 -
1
Reviewed-by: Lionel Landwerlin
On 25/08/2018 23:34, Jason Ekstrand wrote:
---
src/intel/common/gen_batch_decoder.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/intel/common/gen_batch_decoder.c
b/src/intel/common/gen_batch_decoder.c
index 6884a999401
Gen7.5 has a BLEND_STATE of size 0 which includes a variable length
group. We did not deal with that very well, leading to an endless
loop.
Signed-off-by: Lionel Landwerlin
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107544
---
src/intel/common/gen_decoder.c | 12
1 file
]
fprintf(stderr, msg);
^~~
This patch fixes this trivially by introducing a catch-all "%s" format
argument.
Fixes: 4616639b49b ("intel: tools: split aub parsing from aubinator")
Cc: Lionel Landwerlin
Signed-off-by: Kai Wasserbäch
Reviewed-by: Lionel Lan
The whole series is :
Reviewed-by: Lionel Landwerlin
Thanks for the great cleanup!
-
Lionel
On 24/08/2018 22:40, Jason Ekstrand wrote:
First of all, setting iter->name in advance_field is unnecessary because
it gets set by gen_decode_field which gets called immediately af
On 24/08/2018 12:09, Samuel Iglesias Gonsálvez wrote:
VkPhysicalDeviceProtectedMemoryProperties structure is new on Vulkan 1.1.
Fixes Vulkan CTS CL#2849.
Signed-off-by: Samuel Iglesias Gonsálvez
Reviewed-by: Lionel Landwerlin
---
src/intel/vulkan/anv_device.c | 7 +++
1 file
have a natural size"' failed.
Since this particular variable isn't used and it can be eliminated by
removing unused local variables in the optimization pass. This makes
sense also for valid local variables.
Signed-off-by: Lionel Landwerlin
---
src/intel/compiler/brw_nir.c | 1 +
1 file
On 23/08/2018 13:50, Jason Ekstrand wrote:
On Thu, Aug 23, 2018 at 7:04 AM Lionel Landwerlin
mailto:lionel.g.landwer...@intel.com>>
wrote:
We're hitting an assert in gfxbench because one of the local
variable is a sampler :
Of course we were That's because gfxbench does i
Signed-off-by: Lionel Landwerlin
Fixes: 1235850522cd5e ("nir: Add a large constants optimization pass")
---
src/compiler/nir/nir_opt_large_constants.c | 10 +-
src/compiler/nir_types.cpp | 4 +++-
2 files changed, 12 insertions(+), 2 deletions(-)
diff --gi
On 23/08/2018 09:07, Kenneth Graunke wrote:
This lets us example SAMPLER_STATE's LOD Bias field, among other things.
Thanks Ken!
Reviewed-by: Lionel Landwerlin
---
src/intel/common/gen_decoder.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/intel
reduction when sampler
reduction mode is not specified via this extension (Lionel).
Looks good to me :
Reviewed-by: Lionel Landwerlin
---
src/intel/vulkan/anv_device.c | 8
src/intel/vulkan/anv_extensions.py | 1 +
src/intel/vulkan/anv_formats.c | 6 ++
src/intel
Reviewed-by: Lionel Landwerlin
On 21/08/2018 18:38, Rafael Antognolli wrote:
It looks like we can't rely on the simulator to always translate virtual
addresses to physical ones correctly. So let's use physical everywhere.
Since our current GGTT maps virtual to physical addresses in a 1:1 way
Reviewed-by: Lionel Landwerlin
On 21/08/2018 18:38, Rafael Antognolli wrote:
Hopefully it's a little more descriptive, and more accurate.
Cc: Lionel Landwerlin
---
src/intel/tools/aub_write.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/tools/aub_write.c b
Hey Andres,
Yes, it should. Sorry I missed the Cc stable in the patch.
Thanks for paying attention :)
-
Lionel
On 20/08/2018 23:17, Andres Gomez wrote:
Danylo, should we also include this in the stable queues ?
On Mon, 2018-06-18 at 15:50 +0300, Danylo Piliaiev wrote:
We use
igned-off-by: Andrii Simiklit
Reviewed-by: Lionel Landwerlin
Somebody should take a look at the other patches I sent out ;)
Thanks!
-
Lionel
---
src/intel/common/gen_decoder.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/intel/common/gen_decoder.c b/src/intel/
, not depth-only formats, 2) fix
a wrong indention (Jason).
v3: fix a few nits (Lionel).
v4: fix failures in CI: disable sampler reduction when sampler
reduction mode is not specified via this extension (Lionel).
Looks good to me :
Reviewed-by: Lionel Landwerlin
---
src/intel/vulkan
pass for ycbcr textures"
Reviewed-by: Timothy Arceri
Reviewed-by: Lionel Landwerlin
(cherry picked from commit 320dacb0a051cd1736e0976f70467b68281edfbf)
---
src/intel/vulkan/anv_nir_lower_ycbcr_textures.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/in
Reviewed-by: Lionel Landwerlin
Do you need me to push it?
Thanks,
-
Lionel
On 08/08/18 16:03, Danylo Piliaiev wrote:
Hi,
Since the exact value is not important for users, Roland offered
compelling explanation
and the value is also 8 on Windows - could the patch be reviewed/pushed
On 17/08/18 17:57, Yunchao He wrote:
This extension can be supported on SKL+. With this patch,
all corresponding tests (6K+) in CTS can pass. No test fails.
I verified CTS with the command below:
deqp-vk --deqp-case=dEQP-VK.pipeline.sampler.view_type.*reduce*
v2: 1) support all depth formats,
On 20/08/18 09:16, Kai Wasserbäch wrote:
Hey Lionel,
Lionel Landwerlin wrote on 19.08.2018 11:05:
Patches 6, 7, 10 & 11 are :
Reviewed-by: Lionel Landwerlin
thanks! Feel free to push, I don't have commit access (see cover letter).
Will do.
There are 2 existing series touching the
h
that case.
I'm not sure whether there is such case in the genxml files, but if it
happens we should probably look into it.
Cheers,
-
Lionel
Regards,
Andrii.
On Tue, Aug 14, 2018 at 7:08 PM, Lionel Landwerlin
mailto:lionel.g.landwer...@intel.com>>
wrote:
On 14/08/18 16:16, Rafael Antognol
Hi Kai,
Patches 6, 7, 10 & 11 are :
Reviewed-by: Lionel Landwerlin
There are 2 existing series touching the same code, in patches 8, 9 &
12, I think should land before the warnings are fixed.
Thanks,
-
Lionel
On 18/08/18 12:16, Kai Wasserbäch wrote:
Hey,
thanks to Bas and
Reviewed-by: Lionel Landwerlin
On 08/08/18 09:12, Jason Ekstrand wrote:
---
src/intel/vulkan/anv_pipeline.c | 37 +++--
1 file changed, 21 insertions(+), 16 deletions(-)
diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c
index
layout. Third, we switch to using
designated initializers.
Nice cleanup :)
Reviewed-by: Lionel Landwerlin
---
src/intel/vulkan/anv_descriptor_set.c | 13
.../vulkan/anv_nir_apply_pipeline_layout.c| 64 ++-
src/intel/vulkan/anv_private.h| 3
: add nir lowering pass for ycbcr textures"
Thanks,
Reviewed-by: Lionel Landwerlin
---
src/intel/vulkan/anv_nir_lower_ycbcr_textures.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/intel/vulkan/anv_nir_lower_ycbcr_textures.c
b/src/in
Hey Phi,
I can confirm this extension isn't implemented in Mesa.
I don't why it wasn't.
Talking briefly with Jason, it seems that mapping texture makes less
sense on Skylake and above generations.
There we maintain compressed version of the textures in memory to
further reduce memory
Reviewed-by: Lionel Landwerlin
On 16/08/18 15:49, Eric Engestrom wrote:
Signed-off-by: Eric Engestrom
---
src/mesa/drivers/dri/i965/brw_bufmgr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c
b/src/mesa/drivers/dri/i965/brw_bufmgr.c
index
Reviewed-by: Lionel Landwerlin
On 16/08/18 15:48, Eric Engestrom wrote:
`device` is used 2 lines below, even visible in the diff context printed.
Signed-off-by: Eric Engestrom
---
src/intel/vulkan/anv_device.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/intel/vulkan
Reviewed-by: Lionel Landwerlin
On 16/08/18 15:46, Eric Engestrom wrote:
Signed-off-by: Eric Engestrom
---
src/intel/vulkan/anv_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index
On 16/08/18 15:38, Eric Engestrom wrote:
Signed-off-by: Eric Engestrom
Reviewed-by: Lionel Landwerlin
---
src/intel/common/gen_batch_decoder.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/intel/common/gen_batch_decoder.c
b/src/intel/common
Both patches pushed to master.
Thanks!
-
Lionel
On 15/08/18 16:03, Lionel Landwerlin wrote:
On 15/08/18 12:23, Sergii Romantsov wrote:
Kernel (for ppgtt) requires memory address to be
aligned to page size (4096).
-v2: added marking that also fixes initial commit 01058a552294.
-v3: numbers
Hey Yunchao,
This patch seems to fail a number of tests on CI like
dEQP-VK.glsl.texture_gather.offset_dynamic.min_required_offset.2d.depth32f.size_npot.compare_greater.clamp_to_edge_repeat
They pass if I set the default to :
unsigned sampler_reduction_mode = COMPARISON;
Maybe we don't want
Hey there,
Just a few nits below.
Thanks!
-
Lionel
On 15/08/18 18:42, Yunchao He wrote:
This extension can be supported on SKL+. With this patch,
all corresponding tests (6K+) in CTS can pass. No test fails.
I verified CTS with the command below:
deqp-vk
allocator infrastructure to
brw_bufmgr.)
Signed-off-by: Sergii Romantsov
CI seems happy this time :
Reviewed-by: Lionel Landwerlin
---
src/mesa/drivers/dri/i965/brw_bufmgr.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c
b
On 15/08/18 12:23, Sergii Romantsov wrote:
Kernel (for ppgtt) requires memory address to be
aligned to page size (4096).
-v2: added marking that also fixes initial commit 01058a552294.
-v3: numbers replaced by PAGE_SIZE; buffer-object size is aligned
instead of alignment of offsets (Chris
Hey Erik,
Out of curiosity, what app/test managed to run into this assert?
We could have some test added :)
Thanks,
-
Lionel
On 08/08/18 09:34, Lionel Landwerlin wrote:
On 07/08/18 20:31, Erik Faye-Lund wrote:
If called with an empty size, brw_emit_buffer_surface_state asserts.
We already
On 14/08/18 16:16, Rafael Antognolli wrote:
On Tue, Aug 14, 2018 at 03:36:18PM +0100, Lionel Landwerlin wrote:
On 14/08/18 12:55, asimiklit.work wrote:
Hi Lionel,
Hi Andrii,
Again sorry, I don't think this is the right fix.
I'm sending another patch to fix the parsing
shouldn't even get to use the iterator if it's an unknown instruction.
The decoder should just advance dword by dword until it finds something
that makes sense again.
If we run into that problem, I think we should fix the caller.
Cheers,
-
Lionel
Regards,
Andrii.
On 2018-08-14 1:26 PM, Li
The batch decoder looks for a field with a particular name to decide
whether an MI_BB_START leads into a second batch buffer level. Because
the names are different between Gen7.5/8 and the newer generation we
fail that test and keep on reading (invalid) instructions.
Signed-off-by: Lionel
Hi Andrii,
Again sorry, I don't think this is the right fix.
I'm sending another patch to fix the parsing of MI_BATCH_BUFFER_START
which seems to be the actual issue.
Thanks for working on this,
-
Lionel
On 14/08/18 10:04, asimiklit.w...@gmail.com wrote:
From: Andrii Simiklit
The
Gen7.5 has a BLEND_STATE of size 0 which includes a variable length
group. We did not deal with that very well, leading to an endless
loop.
Signed-off-by: Lionel Landwerlin
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107544
---
src/intel/common/gen_decoder.c | 28
The previous implementation seemed to imply that
3DSTATE_BLEND_STATE_POINTERS had a pointer to an array of BLEND_STATE.
This is true on Gen7.5 but not on Gen8+. The actual array is made up
of BLEND_STATE_ENTRY elements following BLEND_STATE (which is empty on
Gen7.5).
Signed-off-by: Lionel
When associating a template GLX config to a DRI one (filled out by the
driver), we need to update the GLX_DONT_CARE fields (like yInverted
for example). Otherwise those fields will report GLX_DONT_CARE to the
application which is not what the driver is actually doing.
Signed-off-by: Lionel
Andrey also opened a bug about this issue :
https://bugs.freedesktop.org/show_bug.cgi?id=107544
It feels like it should be fixed on master though. get_length()
shouldn't return -1 for structs anymore.
We should probably return 1 at end of get_length() so that the decoder
prints out "unknown
Maybe set out_filename = NULL (might not be initialized on Linux by
default, according to manpage).
Either way :
Reviewed-by: Lionel Landwerlin
On 10/08/18 13:21, Eric Engestrom wrote:
Compiler wasn't happy about strncpy() depending on the source's length and not
the target's, but this whole
Reviewed-by: Lionel Landwerlin
On 09/08/18 06:44, Rodrigo Vivi wrote:
One more CFL ID added to spec.
Align with kernel commit d0e062ebb3a4 ("drm/i915/cfl:
Add a new CFL PCI ID.")
Cc: José Roberto de Souza
Cc: Anuj Phogat
Signed-off-by: Rodrigo Vivi
---
include/pci_ids/i965_pci
On 08/08/18 21:55, Rafael Antognolli wrote:
t
@@ -790,6 +892,7 @@ aub_viewer_render_batch(struct aub_viewer_decode_ctx *ctx,
for (unsigned i = 0; i < ARRAY_SIZE(info_decoders); i++) {
if (strcmp(inst_name, info_decoders[i].cmd_name) == 0) {
+ctx->stage =
On 08/08/18 22:09, Rafael Antognolli wrote:
+ /* URB allocation */
+ hovered = _Hovered(mouse_pos, window_hovered, alloc_tl, alloc_br);
+ ImGui::ColorConvertHSVtoRGB((2 * s) * 1.0f / (2 * n_stages),
+ 1.0f, hovered ? 1.0f : 0.8f,
+
On 08/08/18 20:07, Rafael Antognolli wrote:
On Tue, Aug 07, 2018 at 06:35:18PM +0100, Lionel Landwerlin wrote:
When we map a PPGTT buffer into a continous address space of aubinator
to be able to inspect it, we currently add it to the list of BOs to
unmap once we're finished. An optimization we
Reviewed-by: Lionel Landwerlin
On 08/08/18 15:45, Eric Engestrom wrote:
Cc: Jason Ekstrand
Fixes: 5b196f39bddc689742d3 "anv/pipeline: Compile to NIR in compile_graphics"
Signed-off-by: Eric Engestrom
---
src/intel/vulkan/anv_pipeline.c | 4 +++-
1 file changed, 3 insertions(+),
On 08/08/18 12:05, Lionel Landwerlin wrote:
On 08/08/18 00:14, Bas Nieuwenhuizen wrote:
radv was always just mirroring a derived version of the anv
version, sometimes hacked together and sometimes very behind.
As we grow more vulkan drivers this repetition makes even less
sense, so lets merge
Reviewed-by: Lionel Landwerlin
bo_addr doesn't have a warning?
On 08/08/18 15:27, Eric Engestrom wrote:
Cc: Lionel Landwerlin
Signed-off-by: Eric Engestrom
---
src/intel/tools/error2aub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/tools/error2aub.c b
On 08/08/18 00:14, Bas Nieuwenhuizen wrote:
radv was always just mirroring a derived version of the anv
version, sometimes hacked together and sometimes very behind.
As we grow more vulkan drivers this repetition makes even less
sense, so lets merge them. I took the anv generators as the
On 08/08/18 00:42, Rafael Antognolli wrote:
On Tue, Aug 07, 2018 at 06:35:20PM +0100, Lionel Landwerlin wrote:
A graphical user interface version of aubinator.
Allows you to :
- simultaneously look at multiple points in the aub file (using all
the goodness of the existing decoding
On 07/08/18 20:31, Erik Faye-Lund wrote:
If called with an empty size, brw_emit_buffer_surface_state asserts.
We already have a dedicated helper for uploading nothing, so let's use
that instead.
Signed-off-by: Erik Faye-Lund
Looks good to me. Maybe Ken can confirm?
Reviewed-by: Lionel
On 07/08/18 18:35, Lionel Landwerlin wrote:
A graphical user interface version of aubinator.
Allows you to :
- simultaneously look at multiple points in the aub file (using all
the goodness of the existing decoding in aubinator)
- edit an aub file
Signed-off-by: Lionel
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/aubinator_viewer.h | 26
src/intel/tools/aubinator_viewer_decoder.cpp | 150 ---
2 files changed, 153 insertions(+), 23 deletions(-)
diff --git a/src/intel/tools/aubinator_viewer.h
b/src/intel/tools
A graphical user interface version of aubinator.
Allows you to :
- simultaneously look at multiple points in the aub file (using all
the goodness of the existing decoding in aubinator)
- edit an aub file
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/aubinator_viewer.cpp
This is available through a "Show URB" button on the 3DPRIMITIVE
instructions.
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/aubinator_viewer.cpp | 75
src/intel/tools/aubinator_viewer_urb.h | 96 ++
2 files changed, 171
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/meson.build | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/src/intel/tools/meson.build b/src/intel/tools/meson.build
index d749a80afed..258bf7011b3 100644
--- a/src/intel/tools/meson.build
+++ b/src/intel
BOs to
differenciate between GGTT & PPGTT, which allows use to reuse that
list when looking up both address spaces.
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/aub_mem.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/src/intel/tools/aub_mem.c b/src/int
v2: Add helper to make iterators more readable (Rafael)
Fix rev iterator bug (Rafael)
Signed-off-by: Lionel Landwerlin
---
src/util/rb_tree.h | 58 ++
1 file changed, 58 insertions(+)
diff --git a/src/util/rb_tree.h b/src/util/rb_tree.h
index
This will allow the aubinator viewer tool to modify the aub data that
was loaded at a particular gtt address.
Signed-off-by: Lionel Landwerlin
Reviewed-by: Rafael Antognolli
---
src/intel/tools/aub_mem.c | 29 +
src/intel/tools/aub_mem.h | 6 ++
2 files changed
Signed-off-by: Lionel Landwerlin
Reviewed-by: Rafael Antognolli
---
src/intel/tools/aub_mem.c | 391
src/intel/tools/aub_mem.h | 72 +++
src/intel/tools/aubinator.c | 379 +++---
src/intel/tools/meson.build | 2 +-
4
Reviewed-by: Rafael Antognolli
---
src/intel/tools/aub_write.h | 8
1 file changed, 8 insertions(+)
diff --git a/src/intel/tools/aub_write.h b/src/intel/tools/aub_write.h
index b421679b9eb..6a09c1747b9 100644
--- a/src/intel/tools/aub_write.h
+++ b/src/intel/tools/aub_write.h
@@ -31,6
v2: add parsing error callback (Lionel)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Rafael Antognolli (v1)
---
src/intel/tools/aub_read.c | 333
src/intel/tools/aub_read.h | 77 +
src/intel/tools/aubinator.c | 325
at :
https://github.com/djdeath/mesa/tree/wip/djdeath/aubinator_viewer
Cheers,
Lionel Landwerlin (11):
intel: tools: split aub parsing from aubinator
util: rb_tree: add safe iterators
intel: tools: split memory management out of aubinator
intel: tools: aubwrite: wrap function declarations
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107487
Fixes: 4334196ab325c6w ("intel: tools: simplify meson build")
Signed-off-by: Lionel Landwerlin
---
src/intel/meson.build | 4 +++-
src/intel/tools/meson.build | 26 --
2 files changed, 15
Hey Erik,
I don't think this is right, because by not filling out_offset, you're
leaving it at 0 which makes the entry in the binding table point to a
dynamic state base address.
I would emit the null surface instead.
-
Lionel
On 06/08/18 14:27, Erik Faye-Lund wrote:
If called with an
-off-by: Sergii Romantsov
Reviewed-by: Lionel Landwerlin
Thanks!
---
src/mesa/drivers/dri/i965/brw_bufmgr.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c
b/src/mesa/drivers/dri/i965/brw_bufmgr.c
index 09d45e3..8274c2e
On 04/08/18 01:31, Rafael Antognolli wrote:
On Thu, Aug 02, 2018 at 10:39:20AM +0100, Lionel Landwerlin wrote:
Signed-off-by: Lionel Landwerlin
---
src/util/rb_tree.h | 36
1 file changed, 36 insertions(+)
diff --git a/src/util/rb_tree.h b/src/util
: Jason Ekstrand
Cc: Lionel Landwerlin
Cc: Dylan Baker
Signed-off-by: Andres Gomez
Looks like I'll have to update some stuff on my branches.
I was hoping that we could start forgetting about autotools but forgot
about about released tarballs :(
Reviewed-by: Lionel Landwerlin
---
Thi
On 10/07/18 05:59, Jason Ekstrand wrote:
On all other platforms, it's safe to use the usual PTE settings for both
internal and external BOs. On Broadwell, however, we can't get the
right caching behavior for scanout without disabling eLLC and we really
don't want to do this on everything.
In
Signed-off-by: Lionel Landwerlin
---
src/util/rb_tree.h | 36
1 file changed, 36 insertions(+)
diff --git a/src/util/rb_tree.h b/src/util/rb_tree.h
index c77e9255ea2..df1a4197b8a 100644
--- a/src/util/rb_tree.h
+++ b/src/util/rb_tree.h
@@ -243,6 +243,24
Based on https://github.com/ocornut/imgui_club/pull/5
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/imgui/imgui_memory_editor.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/tools/imgui/imgui_memory_editor.h
b/src/intel/tools/imgui/imgui_memory_editor.h
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/aub_mem.c | 391
src/intel/tools/aub_mem.h | 72 +++
src/intel/tools/aubinator.c | 379 +++---
src/intel/tools/meson.build | 2 +-
4 files changed, 491 insertions
---
src/intel/tools/aub_write.h | 8
1 file changed, 8 insertions(+)
diff --git a/src/intel/tools/aub_write.h b/src/intel/tools/aub_write.h
index b421679b9eb..6a09c1747b9 100644
--- a/src/intel/tools/aub_write.h
+++ b/src/intel/tools/aub_write.h
@@ -31,6 +31,10 @@
#include
A graphical user interface version of aubinator.
Allows you to :
- simultaneously look at multiple points in the aub file (using all
the goodness of the existing decoding in aubinator)
- edit an aub file
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/aubinator_viewer.cpp
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/aub_read.c | 307 ++
src/intel/tools/aub_read.h | 75 +
src/intel/tools/aubinator.c | 324 +---
src/intel/tools/meson.build | 2 +-
4 files changed, 426 insertions
This will allow the aubinator viewer tool to modify the aub data that
was loaded at a particular gtt address.
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/aub_mem.c | 29 +
src/intel/tools/aub_mem.h | 6 ++
2 files changed, 35 insertions(+)
diff --git
/aubinator_viewer
Cheers,
Lionel Landwerlin (14):
intel: aubinator: fix read the context/ring
intel: tools: aubwrite: reuse canonical address helper
intel: decoder: remove unused variable
intel: common: add missing stdint include
intel: aubinator: simplify decoding
intel: tools: simplify meson build
---
src/intel/common/gen_gem.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/intel/common/gen_gem.h b/src/intel/common/gen_gem.h
index 7dd9ae6d548..8df2c249e48 100644
--- a/src/intel/common/gen_gem.h
+++ b/src/intel/common/gen_gem.h
@@ -24,6 +24,8 @@
#ifndef GEN_GEM_H
#define
Signed-off-by: Lionel Landwerlin
---
src/intel/common/gen_decoder.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/intel/common/gen_decoder.h b/src/intel/common/gen_decoder.h
index d8add4ccdb7..a80c50b6647 100644
--- a/src/intel/common/gen_decoder.h
+++ b/src/intel/common/gen_decoder.h
Up to now we've been lucky that the buffer returned was always exactly
at the address we requested.
Fixes: 144b40db5411 ("intel: aubinator: drop the 1Tb GTT mapping")
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/aubinator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletion
Remove the if tools condition and just put it through the install:
parameter.
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/meson.build | 96 +++--
1 file changed, 50 insertions(+), 46 deletions(-)
diff --git a/src/intel/tools/meson.build b/src/intel
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/aub_write.h | 19 ++-
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a/src/intel/tools/aub_write.h b/src/intel/tools/aub_write.h
index 2e42e3d4009..b421679b9eb 100644
--- a/src/intel/tools/aub_write.h
+++ b/src
Since we don't support streaming an aub file, we can drop the decoding
status enum.
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/aubinator.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c
On 30/07/18 17:13, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-07-30 17:08:47)
On 30/07/18 16:45, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-07-30 16:28:37)
Gen10+ has an additional bit in MI_BATCH_BUFFER_END to signal the end
of the context image.
Hmm, do you think we
On 30/07/18 16:45, Chris Wilson wrote:
Quoting Lionel Landwerlin (2018-07-30 16:28:37)
Gen10+ has an additional bit in MI_BATCH_BUFFER_END to signal the end
of the context image.
Hmm, do you think we should perhaps include the BBE in the protocontext
we create in the kernel?
-Chris
I can't
Gen10+ has an additional bit in MI_BATCH_BUFFER_END to signal the end
of the context image.
We select the largest size for the context image regardless of the
generation.
Signed-off-by: Lionel Landwerlin
---
src/intel/tools/aub_write.c | 216 +---
src/intel
Hey Sergii,
Sorry for the late answer.
For the sake of clarity, I would split the changes (4096->PAGE_SIZE) and
the actual bug fix into 2 different patches.
I don't have see a problem with the PAGE_SIZE change.
Thanks a lot,
-
Lionel
On 25/07/18 14:24, Sergii Romantsov wrote:
Sorry,
do we
On 25/07/18 20:14, Eric Engestrom wrote:
Signed-off-by: Eric Engestrom
Reviewed-by: Lionel Landwerlin
---
src/intel/vulkan/anv_extensions.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/intel/vulkan/anv_extensions.py
b/src/intel/vulkan/anv_extensions.py
On 25/07/18 20:12, Eric Engestrom wrote:
Signed-off-by: Eric Engestrom
Reviewed-by: Lionel Landwerlin
---
src/intel/vulkan/anv_descriptor_set.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/intel/vulkan/anv_descriptor_set.c
b/src/intel/vulkan/anv_descriptor_set.c
index
401 - 500 of 1911 matches
Mail list logo
