Re: [Mesa-dev] [PATCH] st/dri: decrease input lag by syncing sooner in SwapBuffers

2019-04-27 Thread Marek Olšák
Davy wrote: > On 27/04/2019 21:02, Rob Clark wrote: > > On Sat, Apr 27, 2019 at 9:52 AM Axel Davy wrote: > >> On 27/04/2019 18:13, Rob Clark wrote: > >>> On Thu, Apr 25, 2019 at 7:06 PM Marek Olšák wrote: > >>>> From: Marek Olšák > >>>>

Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

2019-04-27 Thread Marek Olšák
Those are all valid reasons, but I don't wanna expose swrast for AMD's customers. Marek On Sat, Apr 27, 2019, 5:45 AM Mathias Fröhlich wrote: > Hi Marek, > > On Wednesday, 24 April 2019 02:01:42 CEST Marek Olšák wrote: > > Adam, did you notice my original suggestion "If the

[Mesa-dev] [PATCH 3/3] st/mesa: don't flush the front buffer if it's a pbuffer

2019-04-26 Thread Marek Olšák
From: Marek Olšák This is the best guess I can make here. --- src/mesa/state_tracker/st_manager.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c index 5efbd1fa1d2..bee1f6b1366

[Mesa-dev] [PATCH 2/3] mesa: fix pbuffers because internally they are front buffers

2019-04-26 Thread Marek Olšák
From: Marek Olšák This fixes the egl_ext_device_base piglit test, which uses EGL pbuffers. --- src/mesa/main/buffers.c | 56 ++--- 1 file changed, 36 insertions(+), 20 deletions(-) diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c index

[Mesa-dev] [PATCH 1/3] mesa: rework error handling in glDrawBuffers

2019-04-26 Thread Marek Olšák
From: Marek Olšák It's needed by the next pbuffer fix, which changes the behavior of draw_buffer_enum_to_bitmask, so it can't be used to help with error checking. --- src/mesa/main/buffers.c | 53 ++--- 1 file changed, 29 insertions(+), 24 deletions(-) diff

[Mesa-dev] [PATCH 0/3] Pbuffer fixes

2019-04-26 Thread Marek Olšák
Hi, This series fixes pbuffers for EGL as exercised by the egl_ext_device- _base piglit test. It passes piglit, GL-CTS, dEQP, and The Hitchhiker's Guide to the Galaxy, but I didn't test GLX, so things might still break horribly there. Rbs welcome, Thanks, Marek

[Mesa-dev] [PATCH 1/2] radeonsi: use new atomic LLVM helpers

2019-04-26 Thread Marek Olšák
From: Marek Olšák This depends on "ac,ac/nir: use a better sync scope for shared atomics" --- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c b/s

[Mesa-dev] [PATCH 2/2] radeonsi: set sampler state and view functions for compute-only contexts

2019-04-26 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- src/gallium/drivers/radeonsi/si_state.c | 17 ++--- src/gallium/drivers/radeonsi/si_state.h | 2 +- 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src

Re: [Mesa-dev] [PATCH] st/dri: decrease input lag by syncing sooner in SwapBuffers

2019-04-26 Thread Marek Olšák
On Fri, Apr 26, 2019 at 12:56 PM Axel Davy wrote: > On 26/04/2019 10:08, Michel Dänzer wrote: > > On 2019-04-26 4:06 a.m., Marek Olšák wrote: > >> From: Marek Olšák > >> > >> It's done by: > >> - decrease the number of frames in flight by 1

Re: [Mesa-dev] [PATCH] st/dri: decrease input lag by syncing sooner in SwapBuffers

2019-04-26 Thread Marek Olšák
On Fri, Apr 26, 2019 at 4:08 AM Michel Dänzer wrote: > On 2019-04-26 4:06 a.m., Marek Olšák wrote: > > From: Marek Olšák > > > > It's done by: > > - decrease the number of frames in flight by 1 > > - flush before throttling in SwapBuffers > > (instead

[Mesa-dev] [PATCH] st/mesa: fix assertion failure in st_tgsi_lower_yuv

2019-04-25 Thread Marek Olšák
From: Marek Olšák src/mesa/state_tracker/st_tgsi_lower_yuv.c:68: void reg_dst(struct tgsi_full_dst_register *, const struct tgsi_full_dst_register *, unsigned int): assertion "dst->Register.WriteMask" failed Cc: 19.0 --- src/mesa/state_tracker/st_tgsi_low

[Mesa-dev] [PATCH] st/dri: decrease input lag by syncing sooner in SwapBuffers

2019-04-25 Thread Marek Olšák
From: Marek Olšák It's done by: - decrease the number of frames in flight by 1 - flush before throttling in SwapBuffers (instead of wait-then-flush, do flush-then-wait) The improvement is apparent with Unigine Heaven. Previously: draw frame 2 wait frame 0 flush frame 2

[Mesa-dev] [PATCH] radeonsi: don't ignore PIPE_FLUSH_ASYNC

2019-04-25 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_fence.c b/src/gallium/drivers/radeonsi/si_fence.c index 3d23597413c..ffda98d2834 100644 --- a/src/gallium/drivers/radeonsi

Re: [Mesa-dev] [PATCH 2/3] radeonsi/gfx9: rework the gfx9 scissor bug workaround (v2)

2019-04-25 Thread Marek Olšák
; assumes your si compute-queue only patches, which aren't present in 19.0. > I've > made a small change to get it compiling, but I'm sure it's not the right > fix, so > if you could take a look at the staging/19.0 branch and let me know what > you'd > like to do I'd appreciate it. >

Re: [Mesa-dev] [PATCH 8/8] radeonsi: add radeonsi_sync_compile option

2019-04-24 Thread Marek Olšák
For patches 2 - 8: Reviewed-by: Marek Olšák Marek On Wed, Apr 24, 2019 at 9:15 AM Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Force the driver thread to sync immediately with a compiler thread (but > compilation still happens in a separate thread). > > This can be

Re: [Mesa-dev] [PATCH 1/8] radeonsi: add si_debug_options for convenient adding/removing of options

2019-04-24 Thread Marek Olšák
h > @@ -140,21 +140,20 @@ enum { > DBG_PREOPT_IR, > > /* Shader compiler options the shader cache should be aware of: */ > DBG_FS_CORRECT_DERIVS_AFTER_KILL, > DBG_UNSAFE_MATH, > DBG_SI_SCHED, > DBG_GISEL, > > /* Sh

Re: [Mesa-dev] Mesa (master): radeonsi: delay adding BOs at the beginning of IBs until the first draw

2019-04-24 Thread Marek Olšák
65002e3ee1a4c61 > > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=951d60f8cdc886adff09201ff65002e3ee1a4c61 > > > > Author: Marek Olšák > > Date: Wed Feb 27 21:13:15 2019 -0500 > > > > radeonsi: delay adding BOs at the beginning of IBs until the first d

[Mesa-dev] [PATCH] radeonsi: add BOs after need_cs_space

2019-04-24 Thread Marek Olšák
From: Marek Olšák need_cs_space may clear the buffer list. Fixes: 951d60f8cdc88 "radeonsi: delay adding BOs at the beginning of IBs until the first draw" --- src/gallium/drivers/radeonsi/si_compute.c| 6 +++--- src/gallium/drivers/radeonsi/si_state_draw.c | 6 +++--- 2 files

Re: [Mesa-dev] [PATCH 1/3] radeonsi/gfx9: set that window_rectangles always roll the context

2019-04-24 Thread Marek Olšák
Ping On Thu, Apr 18, 2019 at 5:46 PM Marek Olšák wrote: > From: Marek Olšák > > Cc: 19.0 > --- > src/gallium/drivers/radeonsi/si_state.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/si_state.h > b/s

[Mesa-dev] [PATCH] glsl: fix and clean up NV_compute_shader_derivatives support

2019-04-24 Thread Marek Olšák
From: Marek Olšák --- src/compiler/glsl/builtin_functions.cpp | 78 - 1 file changed, 24 insertions(+), 54 deletions(-) diff --git a/src/compiler/glsl/builtin_functions.cpp b/src/compiler/glsl/builtin_functions.cpp index c8d9e1c9af3..b1ffafa1acf 100644 --- a/src

[Mesa-dev] [PATCH] gallium: set PIPE_CAP_MAX_FRAMES_IN_FLIGHT to 2 for all drivers

2019-04-23 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_screen.c| 4 +++- src/gallium/drivers/freedreno/freedreno_screen.c | 3 --- src/gallium/drivers/i915/i915_screen.c | 3 --- src/gallium/drivers/nouveau/nv30/nv30_screen.c | 3 --- src/gallium/drivers/nouveau/nv50

Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

2019-04-23 Thread Marek Olšák
Adam, did you notice my original suggestion "If there is at least 1 drm device, swrast won't be in the list."? which means swrast would be in the list for your "dumb" GPUs. Marek On Tue, Apr 23, 2019 at 7:52 PM Adam Jackson wrote: > On Tue, 2019-04-23 at 19:21 -

Re: [Mesa-dev] [PATCH 2/5] st/dri: flush before throttling in SwapBuffers

2019-04-23 Thread Marek Olšák
On Tue, Apr 23, 2019 at 7:30 PM Marek Olšák wrote: > On Tue, Apr 23, 2019 at 4:49 PM Kenneth Graunke > wrote: > >> On Monday, April 22, 2019 6:29:43 PM PDT Marek Olšák wrote: >> > From: Marek Olšák >> > >> > for better CPU-GPU parallelism >

Re: [Mesa-dev] [PATCH 2/5] st/dri: flush before throttling in SwapBuffers

2019-04-23 Thread Marek Olšák
On Tue, Apr 23, 2019 at 4:49 PM Kenneth Graunke wrote: > On Monday, April 22, 2019 6:29:43 PM PDT Marek Olšák wrote: > > From: Marek Olšák > > > > for better CPU-GPU parallelism > > --- > > src/gallium/state_trackers/dri/dri_drawable.c | 20 +-

Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

2019-04-23 Thread Marek Olšák
On Tue, Apr 23, 2019 at 6:30 PM Eric Anholt wrote: > Marek Olšák writes: > > > On Tue, Apr 23, 2019 at 4:39 PM Mathias Fröhlich < > mathias.froehl...@gmx.net> > > wrote: > > > >> Hi, > >> > >> On Tuesday, 23 April 2019 22:23:45 CE

Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

2019-04-23 Thread Marek Olšák
On Tue, Apr 23, 2019 at 4:39 PM Mathias Fröhlich wrote: > Hi, > > On Tuesday, 23 April 2019 22:23:45 CEST Marek Olšák wrote: > > On Tue, Apr 23, 2019 at 4:05 PM Mathias Fröhlich < > mathias.froehl...@gmx.net> > > wrote: > > > > > Hi Marek, > &

Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

2019-04-23 Thread Marek Olšák
On Tue, Apr 23, 2019 at 4:05 PM Mathias Fröhlich wrote: > Hi Marek, > > On Tuesday, 23 April 2019 20:22:15 CEST Marek Olšák wrote: > > I'd like to remove swrast from devices. It doesn't work (eglInitialize > > fails) and I don't think I like swrast there. Any objections

Re: [Mesa-dev] [PATCH] radeonsi: use CP DMA for the null const buffer clear on CIK

2019-04-23 Thread Marek Olšák
No, the correct backport is attached. Marek On Tue, Apr 23, 2019 at 2:51 PM Dylan Baker wrote: > Hi Marek and Samuel, > > I've staged this for 19.0, but I had to fix some very minor rebase > conflicts. > I'm getting ready to make a release, could one of you take a peak at the > tip of > the

Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

2019-04-23 Thread Marek Olšák
I'd like to remove swrast from devices. It doesn't work (eglInitialize fails) and I don't think I like swrast there. Any objections? Marek On Wed, Apr 17, 2019 at 12:38 AM Mathias Fröhlich wrote: > > Hi, > > On Tuesday, 16 April 2019 17:50:33 CEST Marek Olšák wrote: > > On

Re: [Mesa-dev] [PATCH] st/mesa/radeonsi: fix race between destruction of types and shader compilation

2019-04-23 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Apr 23, 2019 at 2:04 AM Timothy Arceri wrote: > Commit 624789e3708c moved the destruction of types out of atexit() and > made use of a ref count instead. This is useful for avoiding a crash > where drivers such as radeonsi are still compiling in

[Mesa-dev] [PATCH 1/5] st/dri: simplify throttling code

2019-04-22 Thread Marek Olšák
From: Marek Olšák --- src/gallium/state_trackers/dri/dri2.c | 4 +--- src/gallium/state_trackers/dri/dri_drawable.c | 2 +- src/gallium/state_trackers/dri/dri_screen.h | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src

[Mesa-dev] [PATCH 5/5] gallium: replace drm_driver_descriptor::configuration with driconf_xml

2019-04-22 Thread Marek Olšák
From: Marek Olšák PIPE_CAPs are better. --- .../auxiliary/pipe-loader/pipe_loader.c | 16 + .../auxiliary/pipe-loader/pipe_loader.h | 10 .../auxiliary/pipe-loader/pipe_loader_drm.c | 40 +++-- .../auxiliary/pipe-loader/pipe_loader_priv.h | 3 +- .../auxiliary

[Mesa-dev] [PATCH 2/5] st/dri: flush before throttling in SwapBuffers

2019-04-22 Thread Marek Olšák
From: Marek Olšák for better CPU-GPU parallelism --- src/gallium/state_trackers/dri/dri_drawable.c | 20 +-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/gallium/state_trackers/dri/dri_drawable.c b/src/gallium/state_trackers/dri/dri_drawable.c index

[Mesa-dev] [PATCH 4/5] gallium: replace DRM_CONF_SHARE_FD with PIPE_CAP_DMABUF

2019-04-22 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/target-helpers/drm_helper.h | 11 --- src/gallium/auxiliary/util/u_screen.c | 7 +++ src/gallium/docs/source/screen.rst| 2 ++ src/gallium/include/pipe/p_defines.h | 1 + src/gallium/include

[Mesa-dev] [PATCH 3/5] gallium: replace DRM_CONF_THROTTLE with PIPE_CAP_MAX_FRAMES_IN_FLIGHT

2019-04-22 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/target-helpers/drm_helper.h | 7 --- src/gallium/auxiliary/util/u_screen.c | 1 + src/gallium/docs/source/screen.rst| 3 +++ src/gallium/drivers/freedreno/freedreno_screen.c | 3 +++ src/gallium/drivers/i915

[Mesa-dev] [PATCH 4/5] gallium: replace DRM_CONF_SHARE_FD with PIPE_CAP_DMABUF

2019-04-22 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/target-helpers/drm_helper.h | 11 --- src/gallium/auxiliary/util/u_screen.c | 7 +++ src/gallium/docs/source/screen.rst| 2 ++ src/gallium/include/pipe/p_defines.h | 1 + src/gallium/include

[Mesa-dev] [PATCH 5/5] gallium: replace drm_driver_descriptor::configuration with driconf_xml

2019-04-22 Thread Marek Olšák
From: Marek Olšák The configuration callback duplicated the PIPE_CAP system. --- .../auxiliary/pipe-loader/pipe_loader.c | 16 + .../auxiliary/pipe-loader/pipe_loader.h | 10 .../auxiliary/pipe-loader/pipe_loader_drm.c | 40 +++-- .../auxiliary/pipe-loader

[Mesa-dev] [PATCH 1/5] st/dri: simplify throttling code

2019-04-22 Thread Marek Olšák
From: Marek Olšák --- src/gallium/state_trackers/dri/dri2.c | 4 +--- src/gallium/state_trackers/dri/dri_drawable.c | 2 +- src/gallium/state_trackers/dri/dri_screen.h | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src

[Mesa-dev] [PATCH 2/5] st/dri: flush before throttling in SwapBuffers

2019-04-22 Thread Marek Olšák
From: Marek Olšák for better CPU-GPU parallelism --- src/gallium/state_trackers/dri/dri_drawable.c | 20 +-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/gallium/state_trackers/dri/dri_drawable.c b/src/gallium/state_trackers/dri/dri_drawable.c index

[Mesa-dev] [PATCH 3/5] gallium: replace DRM_CONF_THROTTLE with PIPE_CAP_MAX_FRAMES_IN_FLIGHT

2019-04-22 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/target-helpers/drm_helper.h | 7 --- src/gallium/auxiliary/util/u_screen.c | 1 + src/gallium/docs/source/screen.rst| 3 +++ src/gallium/drivers/freedreno/freedreno_screen.c | 3 +++ src/gallium/drivers/i915

Re: [Mesa-dev] [PATCH] glsl: fix shader_storage_blocks_write_access for SSBO block arrays (v2)

2019-04-22 Thread Marek Olšák
Ping. Thanks. On Tue, Apr 16, 2019 at 10:16 AM Marek Olšák wrote: > From: Marek Olšák > > This fixes KHR-GL45.compute_shader.resources-max on radeonsi. > > Fixes: 4e1e8f684bf "glsl: remember which SSBOs are not read-only and pass > it to gallium" > > v2: use

[Mesa-dev] [PATCH] gallium: document conservative rasterization flags

2019-04-22 Thread Marek Olšák
From: Marek Olšák --- src/gallium/docs/source/screen.rst | 5 + src/gallium/include/pipe/p_defines.h | 11 +++ 2 files changed, 16 insertions(+) diff --git a/src/gallium/docs/source/screen.rst b/src/gallium/docs/source/screen.rst index b7b5f3504b2..41008816ee2 100644 --- a/src

Re: [Mesa-dev] [PATCH 1/3] ac/nir: only use the new raw/struct image atomic intrinsics with LLVM 9+

2019-04-22 Thread Marek Olšák
Is "XXX" in the comment really necessary? Marek On Thu, Apr 18, 2019 at 3:20 AM Samuel Pitoiset wrote: > They are buggy with LLVM 8 because they weren't marked as source > of divergence, see r358579. > > Fixes: dd0172e865f ("radv: Use structured intrinsics instead of indexing > workaround for

Re: [Mesa-dev] [PATCH 1/4] radeonsi/gfx9: set that window_rectangles always roll the context

2019-04-18 Thread Marek Olšák
Please disregard this series. Marek On Wed, Apr 17, 2019 at 7:39 PM Marek Olšák wrote: > From: Marek Olšák > > Cc: 19.0 > --- > src/gallium/drivers/radeonsi/si_state.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/rad

[Mesa-dev] [PATCH 3/3] radeonsi: remove dirty slot masks from scissor and viewport states

2019-04-18 Thread Marek Olšák
From: Marek Olšák All registers in the array need to be updated if any of them is changed. Only apps writing gl_ViewportIndex were affected by this bug. --- src/gallium/drivers/radeonsi/si_blit.c| 2 +- src/gallium/drivers/radeonsi/si_gfx_cs.c | 3 - src/gallium/drivers

[Mesa-dev] [PATCH 1/2] gallium: add PIPE_CAP_PREFER_COMPUTE_BLIT_FOR_MULTIMEDIA

2019-04-18 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_screen.c | 1 + src/gallium/docs/source/screen.rst| 2 ++ src/gallium/drivers/radeonsi/si_get.c | 1 + src/gallium/include/pipe/p_defines.h | 1 + 4 files changed, 5 insertions(+) diff --git a/src/gallium/auxiliary/util/u_screen.c b/src

[Mesa-dev] [PATCH 2/3] radeonsi/gfx9: rework the gfx9 scissor bug workaround (v2)

2019-04-18 Thread Marek Olšák
From: Marek Olšák Needed to track context rolls caused by streamout and ACQUIRE_MEM. ACQUIRE_MEM can occur outside of draw calls. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110355 v2: squashed patches and done more rework Cc: 19.0 --- src/gallium/drivers/radeonsi/si_pipe.c

[Mesa-dev] [PATCH 1/3] radeonsi/gfx9: set that window_rectangles always roll the context

2019-04-18 Thread Marek Olšák
From: Marek Olšák Cc: 19.0 --- src/gallium/drivers/radeonsi/si_state.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.h b/src/gallium/drivers/radeonsi/si_state.h index 311e1a428ae..119558b8674 100644 --- a/src/gallium/drivers

[Mesa-dev] [PATCH 2/2] va: use a compute shader for the blit

2019-04-18 Thread Marek Olšák
From: "Jiang, Sonny" Signed-off-by: Sonny Jiang Signed-off-by: Marek Olšák --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/util/u_compute.c | 165 + src/gallium/auxiliary/util/u_compute.h | 45 ++ src/gallium/state_t

[Mesa-dev] [PATCH] radeonsi/gfx9: use the correct condition for the DPBB + QUANT_MODE workaround

2019-04-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_viewport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_viewport.c b/src/gallium/drivers/radeonsi/si_state_viewport.c index 1ec69216841..83905d36ee6 100644 --- a/src

[Mesa-dev] [PATCH 4/4] radeonsi/gfx9: clean up context roll tracking logic

2019-04-17 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.h | 2 +- src/gallium/drivers/radeonsi/si_state.c | 8 +++ src/gallium/drivers/radeonsi/si_state_binning.c | 4 ++-- src/gallium/drivers/radeonsi/si_state_draw.c | 30 +++- src/gallium

[Mesa-dev] [PATCH 2/4] radeonsi/gfx9: apply the scissor bug workaround to si_emit_streamout_end

2019-04-17 Thread Marek Olšák
From: Marek Olšák si_emit_streamout_end is called directly, it's not a state. Cc: 19.0 --- src/gallium/drivers/radeonsi/si_pipe.c| 2 ++ src/gallium/drivers/radeonsi/si_pipe.h| 1 + src/gallium/drivers/radeonsi/si_state_draw.c | 2 +- src/gallium/drivers

[Mesa-dev] [PATCH 3/4] radeonsi/gfx9: ACQUIRE_MEM rolls the context, rework scissor bug workaround

2019-04-17 Thread Marek Olšák
From: Marek Olšák The rework is needed to include ACQUIRE_MEM in the workaround by moving the workaround logic out of si_emit_all_states. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110355 Cc: 19.0 --- src/gallium/drivers/radeonsi/si_state_draw.c | 60

[Mesa-dev] [PATCH 1/4] radeonsi/gfx9: set that window_rectangles always roll the context

2019-04-17 Thread Marek Olšák
From: Marek Olšák Cc: 19.0 --- src/gallium/drivers/radeonsi/si_state.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.h b/src/gallium/drivers/radeonsi/si_state.h index 311e1a4..119558b 100644 --- a/src/gallium/drivers/radeonsi

Re: [Mesa-dev] [PATCH 2/2] egl: add EGL_platform_device support

2019-04-16 Thread Marek Olšák
On Wed, Apr 10, 2019 at 5:37 AM Mathias Fröhlich wrote: > Hi Emil, > > On Monday, 8 April 2019 12:28:55 CEST Emil Velikov wrote: > > > Now that I have been putting together a test case for the the actual > use > > > I do see some issues with the pbuffer code path. Well - still > investigating >

Re: [Mesa-dev] [PATCH v2 1/3] ac: add support for more types with struct/raw LLVM intrinsics

2019-04-16 Thread Marek Olšák
You can add my Rb for the rest of the series as well. Marek On Tue, Apr 16, 2019 at 11:04 AM Marek Olšák wrote: > On Tue, Apr 16, 2019 at 10:41 AM Samuel Pitoiset < > samuel.pitoi...@gmail.com> wrote: > >> >> On 4/16/19 4:21 PM, Marek Olšák wrote: >

Re: [Mesa-dev] [PATCH v2 1/3] ac: add support for more types with struct/raw LLVM intrinsics

2019-04-16 Thread Marek Olšák
On Tue, Apr 16, 2019 at 10:41 AM Samuel Pitoiset wrote: > > On 4/16/19 4:21 PM, Marek Olšák wrote: > > Reviewed-by: Marek Olšák > > Is the Rb for the whole series? > No, just this patch. Marek ___ mesa-dev mailing list mesa-dev@

Re: [Mesa-dev] [PATCH 5/6] st/dri: don't re-write plane format if supported by driver

2019-04-16 Thread Marek Olšák
For patches 1 - 5: Reviewed-by: Marek Olšák Marek On Fri, Apr 12, 2019 at 1:33 PM Lucas Stach wrote: > If the driver supports multi-planar formats natively we don't want to > re-write the format of the planes on import. Split this out in a > separate function for clarity. >

Re: [Mesa-dev] [PATCH 6/6] st/mesa: skip any extra handling of YUV textures if driver supports them

2019-04-16 Thread Marek Olšák
On Fri, Apr 12, 2019 at 1:33 PM Lucas Stach wrote: > If the driver provides native support for YUV textures we can skip > adding additional samplers and re-writing the shaders. > > Signed-off-by: Lucas Stach > --- > src/mesa/state_tracker/st_atom_sampler.c | 6 ++ >

Re: [Mesa-dev] [PATCH 2/3] ac/nir: add 64-bit SSBO atomic operations support

2019-04-16 Thread Marek Olšák
On Tue, Apr 16, 2019 at 10:34 AM Marek Olšák wrote: > On Tue, Apr 16, 2019 at 4:35 AM Samuel Pitoiset > wrote: > >> Except compare which is still buggy. >> >> Signed-off-by: Samuel Pitoiset >> --- >> src/amd/common/ac_nir_to_llvm.c | 11 ---

Re: [Mesa-dev] [PATCH 2/3] ac/nir: add 64-bit SSBO atomic operations support

2019-04-16 Thread Marek Olšák
On Tue, Apr 16, 2019 at 4:35 AM Samuel Pitoiset wrote: > Except compare which is still buggy. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_nir_to_llvm.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/src/amd/common/ac_nir_to_llvm.c >

Re: [Mesa-dev] [PATCH] radeonsi/nir: fix scanning of bindless images

2019-04-16 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Apr 16, 2019 at 12:33 AM Timothy Arceri wrote: > Fixes: d62d434fe920 ("ac/nir_to_llvm: add image bindless support") > --- > src/gallium/drivers/radeonsi/si_shader_nir.c | 75 ++-- > 1 file changed, 37 inser

Re: [Mesa-dev] [PATCH v2 1/3] ac: add support for more types with struct/raw LLVM intrinsics

2019-04-16 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Apr 16, 2019 at 2:27 AM Samuel Pitoiset wrote: > > On 4/15/19 11:07 PM, Marek Olšák wrote: > > On Mon, Apr 15, 2019 at 12:40 PM Samuel Pitoiset < > samuel.pitoi...@gmail.com> wrote: > >> LLVM 9+ now supports 8-bit and 16

Re: [Mesa-dev] [PATCH] winsys/amdgpu: don't set GTT with GDS & OA placements on APUs

2019-04-16 Thread Marek Olšák
On Tue, Apr 16, 2019 at 5:34 AM Michel Dänzer wrote: > On 2019-04-15 7:21 p.m., Marek Olšák wrote: > > From: Marek Olšák > > > > --- > > src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 20 +++- > > 1 file changed, 11 insertions(+), 9 deletions(-)

[Mesa-dev] [PATCH] glsl: fix shader_storage_blocks_write_access for SSBO block arrays (v2)

2019-04-16 Thread Marek Olšák
From: Marek Olšák This fixes KHR-GL45.compute_shader.resources-max on radeonsi. Fixes: 4e1e8f684bf "glsl: remember which SSBOs are not read-only and pass it to gallium" v2: use is_interface_array, protect again assertion failures in u_bit_consecutive --- src/compiler/glsl/link_un

Re: [Mesa-dev] [PATCH] nir: optimize gl_SampleMaskIn to gl_HelperInvocation for radeonsi when possible

2019-04-15 Thread Marek Olšák
On Mon, Apr 15, 2019, 10:41 PM Timothy Arceri wrote: > > > On 16/4/19 7:03 am, Marek Olšák wrote: > > ping > > > > On Tue, Apr 9, 2019 at 10:03 PM Marek Olšák > <mailto:mar...@gmail.com>> wrote: > > > > From: Marek Olšák mailto:marek.ol.

Re: [Mesa-dev] [PATCH v2 1/3] ac: add support for more types with struct/raw LLVM intrinsics

2019-04-15 Thread Marek Olšák
On Mon, Apr 15, 2019 at 12:40 PM Samuel Pitoiset wrote: > LLVM 9+ now supports 8-bit and 16-bit types. > > v2: - rebase on master (without the vec3 change) > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_llvm_build.c | 46 +++--- > 1 file changed, 26

Re: [Mesa-dev] [PATCH] nir: optimize gl_SampleMaskIn to gl_HelperInvocation for radeonsi when possible

2019-04-15 Thread Marek Olšák
ping On Tue, Apr 9, 2019 at 10:03 PM Marek Olšák wrote: > From: Marek Olšák > > --- > src/compiler/nir/nir.h| 8 + > src/compiler/nir/nir_opt_intrinsics.c | 40 +-- > src/gallium/drivers/radeonsi/si_get.c | 1 + > s

Re: [Mesa-dev] [PATCH] radeonsi: enable GL_EXT_shader_image_load_formatted

2019-04-15 Thread Marek Olšák
On Mon, Apr 15, 2019 at 3:30 PM Bas Nieuwenhuizen wrote: > I don't see this cap defined anywhere? > > If it depends on an earlier series that is not pushed yet, but your > are going to, > > Reviewed-by: Bas Nieuwenhuizen > Thanks. Yes it depends on an earlier series by Rhys Perry from January.

[Mesa-dev] [PATCH] winsys/amdgpu: don't set GTT with GDS & OA placements on APUs

2019-04-15 Thread Marek Olšák
From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c index c1863057370..09cf9247755 100644 --- a/src

[Mesa-dev] [PATCH] radeonsi: enable GL_EXT_shader_image_load_formatted

2019-04-15 Thread Marek Olšák
From: Marek Olšák no changes - the driver doesn't use the format --- docs/relnotes/19.1.0.html | 1 + src/gallium/drivers/radeonsi/si_get.c | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/relnotes/19.1.0.html b/docs/relnotes/19.1.0.html index 1c5f8d034b7..36d6dbe27c3

Re: [Mesa-dev] [PATCH] radeonsi: use CP DMA for the null const buffer clear on CIK

2019-04-12 Thread Marek Olšák
Done locally. Marek On Fri, Apr 12, 2019 at 12:20 PM Samuel Pitoiset wrote: > I would suggest to document that workaround somewhere in the code. > > On 4/12/19 5:17 PM, Marek Olšák wrote: > > From: Marek Olšák > > > > This is a workaround for a thread deadlock

Re: [Mesa-dev] [PATCH] mesa: don't overwrite existing shader files with MESA_SHADER_CAPTURE_PATH

2019-04-12 Thread Marek Olšák
On Fri, Apr 12, 2019 at 11:41 AM Eric Engestrom wrote: > On Friday, 2019-04-12 11:00:56 -0400, Marek Olšák wrote: > > On Thu, Apr 11, 2019 at 2:53 AM Tapani Pälli > wrote: > > > On 4/11/19 3:32 AM, Marek Olšák wrote: > > > >

[Mesa-dev] [PATCH] ac: fix possibly incorrect bindless atomic code in visit_image_atomic

2019-04-12 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_nir_to_llvm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 55c64e2aacb..afdd9318fff 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common

[Mesa-dev] [PATCH] radeonsi: use CP DMA for the null const buffer clear on CIK

2019-04-12 Thread Marek Olšák
From: Marek Olšák This is a workaround for a thread deadlock that I have no idea why it occurs. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108879 Fixes: 9b331e462e5021d994859756d46cd2519d9c9c6e --- src/gallium/drivers/radeonsi/si_clear.c| 6 +++--- src/gallium/drivers

Re: [Mesa-dev] [PATCH 2/2] ac: use the common helper ac_apply_fmask_to_sample

2019-04-12 Thread Marek Olšák
On Thu, Apr 11, 2019 at 3:15 AM Samuel Pitoiset wrote: > > On 4/11/19 3:30 AM, Marek Olšák wrote: > > From: Marek Olšák > > > > --- > > src/amd/common/ac_nir_to_llvm.c | 70 +++-- > > 1 file changed, 5 insertions(+), 65 delet

Re: [Mesa-dev] [PATCH] mesa: don't overwrite existing shader files with MESA_SHADER_CAPTURE_PATH

2019-04-12 Thread Marek Olšák
On Thu, Apr 11, 2019 at 2:53 AM Tapani Pälli wrote: > > On 4/11/19 3:32 AM, Marek Olšák wrote: > > From: Marek Olšák > > > > --- > > src/mesa/main/shaderapi.c | 20 +--- > > 1 file changed, 17 insertions(+), 3 deletions(-) > > > &

Re: [Mesa-dev] [PATCH] [rfc] st/mesa: don't update fb state is raster discard is set.

2019-04-10 Thread Marek Olšák
Consider this sequence of calls: 1) Enable rasterizer discard 2) Update the framebuffer (skipped by your patch) 3) Draw 4) Disable rasterizer discard 5) Draw (not using the correct framebuffer) Marek On Wed, Apr 10, 2019 at 2:10 AM Dave Airlie wrote: > From: Dave Airlie > > This avoid

Re: [Mesa-dev] [PATCH] gallium/aux: Report error if loading of a pipe driver fails.

2019-04-10 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Apr 3, 2019 at 2:02 AM Jan Vesely wrote: > Skip over non-existent files. > Signed-off-by: Jan Vesely > --- > This should help detect instances of messed up/missing symbols in the > driver. > windows build seems OK: > https://ci

Re: [Mesa-dev] [PATCH] gallium: trace: Add missing fence related wrappers

2019-04-10 Thread Marek Olšák
Pushed, thanks! Marek On Tue, Apr 9, 2019 at 7:33 AM Guido Günther wrote: > Hi, > On Fri, Mar 29, 2019 at 05:48:31PM +0100, Guido Günther wrote: > > Without that kmscube with GALLIUM_TRACE would segfault like: > > > > #0 0x in () > > #1 0x8f311760 in

[Mesa-dev] [PATCH 2/2] ac: use the common helper ac_apply_fmask_to_sample

2019-04-10 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_nir_to_llvm.c | 70 +++-- 1 file changed, 5 insertions(+), 65 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 3d2f738edec..3abde6e0969 100644 --- a/src/amd/common

[Mesa-dev] [PATCH 1/2] radeonsi: set AC_FUNC_ATTR_READNONE for image opcodes where it was missing

2019-04-10 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_llvm_build.c| 1 + src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 4 2 files changed, 5 insertions(+) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index a612dcefa1d..cfbca294c97 100644

Re: [Mesa-dev] [PATCH 10/10] ac/nir: remove some useless integer casts for ALU operations

2019-04-10 Thread Marek Olšák
On Wed, Apr 10, 2019 at 7:44 PM Timothy Arceri wrote: > Before I attempt to review, have you run piglit on this series with > radeonsi nir? > That's a good idea. If there is no piglit regression on radeonsi, the series is: Reviewed-by: Marek Olšá

[Mesa-dev] [PATCH] mesa: don't overwrite existing shader files with MESA_SHADER_CAPTURE_PATH

2019-04-10 Thread Marek Olšák
From: Marek Olšák --- src/mesa/main/shaderapi.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 01342c04e8f..6b73e6c7e7a 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c

[Mesa-dev] [PATCH] nir: optimize gl_SampleMaskIn to gl_HelperInvocation for radeonsi when possible

2019-04-09 Thread Marek Olšák
From: Marek Olšák --- src/compiler/nir/nir.h| 8 + src/compiler/nir/nir_opt_intrinsics.c | 40 +-- src/gallium/drivers/radeonsi/si_get.c | 1 + src/mesa/state_tracker/st_glsl_to_nir.cpp | 1 + 4 files changed, 48 insertions(+), 2 deletions

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Upload constants to VRAM via SDMA

2019-04-09 Thread Marek Olšák
On Mon, Apr 8, 2019 at 10:32 PM Dieter Nützel wrote: > Am 09.04.2019 02:42, schrieb Marek Olšák: > > I'm pretty sure I merged this series in February. > > > > Marek > > Yes, of course you did (with my tb), but I meant... (see below) > > > On Mon, Apr 8, 2019

[Mesa-dev] [PATCH] glsl: allow the #extension directive within code blocks for the dri option

2019-04-09 Thread Marek Olšák
From: Marek Olšák for Viewperf 13 --- src/compiler/glsl/glsl_parser.yy | 9 + 1 file changed, 9 insertions(+) diff --git a/src/compiler/glsl/glsl_parser.yy b/src/compiler/glsl/glsl_parser.yy index 8d6c47fb6a3..b91c24ebe97 100644 --- a/src/compiler/glsl/glsl_parser.yy +++ b/src/compiler

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: Upload constants to VRAM via SDMA

2019-04-08 Thread Marek Olšák
I'm pretty sure I merged this series in February. Marek On Mon, Apr 8, 2019 at 6:10 PM Dieter Nützel wrote: > Maybe someone working on this, too. > > I'm feeling fine again after a short 'trip' into the hospital...;-) > > Dieter > > Am 26.02.2019 07:36, schrieb Mar

Re: [Mesa-dev] [PATCH 00/26] RadeonSI: Primitive culling with async compute

2019-04-08 Thread Marek Olšák
Nützel: > > Hello Marek, > > > > do you plan to commit or rebase both set? > > > > Dieter > > > > Am 14.02.2019 07:29, schrieb Marek Olšák: > >> I have some fixes for Sea Islands that improve Radeon 290X performance > >> to 43 fps, moving it

[Mesa-dev] [PATCH] glsl: fix shader_storage_blocks_write_access for SSBO block arrays

2019-04-08 Thread Marek Olšák
From: Marek Olšák CTS: GL45-CTS.compute_shader.resources-max Fixes: 4e1e8f684bf "glsl: remember which SSBOs are not read-only and pass it to gallium" --- src/compiler/glsl/link_uniforms.cpp | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/com

Re: [Mesa-dev] [PATCH] radeonsi: fix a crash when unbinding sampler states

2019-04-08 Thread Marek Olšák
On Mon, Apr 8, 2019 at 2:45 PM James Zhu wrote: > > On 2019-04-08 2:39 p.m., Marek Olšák wrote: > > On Mon, Apr 8, 2019 at 2:33 PM James Zhu wrote: > >> >> On 2019-04-08 2:25 p.m., Marek Olšák wrote: >> > From: Marek Olšák >> > >> > --- &g

Re: [Mesa-dev] [PATCH] radeonsi: fix a crash when unbinding sampler states

2019-04-08 Thread Marek Olšák
On Mon, Apr 8, 2019 at 2:33 PM James Zhu wrote: > > On 2019-04-08 2:25 p.m., Marek Olšák wrote: > > From: Marek Olšák > > > > --- > > src/gallium/drivers/radeonsi/si_descriptors.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >

Re: [Mesa-dev] [PATCH] gallium/drivers/radeonsi: Add si_bind_sampler_states unbind support

2019-04-08 Thread Marek Olšák
I've sent a simpler patch. Please review. Thanks, Marek On Sat, Apr 6, 2019 at 9:07 AM Zhu, James wrote: > commit a613607dc3dab2b43884a4e5891aa5939cdcfbe0 will cause segfault > during unbind sampler state. This patch will fix the issue. > > Signed-off-by: James Zhu > --- >

[Mesa-dev] [PATCH] radeonsi: fix a crash when unbinding sampler states

2019-04-08 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index 244ba5a7bec..ac40ed27f91 100644 --- a/src/gallium/drivers

[Mesa-dev] [PATCH] amd/addrlib: fix uninitialized values for Addr2ComputeDccAddrFromCoord

2019-04-03 Thread Marek Olšák
From: Marek Olšák --- src/amd/addrlib/src/gfx9/gfx9addrlib.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/amd/addrlib/src/gfx9/gfx9addrlib.cpp b/src/amd/addrlib/src/gfx9/gfx9addrlib.cpp index b3cbccf..9be775f 100644 --- a/src/amd/addrlib/src/gfx9/gfx9addrlib.cpp +++ b/src/amd

Re: [Mesa-dev] [PATCH] gallium/u_dump: util_dump_sampler_view: Dump u.tex.first_level

2019-04-03 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Apr 3, 2019 at 12:13 PM Guido Günther wrote: > Dump u.tex.first_level instead of dumping u.tex.last_level twice. > > Signed-off-by: Guido Günther > --- > src/gallium/auxiliary/util/u_dump_state.c | 2 +- > 1 file changed, 1 insert

Re: [Mesa-dev] [PATCH v2 3/3] gallium/auxiliary/vl: Add barrier/unbind after compute shader launch.

2019-04-03 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Wed, Apr 3, 2019 at 11:01 AM Zhu, James wrote: > Add memory barrier sync for multiple launch cases, and unbind completed > resources after launch. > > Signed-off-by: James Zhu > --- > src/gallium/auxiliary/vl/vl_co

Re: [Mesa-dev] [PATCH v2 8/8] egl: add EGL_platform_device support

2019-04-03 Thread Marek Olšák
On Wed, Apr 3, 2019 at 10:13 AM Mathias Fröhlich wrote: > > What is missing for merging this? > > I saw the pbuffer swrast crash and proposed to disable them via the > 3rd patch that I pushed into my branch for you. > Emil never responded to that proposal directly. In one mail he mentioned >

Re: [Mesa-dev] [PATCH] mesa gallium: use compute shaders for vaapi blit

2019-04-03 Thread Marek Olšák
On Wed, Apr 3, 2019 at 9:57 AM Ilia Mirkin wrote: > On Wed, Apr 3, 2019 at 9:36 AM Marek Olšák wrote: > > > > On Wed, Apr 3, 2019 at 9:06 AM Ilia Mirkin wrote: > >> > >> On Wed, Apr 3, 2019 at 8:38 AM Marek Olšák wrote: > >> > > >&g

Re: [Mesa-dev] [PATCH 3/3] gallium/auxiliary/vl: Add barrier/unbind after compute shader launch.

2019-04-03 Thread Marek Olšák
On Tue, Apr 2, 2019 at 2:22 PM Zhu, James wrote: > Add memory barrier sync and unbind resource after launch will enhance > the robustness. > > Signed-off-by: James Zhu > --- > src/gallium/auxiliary/vl/vl_compositor_cs.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git

<    1   2   3   4   5   6   7   8   9   10   >