Re: [Mesa-dev] [PATCH] Revert "radeonsi: avoid syncing the driver thread in si_fence_finish"

2018-09-18 Thread Marek Olšák
I'm pretty sure it's correct. Marek On Tue, Sep 18, 2018 at 4:09 AM, andrey simiklit wrote: > Hi, > > Please find my comments below: > > Regards, > Andrii. > > On Tue, Sep 18, 2018 at 4:49 AM Marek Olšák wrote: >> >> Reviewed-by: Marek Olšák >> >

Re: [Mesa-dev] Lets talk about autotools

2018-09-17 Thread Marek Olšák
Did you try --libdir /usr/lib/i386-linux-gnu ? Marek On Mon, Sep 17, 2018 at 11:02 PM, Brian Paul wrote: > Hi Dylan, > > I have my 32-bit cross-compile working, but "ninja -C builddir install" > isn't putting the 32-bit libs and drivers in the right place. > > I've been playing with the meson

[Mesa-dev] [PATCH] docs/features: add EXT_direct_state_access features

2018-09-17 Thread Marek Olšák
From: Marek Olšák --- docs/features.txt | 57 +++ 1 file changed, 57 insertions(+) diff --git a/docs/features.txt b/docs/features.txt index 9ccf803d470..a97f998a5cc 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -337,20 +337,77 @@ Khronos

Re: [Mesa-dev] [PATCH 9/9] mesa: move legacy dri config option texture_depth

2018-09-17 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Wed, Aug 29, 2018 at 8:19 PM, Timothy Arceri wrote: > --- > src/mesa/drivers/dri/radeon/radeon_screen.h | 13 + > src/util/xmlpool/ca.po | 20 > src/util/x

Re: [Mesa-dev] [PATCH 1/2] mesa: enable EXT_framebuffer_object in core profile

2018-09-17 Thread Marek Olšák
It seems like a good idea since EXT_framebuffer_blit/multisample are also exposed. Reviewed-by: Marek Olšák Marek On Sat, Sep 8, 2018 at 12:20 AM, Timothy Arceri wrote: > Since user defined names are not allowed in core profile > we remove the allow_user_names bool and just check if >

Re: [Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

2018-09-17 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Sep 12, 2018 at 7:02 AM, Erik Faye-Lund wrote: > If we update the program-state etc, we risk compiling needless shaders, > which can cost quite a bit of performance. > > Signed-off-by: Erik Faye-Lund > --- > This was motivated by se

Re: [Mesa-dev] [PATCH] mesa/st: In the precense of integer buffers enable per buffer blending

2018-09-17 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Sep 13, 2018 at 4:06 AM, Gert Wollny wrote: > From: Gert Wollny > > Since blending will be disabled later for integer formats we have to > consider that in the case of a mixed set of integer/non-integer format > buffers blending must be h

Re: [Mesa-dev] [PATCH 2/2] util: use force_compat_profile for Wolfenstein The Old Blood

2018-09-17 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Tue, Sep 11, 2018 at 8:52 PM, Timothy Arceri wrote: > This game is looking for some odd extension after creating a core > context such as ARB_vertex_program and EXT_framebuffer_object. > > Rather then enabling these in core

Re: [Mesa-dev] [PATCH] Revert "radeonsi: avoid syncing the driver thread in si_fence_finish"

2018-09-17 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Sep 12, 2018 at 6:50 AM, Timothy Arceri wrote: > This reverts commit bc65dcab3bc48673ff6180afb036561a4b8b1119. > > This was manually reverted. Reverting stops the menu hanging in > some id tech games such as RAGE and Wolfenstein T

Re: [Mesa-dev] Lets talk about autotools

2018-09-17 Thread Marek Olšák
Other than the --with-sha1 thing, meson works for me. That said, we need some time to move our internal builds to meson and there is a tiny chance that we'll discover some issues. Removing autotools after 18.3 would be preferable. Thanks, Marek On Mon, Sep 17, 2018 at 12:44 PM, Dylan Baker

Re: [Mesa-dev] Lets talk about autotools

2018-09-17 Thread Marek Olšák
One missing feature is --with-sha1=. libcrypto has an unstable ABI and Steam uses it. For Mesa to work with Steam, libnettle has/had to be used instead. Marek On Mon, Sep 17, 2018 at 12:44 PM, Dylan Baker wrote: > I feel like for !windows meson is in good enough shape at this point that we >

Re: [Mesa-dev] Lets talk about autotools

2018-09-17 Thread Marek Olšák
Thanks for all answers. Small bug: src/gallium/winsys/sw is built even though I've not selected any swrast driver. Marek On Mon, Sep 17, 2018 at 12:44 PM, Dylan Baker wrote: > I feel like for !windows meson is in good enough shape at this point that we > can start having the discussion about

Re: [Mesa-dev] Lets talk about autotools

2018-09-17 Thread Marek Olšák
How do I build 32-bit Mesa with meson? Thanks, Marek On Mon, Sep 17, 2018 at 12:44 PM, Dylan Baker wrote: > I feel like for !windows meson is in good enough shape at this point that we > can start having the discussion about deleting the autotools build. So, is > there > anything left that

Re: [Mesa-dev] Lets talk about autotools

2018-09-17 Thread Marek Olšák
'meson configure' returns 'auto' for a lot of options. I'm interested in what meson chose. Marek On Mon, Sep 17, 2018 at 6:09 PM, Caio Marcelo de Oliveira Filho wrote: > On Mon, Sep 17, 2018 at 05:18:52PM -0400, Marek Olšák wrote: >> If I configure meson, how can I know which state

Re: [Mesa-dev] Lets talk about autotools

2018-09-17 Thread Marek Olšák
Is there any documentation for configure options? Or do I have to do "grep get_option meson.build" to get the list at least? Thanks, Marek On Mon, Sep 17, 2018 at 12:44 PM, Dylan Baker wrote: > I feel like for !windows meson is in good enough shape at this point that we > can start having the

Re: [Mesa-dev] Lets talk about autotools

2018-09-17 Thread Marek Olšák
Where do I find default values for meson configure options? Thanks, Marek On Mon, Sep 17, 2018 at 12:44 PM, Dylan Baker wrote: > I feel like for !windows meson is in good enough shape at this point that we > can start having the discussion about deleting the autotools build. So, is > there >

Re: [Mesa-dev] Lets talk about autotools

2018-09-17 Thread Marek Olšák
What's the rationale for enabling glx-tls by default without the option to change it? Thanks, Marek On Mon, Sep 17, 2018 at 12:44 PM, Dylan Baker wrote: > I feel like for !windows meson is in good enough shape at this point that we > can start having the discussion about deleting the autotools

Re: [Mesa-dev] Lets talk about autotools

2018-09-17 Thread Marek Olšák
If I configure meson, how can I know which state trackers, APIs, and backends are enabled? Thanks, Marek On Mon, Sep 17, 2018 at 12:44 PM, Dylan Baker wrote: > I feel like for !windows meson is in good enough shape at this point that we > can start having the discussion about deleting the

Re: [Mesa-dev] Lets talk about autotools

2018-09-17 Thread Marek Olšák
I don't see radeonsi_dri.so. How/where is radeonsi_dri.so created? Thanks, Marek On Mon, Sep 17, 2018 at 12:44 PM, Dylan Baker wrote: > I feel like for !windows meson is in good enough shape at this point that we > can start having the discussion about deleting the autotools build. So, is >

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

2018-09-14 Thread Marek Olšák
Since only Blender and Firefox experience problems, they can be blacklisted for this optimization, and then we can expand the blacklist as we go. Marek On Fri, Sep 14, 2018 at 9:04 PM, Marek Olšák wrote: > On Fri, Sep 14, 2018 at 4:53 AM, Michel Dänzer wrote: >> On 2018-09-13 8:56 p.

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

2018-09-14 Thread Marek Olšák
On Fri, Sep 14, 2018 at 4:53 AM, Michel Dänzer wrote: > On 2018-09-13 8:56 p.m., Marek Olšák wrote: >> On Thu, Sep 13, 2018 at 11:48 AM, Michel Dänzer wrote: >>> On 2018-09-13 2:40 a.m., Marek Olšák wrote: >>>> From: Marek Olšák >>

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

2018-09-14 Thread Marek Olšák
On Fri, Sep 14, 2018 at 12:54 PM, Nicholas Miell wrote: > On 09/12/2018 05:40 PM, Marek Olšák wrote: >> +static void >> +util_set_full_cpu_affinity(void) >> +{ >> + cpu_set_t cpuset; >> + >> + CPU_ZERO(); >> + for (unsigned i =

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

2018-09-13 Thread Marek Olšák
On Thu, Sep 13, 2018 at 11:48 AM, Michel Dänzer wrote: > On 2018-09-13 2:40 a.m., Marek Olšák wrote: >> From: Marek Olšák >> >> [...] >> >> static void >> -util_init_cache_number(void) >> +util_init_thread_pinning(void) >> { >

Re: [Mesa-dev] [PATCH] move pthread_setaffinity_np check to the build system

2018-09-13 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Sep 13, 2018 at 2:41 PM, Dylan Baker wrote: > Rather than trying to encode all of the rules in a header, lets just put > them in the build system where they belong. This fixes the build on > FreeBSD, which does have pthraed_setaffinity_np,

[Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

2018-09-12 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_helpers.c | 37 +++--- 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/util/u_helpers.c b/src/gallium/auxiliary/util/u_helpers.c index 14367e5a118..3194c2e4e7a 100644 --- a/src/gallium

[Mesa-dev] [PATCH] glsl_to_tgsi: invert gl_SamplePosition.y for the default framebuffer

2018-09-11 Thread Marek Olšák
From: Marek Olšák Fixes dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.default_framebuffer with --deqp-gl-config-name=rgbad24s8ms4 Cc: 18.1 18.2 --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 35 +- 1 file changed, 34 insertions(+), 1

Re: [Mesa-dev] [RFC 4/7] spirv: Insert barriers to follow the Vulkan memory model

2018-09-11 Thread Marek Olšák
On Mon, Sep 10, 2018 at 6:30 PM, Bas Nieuwenhuizen wrote: > On Mon, Sep 10, 2018 at 8:05 PM Jason Ekstrand wrote: >> >> --- >> src/compiler/spirv/spirv_to_nir.c | 170 ++ >> 1 file changed, 103 insertions(+), 67 deletions(-) >> >> diff --git

Re: [Mesa-dev] [PATCH] mesa: remove duplicate dispatch sanity tests

2018-09-10 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Sep 7, 2018 at 6:21 PM, Timothy Arceri wrote: > This removes duplicate tests from gl_core_functions_possible > that are already covered by common_desktop_functions_possible. > --- > src/mesa/main/tests/dispatch_sani

Re: [Mesa-dev] [PATCH] radeon: fix ColorMask

2018-09-10 Thread Marek Olšák
Pushed, thanks! Marek On Fri, Sep 7, 2018 at 8:16 PM, Christopher Egert wrote: > Since commit af3685d14936844f79e6f372b4b258e29375f21b various OpenGL > applications regressed > on the classic mesa radeon driver. > > Signed-off-by: Christopher Egert > CC: > --- >

Re: [Mesa-dev] [PATCH] mesa/texture: Also check for LA texture when querying intensity component size

2018-09-10 Thread Marek Olšák
I think you don't have to check luminance. Returning just the alpha bits should be fine. Marek On Mon, Sep 10, 2018 at 4:33 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Mon, Sep 10, 2018 at 6:39 AM, Gert Wollny wrote: >> From: Gert Wollny &

Re: [Mesa-dev] [PATCH] mesa/texture: Also check for LA texture when querying intensity component size

2018-09-10 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Sep 10, 2018 at 6:39 AM, Gert Wollny wrote: > From: Gert Wollny > > Gallium may pick L16A16_FLOAT to represent GL_INTENSITY16F if no intensity > format is provided by the driver. However, when calling > >glGetT

Re: [Mesa-dev] [PATCH] mesa: Validate the result of pipe_transfer_map in make_texture

2018-09-10 Thread Marek Olšák
Hi, thanks for the patch. I've sent version 2 of the patch with additional fixes to this list. Marek On Sun, Sep 9, 2018 at 10:08 PM, Josh Pieper wrote: > And apparently I am incapable of operating git send-email, so it > failed to include my context: > > When using Freecad, I was getting

[Mesa-dev] [PATCH] mesa: Validate the result of pipe_transfer_map in make_texture (v2)

2018-09-10 Thread Marek Olšák
From: Josh Pieper When using Freecad, I was getting intermittent segfaults inside of mesa. I traced it down to this path in st_cb_drawpixels.c where the result of pipe_transfer_map wasn't being checked. In my case, it was returning NULL because nouveau_bo_new returned ENOENT. I'm by no means

Re: [Mesa-dev] [PATCH v2] gallium: Correctly handle no config context creation

2018-09-10 Thread Marek Olšák
Pushed, thanks for the patch! Marek On Sat, Sep 8, 2018 at 11:57 PM, Elie Tournier wrote: > If you don't mind, can you please push this patch for me? > I don't have git access. > > Thanks a lot, > Elie > On Fri, 7 Sep 2018 at 22:49, Marek Olšák wrote: >> >

Re: [Mesa-dev] [PATCH] android: util/u_thread: fix building error with bionic pthread

2018-09-10 Thread Marek Olšák
On Mon, Sep 10, 2018 at 4:07 AM, Mauro Rossi wrote: > Hi, > > Il giorno lun 10 set 2018 alle ore 09:58 Tapani Pälli > ha scritto: >> >> Marek sent a similar fix here: >> https://lists.freedesktop.org/archives/mesa-dev/2018-September/204797.html > > Thanks a lot! > So the APU L3 cache

Re: [Mesa-dev] [PATCH] utils/u_math: break dependency on gallium/utils

2018-09-10 Thread Marek Olšák
On Mon, Sep 10, 2018 at 12:11 PM, Dylan Baker wrote: > I agree that using code from mesa in util is gross, I'm not planning to leave > it > like this. I'm in the middle of cleaning up duplication between util and mesa, > and I'll plan on pulling u_cpu_detection down into src/util in that series.

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-10 Thread Marek Olšák
On Mon, Sep 10, 2018 at 10:45 AM, Michel Dänzer wrote: > On 2018-09-07 9:01 p.m., Marek Olšák wrote: >> On Fri, Sep 7, 2018 at 11:04 AM, Michel Dänzer wrote: >>> On 2018-09-07 4:31 p.m., Marek Olšák wrote: >>>> On Fri, Sep 7, 2018, 4:34 AM Michel Dänzer wrote:

Re: [Mesa-dev] [PATCH 2/4] gallium/auxiliary: don't dereference counters twice needlessly

2018-09-10 Thread Marek Olšák
On Mon, Sep 10, 2018 at 11:41 AM, Michel Dänzer wrote: > On 2018-09-07 11:35 p.m., Marek Olšák wrote: >> From: Marek Olšák >> >> +1.2% performance with: >> piglit/drawoverhead - DrawElements (no state changes) on radeonsi > > No meaningless number (wh

Re: [Mesa-dev] [PATCH] utils/u_math: break dependency on gallium/utils

2018-09-09 Thread Marek Olšák
I think this will break non-GL gallium state trackers. src/mesa is only for GL, which is why common gallium code and gallium drivers can't use code from src/mesa. Marek On Sun, Sep 9, 2018 at 2:39 AM, Dylan Baker wrote: > Currently u_math needs gallium utils for cpu detection. Most of what >

[Mesa-dev] [PATCH 1/2] util: try to fix the Android build

2018-09-08 Thread Marek Olšák
From: Marek Olšák --- src/util/u_thread.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/util/u_thread.h b/src/util/u_thread.h index ec0d9a7..0c20ebb 100644 --- a/src/util/u_thread.h +++ b/src/util/u_thread.h @@ -29,20 +29,23 @@ #include #include

[Mesa-dev] [PATCH 2/2] gallium: try to fix the Windows build

2018-09-08 Thread Marek Olšák
From: Marek Olšák Windows doesn't have thrd_current. --- src/gallium/auxiliary/util/u_helpers.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/util/u_helpers.c b/src/gallium/auxiliary/util/u_helpers.c index f773360..8095242 100644 --- a/src/gallium/auxiliary/util

Re: [Mesa-dev] [PATCH] mesa/st: Prefer RG_float when emulating INTENSITY Float over LA float

2018-09-07 Thread Marek Olšák
RG can't be used to represent intensity, because RG uses swizzle RG01, while intensity uses . Marek On Wed, Sep 5, 2018 at 4:36 AM, Gert Wollny wrote: > From: Gert Wollny > > Gallium picked R16G16_FLOAT to represent GL_INTENSITY16F if no intensity > format is provided by the driver.

Re: [Mesa-dev] [PATCH v2] gallium: Correctly handle no config context creation

2018-09-07 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Sep 6, 2018 at 5:46 AM, Elie Tournier wrote: > This patch fixes the following Piglit test: > spec@egl_mesa_configless_context@basic > It also fixes few test in a virgl guest. > > v2: Evaluate the value of no_config (Ilia) > > Sugge

Re: [Mesa-dev] [PATCH 15/15] radeonsi/nir: port some bindless and sampler code from TGSI

2018-09-07 Thread Marek Olšák
Ping On Wed, Aug 29, 2018 at 4:13 PM, Marek Olšák wrote: > From: Marek Olšák > > These might be all missing changes for bindless textures. > --- > src/gallium/drivers/radeonsi/si_shader_nir.c | 80 > 1 file changed, 50 insertions(+), 30 deletions(-) &g

[Mesa-dev] [PATCH 3/4] gallium/u_inlines: improve pipe_reference_described perf for debug builds

2018-09-07 Thread Marek Olšák
From: Marek Olšák Tested-by: Dieter Nützel --- src/gallium/auxiliary/util/u_inlines.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/gallium/auxiliary/util/u_inlines.h index 83013df53f1..820d3080a5c 100644 --- a/src

[Mesa-dev] [PATCH 4/4] gallium/u_inlines: remove the destroy variable in pipe_reference_described

2018-09-07 Thread Marek Olšák
From: Marek Olšák Reviewed-by: Michel Dänzer Tested-by: Dieter Nützel --- src/gallium/auxiliary/util/u_inlines.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/gallium/auxiliary/util/u_inlines.h index 820d3080a5c

[Mesa-dev] [PATCH 2/4] gallium/auxiliary: don't dereference counters twice needlessly

2018-09-07 Thread Marek Olšák
From: Marek Olšák +1.2% performance with: piglit/drawoverhead - DrawElements (no state changes) on radeonsi Tested-by: Dieter Nützel --- src/gallium/auxiliary/util/u_inlines.h | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/gallium/auxiliary/util

[Mesa-dev] [PATCH 1/4] gallium/u_inlines: normalize naming, use dst & src, style fixes (v2)

2018-09-07 Thread Marek Olšák
From: Marek Olšák v2: update comments Reviewed-by: Michel Dänzer Tested-by: Dieter Nützel --- src/gallium/auxiliary/util/u_inlines.h | 94 +- 1 file changed, 47 insertions(+), 47 deletions(-) diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/gallium

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Marek Olšák
On Fri, Sep 7, 2018 at 3:34 PM, Alan Swanson wrote: > On Fri, 2018-09-07 at 15:01 -0400, Marek Olšák wrote: >> On Fri, Sep 7, 2018 at 11:04 AM, Michel Dänzer >> wrote: >> > On 2018-09-07 4:31 p.m., Marek Olšák wrote: >> > > >> > > I don't think t

[Mesa-dev] [PATCH] gallium/util: start with a random L3 cache index for AMD Zen

2018-09-07 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_helpers.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/util/u_helpers.c b/src/gallium/auxiliary/util/u_helpers.c index f773360adde..466add53fc9 100644 --- a/src/gallium

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Marek Olšák
> 8) ^ (t >> 16)); +} + Then the next unassigned CPU thread group will be set to: + call_once(_cache_number_flag, util_init_cache_number); + cache = p_atomic_inc_return(_cache_number) % num_L3_caches; Marek On Fri, Sep 7, 2018 at 3:01 PM, Marek Olšák wrote: > On Fri, Sep 7

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Marek Olšák
On Fri, Sep 7, 2018 at 11:04 AM, Michel Dänzer wrote: > On 2018-09-07 4:31 p.m., Marek Olšák wrote: >> On Fri, Sep 7, 2018, 4:34 AM Michel Dänzer wrote: >>> On 2018-09-06 10:56 p.m., Axel Davy wrote: >>> >>>> I fear if we begin to do the work manua

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-07 Thread Marek Olšák
On Fri, Sep 7, 2018, 4:34 AM Michel Dänzer wrote: > On 2018-09-06 10:56 p.m., Axel Davy wrote: > > Yeah by pinning to cores, I meant to group of cores. > > > > I think a reasonable policy would be for the kernel to put all threads > > of a given process on the same L3 > > as long as the number

Re: [Mesa-dev] [PATCH 2/4] st/mesa: pin driver threads to a specific L3 cache on AMD Zen (v2)

2018-09-06 Thread Marek Olšák
On Thu, Sep 6, 2018 at 11:51 PM, Brian Paul wrote: > The revised series looks OK to me. One whitespace issue below. > > For the series, > Reviewed-by: Brian Paul Thanks. Does it also include the first 4 patches in the previous series? Thanks, Marek

Re: [Mesa-dev] [PATCH 1/2] gallium: add PIPE_CAP_MAX_TEXTURE_UPLOAD_MEMORY_BUDGET

2018-09-06 Thread Marek Olšák
It's been 6 days since I sent the patches. I'm thinking about just pushing this. Marek On Tue, Sep 4, 2018 at 8:16 PM, Dieter Nützel wrote: > Hello Marek, > > can you resend? > I want the texture upload speed up... > > Dieter > > > Am 01.09.2018 03:02, schrieb Mar

Re: [Mesa-dev] [PATCH 00/15] RadeonSI Fixes and Cleanups

2018-09-06 Thread Marek Olšák
Does anybody want to review this? Thanks, Marek On Wed, Aug 29, 2018 at 4:12 PM, Marek Olšák wrote: > Hi, > > There are HTILE and CMASK allocator fixes, a GPU hang fix for bindless > textures with LLVM 7.0, partial NIR support for bindless textures, > ddebug fix, and much m

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-06 Thread Marek Olšák
On Thu, Sep 6, 2018 at 5:54 PM, Roland Scheidegger wrote: > Am 06.09.2018 um 22:56 schrieb Axel Davy: >> Yeah by pinning to cores, I meant to group of cores. >> >> I think a reasonable policy would be for the kernel to put all threads >> of a given process on the same L3 >> as long as the number

[Mesa-dev] [PATCH 3/4] gallium/u_threaded: implement set_context_param for thread pinning (v2)

2018-09-06 Thread Marek Olšák
From: Marek Olšák v2: - use set_context_param - set set_context_param even if the driver doesn't implement it --- .../auxiliary/util/u_threaded_context.c | 40 +++ .../auxiliary/util/u_threaded_context_calls.h | 1 + 2 files changed, 41 insertions(+) diff --git a/src

[Mesa-dev] [PATCH 4/4] radeonsi: pin the winsys thread to the requested L3 cache (v2)

2018-09-06 Thread Marek Olšák
From: Marek Olšák v2: rebase --- src/gallium/drivers/radeon/radeon_winsys.h| 8 src/gallium/drivers/radeonsi/si_pipe.c| 15 +++ src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 10 ++ src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 13

[Mesa-dev] [PATCH 2/4] st/mesa: pin driver threads to a specific L3 cache on AMD Zen (v2)

2018-09-06 Thread Marek Olšák
From: Marek Olšák v2: use set_context_param --- src/gallium/auxiliary/util/u_helpers.c | 42 +++ src/gallium/auxiliary/util/u_helpers.h | 4 ++ src/mesa/state_tracker/st_context.c| 3 ++ src/mesa/state_tracker/st_manager.c| 9 src/util/u_thread.h

[Mesa-dev] [PATCH 1/4] gallium: add pipe_context::set_context_param for tuning perf on AMD Zen (v2)

2018-09-06 Thread Marek Olšák
From: Marek Olšák State trackers will not use the new param directly, but will instead use a helper in MakeCurrent that does the right thing. v2: rework the interface --- .../auxiliary/driver_ddebug/dd_context.c | 11 ++ src/gallium/auxiliary/driver_noop/noop_pipe.c | 7

[Mesa-dev] [PATCH 0/4] Patches 5-8 rework: Gallium/RadeonSI for Ryzen CPUs

2018-09-06 Thread Marek Olšák
This changes the interface to pipe_context::set_context_param. Please review. Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/8] gallium: add pipe_context::pin_threads_to_L3_cache for AMD Zen

2018-09-06 Thread Marek Olšák
On Thu, Sep 6, 2018 at 2:37 PM, Brian Paul wrote: > On 09/05/2018 10:02 PM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> State trackers will not use this directly, but will instead use a helper >> in MakeCurrent that does the right thing. >> --- >&g

Re: [Mesa-dev] [PATCH] gallium: add PIPE_CAP_RASTERIZER_SUBPIXEL_BITS

2018-09-06 Thread Marek Olšák
On Thu, Sep 6, 2018 at 5:42 PM, Eric Anholt wrote: > Marek Olšák writes: > >> From: Marek Olšák > > Could you please work on providing explanatory text in your commit > messages? Something like: > > This fixes the default value of GL_SUBPIXEL_BITS, while leaving

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-06 Thread Marek Olšák
her. > > I fear if we begin to do the work manually, there won't be interest to do > that in the kernel, > and thus all applications will need to include such core pinning code to > have good performance when > multithreaded. > > Axel > > > On 9/6/18 9:21 PM, Marek Ol

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-06 Thread Marek Olšák
Actually, you make a good point about the kernel, but the kernel has no visibility into which threads need to be coupled together. So the kernel can't do anything. Marek On Thu, Sep 6, 2018 at 2:24 PM, Marek Olšák wrote: > I think you are missing the point. This series doesn't pin thre

Re: [Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-06 Thread Marek Olšák
ores. > > Yours, > > Axel Davy > > > On 9/6/18 6:02 AM, Marek Olšák wrote: >> >> Hi, >> >> When the Ryzen CPUs were launched, they didn't perform very well in >> games, and it took a while before games were patched. Guess what, >> Mesa drivers

Re: [Mesa-dev] [PATCH 3/4] gallium/u_inlines: improve pipe_reference_described perf for debug builds

2018-09-06 Thread Marek Olšák
On Thu, Sep 6, 2018 at 6:25 AM, Michel Dänzer wrote: > On 2018-09-05 11:49 p.m., Marek Olšák wrote: >> On Tue, Sep 4, 2018 at 2:35 PM, Marek Olšák wrote: >>> On Mon, Sep 3, 2018 at 6:08 AM, Michel Dänzer wrote: >>>> On 2018-09-01 8:54 a.m., Marek Olšák

[Mesa-dev] [PATCH] gallium: add PIPE_CAP_RASTERIZER_SUBPIXEL_BITS

2018-09-05 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_screen.c | 3 +++ src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/r600/r600_pipe.c | 1 + src/gallium/drivers/radeonsi/si_get.c | 1 + src/gallium/include/pipe/p_defines.h | 1 + src/mesa/state_tracker/st_extensions.c

Re: [Mesa-dev] [PATCH] gallium: Set the default GL_SUBPIXEL_BITS to 4.

2018-09-05 Thread Marek Olšák
Yeah I wanted to add the CAP but forgot. Marek On Wed, Sep 5, 2018 at 7:26 PM, Roland Scheidegger wrote: > I really think it makes no sense to hack some more around this. > > GLES (even 3.2) doesn't even support non-integer viewports. > As I mentioned before, it's incorrect to report more than

[Mesa-dev] [PATCH 6/8] st/mesa: pin driver threads to a specific L3 cache on AMD Zen CPUs

2018-09-05 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_helpers.c | 40 ++ src/gallium/auxiliary/util/u_helpers.h | 4 ++ src/mesa/state_tracker/st_context.c| 3 ++ src/mesa/state_tracker/st_manager.c| 9 src/util/u_thread.h| 57

[Mesa-dev] [PATCH 8/8] radeonsi: pin the winsys thread to the requested L3 cache

2018-09-05 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/radeon_winsys.h| 8 src/gallium/drivers/radeonsi/si_pipe.c| 8 src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 10 ++ src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 13 + 4

[Mesa-dev] [PATCH 5/8] gallium: add pipe_context::pin_threads_to_L3_cache for AMD Zen

2018-09-05 Thread Marek Olšák
From: Marek Olšák State trackers will not use this directly, but will instead use a helper in MakeCurrent that does the right thing. --- .../auxiliary/driver_ddebug/dd_context.c | 10 ++ src/gallium/auxiliary/driver_noop/noop_pipe.c | 6 ++ .../auxiliary/driver_trace

[Mesa-dev] [PATCH 7/8] gallium/u_threaded: implement pin_threads_to_L3_cache

2018-09-05 Thread Marek Olšák
From: Marek Olšák --- .../auxiliary/util/u_threaded_context.c | 23 +++ .../auxiliary/util/u_threaded_context.h | 1 + .../auxiliary/util/u_threaded_context_calls.h | 1 + 3 files changed, 25 insertions(+) diff --git a/src/gallium/auxiliary/util

[Mesa-dev] [PATCH 1/8] gallium/u_cpu_detect: fix a race condition on initialization

2018-09-05 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_cpu_detect.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/util/u_cpu_detect.c b/src/gallium/auxiliary/util/u_cpu_detect.c index 14003aa7692..93cf58011db 100644 --- a/src/gallium

[Mesa-dev] [PATCH 2/8] gallium/u_cpu_detect: fix parsing the CPU family

2018-09-05 Thread Marek Olšák
From: Marek Olšák According to: https://support.amd.com/TechDocs/54945_PPR_Family_17h_Models_00h-0Fh.pdf Also Intel: https://www.microbe.cz/docs/CPUID.pdf --- src/gallium/auxiliary/util/u_cpu_detect.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary

[Mesa-dev] [PATCH 0/8] Gallium & RadeonSI optimization for Ryzen CPUs

2018-09-05 Thread Marek Olšák
Hi, When the Ryzen CPUs were launched, they didn't perform very well in games, and it took a while before games were patched. Guess what, Mesa drivers have suffered from the same inefficincies until now. The AMD Zen architecture has multiple core complexes (CCX) where each CCX has e.g. 4C/8T and

[Mesa-dev] [PATCH 4/8] gallium/os_thread: simplify helper pipe_current_thread_get_time_nano

2018-09-05 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/os/os_thread.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/os/os_thread.h b/src/gallium/auxiliary/os/os_thread.h index f2629c5ffe5..322888b825f 100644 --- a/src/gallium/auxiliary/os/os_thread.h +++ b

[Mesa-dev] [PATCH 3/8] gallium/u_cpu_detect: get the number of cores per L3 cache for AMD Zen

2018-09-05 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_cpu_detect.c | 24 +++ src/gallium/auxiliary/util/u_cpu_detect.h | 1 + 2 files changed, 25 insertions(+) diff --git a/src/gallium/auxiliary/util/u_cpu_detect.c b/src/gallium/auxiliary/util/u_cpu_detect.c index

Re: [Mesa-dev] [PATCH] gallium: Set the default GL_SUBPIXEL_BITS to 4.

2018-09-05 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Sep 5, 2018 at 10:56 AM, Eric Anholt wrote: > This is the minimum value for GLES2, and 0 certainly wouldn't be valid. > Fixes dEQP-GLES2.functional.state_query.integers.subpixel_bits_getfloat > and friends. > --- > src/gallium/auxiliary/

Re: [Mesa-dev] [PATCH 3/4] gallium/u_inlines: improve pipe_reference_described perf for debug builds

2018-09-05 Thread Marek Olšák
On Tue, Sep 4, 2018 at 2:35 PM, Marek Olšák wrote: > On Mon, Sep 3, 2018 at 6:08 AM, Michel Dänzer wrote: >> On 2018-09-01 8:54 a.m., Marek Olšák wrote: >>> From: Marek Olšák >>> >>> +41% performance in debug builds >>> (testing piglit/drawoverhead

Re: [Mesa-dev] [Mesa-announce] [ANNOUNCE] mesa 18.2.0-rc5

2018-09-04 Thread Marek Olšák
format_properties. > > Jason Ekstrand (6): > 4ffb575da59 vulkan/alloc: Add a vk_strdup helper > 8c048af5890 anv: Copy the appliation info into the instance > c92a463d234 anv: Claim to support depthBounds for ID games > cdea5d996ed anv: Free the app and engine name >

Re: [Mesa-dev] [PATCH 2/3] radeonsi/nir: Set vs_inputs_dual_locations and let NIR do the remap

2018-09-04 Thread Marek Olšák
Acked-by: Marek Olšák Marek On Fri, Aug 31, 2018 at 11:11 PM, Jason Ekstrand wrote: > We were going out of our way to disable dual-location re-mapping in NIR > only to then do the remapping in st_glsl_to_nir.cpp. Presumably, this > was so that double_inputs would be correct for the c

Re: [Mesa-dev] [PATCH 3/4] gallium/u_inlines: improve pipe_reference_described perf for debug builds

2018-09-04 Thread Marek Olšák
On Mon, Sep 3, 2018 at 6:08 AM, Michel Dänzer wrote: > On 2018-09-01 8:54 a.m., Marek Olšák wrote: >> From: Marek Olšák >> >> +41% performance in debug builds >> (testing piglit/drawoverhead + u_threaded_context) > > Nice, but please include ministat outp

Re: [Mesa-dev] [PATCH 2/4] gallium/auxiliary: don't dereference counters twice needlessly

2018-09-04 Thread Marek Olšák
piglit/drawoverhead - DrawElements (no state changes) on radeonsi Marek On Mon, Sep 3, 2018 at 6:08 AM, Michel Dänzer wrote: > On 2018-09-01 8:54 a.m., Marek Olšák wrote: >> From: Marek Olšák >> >> +1.2% performance > > Please either state what you tested with,

Re: [Mesa-dev] [PATCH 1/4] glsl_to_tgsi: Fix potential leak

2018-09-04 Thread Marek Olšák
Thanks. I've pushed this and the u_vbuf patch. Marek On Thu, Aug 30, 2018 at 12:02 PM, Ernestas Kulik wrote: > Reported by Coverity: arr_live_ranges is freed in a different branch > than the one in which it was allocated. > > CID: 1438391 > Signed-off-by: Ernestas Kulik > --- >

Re: [Mesa-dev] [PATCH 2/4] u_vbuf: Fix leak

2018-09-04 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Aug 30, 2018 at 12:02 PM, Ernestas Kulik wrote: > Reported by Coverity: data is heap-allocated, but only freed in the > info->index_size != 0 branch. > > CID: 1438238 > Signed-off-by: Ernestas Kulik > --- > src/gallium/auxiliary/

Re: [Mesa-dev] [PATCH] mesa: ignore VAO IDs equal to 0 in glDeleteVertexArrays

2018-09-04 Thread Marek Olšák
cessary here > because this functionality works fine for zero indexes as is. > Please correct me if am wrong. > > Regards, > Andrii. > > On Fri, Aug 31, 2018 at 10:24 AM Ian Romanick wrote: >> >> On 08/30/2018 07:42 PM, Marek Olšák wrote: >> > Sadly, ther

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add radeonsi_zerovram driconfig option

2018-09-03 Thread Marek Olšák
On Mon, Sep 3, 2018 at 6:29 AM, Timothy Arceri wrote: > > > On 28/08/18 04:26, Marek Olšák wrote: >> >> On Fri, Aug 24, 2018 at 10:33 AM, Michel Dänzer >> wrote: >>> >>> On 2018-08-24 1:06 p.m., Timothy Arceri wrote: >>>> >>>&

[Mesa-dev] [PATCH] radeonsi: clear VRAM buffers on creation if zerovram is set

2018-09-03 Thread Marek Olšák
From: Marek Olšák This includes reused buffers. Prefer DCC clear if DCC is enabled. --- src/gallium/drivers/radeonsi/si_buffer.c | 8 src/gallium/drivers/radeonsi/si_pipe.c| 3 ++- src/gallium/drivers/radeonsi/si_texture.c | 5 - src/gallium/winsys/amdgpu/drm

Re: [Mesa-dev] [PATCH 5/7] gallium: add PIPE_CAP_MAX_COMBINED_HW_ATOMIC_COUNTER{S, _BUFFERS}

2018-09-03 Thread Marek Olšák
With my comments addressed, the first 5 patches are: Reviewed-by: Marek Olšák Marek On Mon, Sep 3, 2018 at 4:44 AM, Marek Olšák wrote: > Same answer as before - the screen.rst documentation is missing. > > Marek > > On Thu, Aug 30, 2018 at 9:40 AM, Erik Faye-Lund > wr

Re: [Mesa-dev] [PATCH 5/7] gallium: add PIPE_CAP_MAX_COMBINED_HW_ATOMIC_COUNTER{S, _BUFFERS}

2018-09-03 Thread Marek Olšák
Same answer as before - the screen.rst documentation is missing. Marek On Thu, Aug 30, 2018 at 9:40 AM, Erik Faye-Lund wrote: > This moves the evergreen-specific max-sizes out as a driver-cap, so > other drivers with less strict requirements also can use hw-atomics. > > Remove ssbo_atomic as

Re: [Mesa-dev] [PATCH 4/7] gallium: add PIPE_CAP_MAX_COMBINED_SHADER_BUFFERS

2018-09-02 Thread Marek Olšák
screen.rst is missing documentation for this cap. Marek On Thu, Aug 30, 2018 at 9:40 AM, Erik Faye-Lund wrote: > This gets rid of a r600 specific hack in the state-tracker, and prepares > for other drivers to be able to use hw-atomics. > > While we're at it, clean up some indentation in the

[Mesa-dev] [PATCH] gallium/u_threaded: increase batch size to increase performance

2018-09-01 Thread Marek Olšák
From: Marek Olšák This reduces mutex overhead. +4.4% performance with piglit/drawoverhead, DrawElements, Ryzen X1700 --- src/gallium/auxiliary/util/u_threaded_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_threaded_context.h b/src

[Mesa-dev] [PATCH 3/4] gallium/u_inlines: improve pipe_reference_described perf for debug builds

2018-09-01 Thread Marek Olšák
From: Marek Olšák +41% performance in debug builds (testing piglit/drawoverhead + u_threaded_context) --- src/gallium/auxiliary/util/u_inlines.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/gallium/auxiliary/util

[Mesa-dev] [PATCH 2/4] gallium/auxiliary: don't dereference counters twice needlessly

2018-09-01 Thread Marek Olšák
From: Marek Olšák +1.2% performance --- src/gallium/auxiliary/util/u_inlines.h | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/gallium/auxiliary/util/u_inlines.h index 7eb243779f7..19c6c7b75dd 100644 --- a/src

[Mesa-dev] [PATCH 4/4] gallium/u_inlines: remove the destroy variable in pipe_reference_described

2018-09-01 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_inlines.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/gallium/auxiliary/util/u_inlines.h index 815ac5c97ac..8f468c58e6a 100644 --- a/src/gallium/auxiliary/util

[Mesa-dev] [PATCH 1/4] gallium/u_inlines: normalize naming, use dst & src, style fixes

2018-09-01 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_inlines.h | 86 +- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/gallium/auxiliary/util/u_inlines.h index dee6f8f2d9e..7eb243779f7 100644 --- a/src/gallium

[Mesa-dev] [PATCH 1/2] gallium: add PIPE_CAP_MAX_TEXTURE_UPLOAD_MEMORY_BUDGET

2018-08-31 Thread Marek Olšák
From: Marek Olšák --- src/gallium/docs/source/screen.rst | 3 +++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_screen.c

[Mesa-dev] [PATCH 2/2] st/mesa: throttle texture uploads if their memory usage goes beyond a limit

2018-08-31 Thread Marek Olšák
From: Marek Olšák This prevents radeonsi from running out of memory. It also increases texture upload performance by being nice to the kernel memory manager. --- src/gallium/auxiliary/util/u_helpers.c | 120 + src/gallium/auxiliary/util/u_helpers.h | 17 src/mesa

<    5   6   7   8   9   10   11   12   13   14   >