Re: [Mesa-dev] [PATCH v5 00/10] new series of Mesa for Tizen

2017-11-15 19:32 GMT+09:00 Nicolai Hähnle <nhaeh...@gmail.com>: > Not sure if it's just my client, but all the nice ASCII art got messed up > unfortunately :/ > > On 14.11.2017 21:21, Mun,

Re: [Mesa-dev] [PATCH v5 00/10] new series of Mesa for Tizen

Hi all, I am sorry that I didn't have enough discussion about why new window system code is needed for Tizen on mesa. This is a brief architecture of Tizen Window System. +--+ |

Re: [Mesa-dev] [PATCH v2 6/8] egl: add dri2_egl_surface_destroy_image_front() helper (v2)

Hi Gurchetan, 2017-10-18 6:02 GMT+09:00 Gurchetan Singh : > dri2_egl_surface_destroy_image_front and dri2_egl_surface_destroy_image_back > are almost identical. Why don't you just create a > dri2_surface_free_image(struct dri2_egl_surface *dri2_surf, __DRIimage >

Re: [Mesa-dev] [PATCH v2 1/8] egl: add dri2_egl_surface_free_outdated_buffers_and_update_size() helper (v2)

Hi Emil and Gurchetan, Thank you for reviewing the patches. 2017-10-20 6:18 GMT+09:00 Gurchetan Singh : > De-duplicating and then trimming down works for me. > > On Thu, Oct 19, 2017 at 3:31 AM, Emil Velikov > wrote: >> >> On 18 October

Re: [Mesa-dev] [PATCH v2 0/9] Introduce supporting of Tizen to mesa's egl platform

Hi, Emil Thank you for reviewing patches in detail. > A couple of high level questions: > - there seems to be no EGL platform extension for Tizen > Pretty much every serious platform has one + most even made it as part > of EGL 1.5* As you mentioned, (as far as I know) for now, Tizen Platform

Re: [Mesa-dev] [PATCH] genxml: Remove a redundant identical code for different branches

2017 8:16:42 PM "Mun, Gwan-gyeong" <elong...@gmail.com> wrote: > >> Hi Jason, >> You are right, as you commented, compilers can eliminate these >> redundancies >> easy. >> However I think we don't need to generate redundant codes. > > > The

Re: [Mesa-dev] [PATCH] genxml: Remove a redundant identical code for different branches

gt; > branches. > > > > static inline uint32_t ATTRIBUTE_PURE > > RENDER_SURFACE_STATE_RedClearColor_start(const struct gen_device_info > *devinfo) > > { > >switch (devinfo->gen) { > >case 10: return 384; > >case 9: return 384; > >c

Re: [Mesa-dev] [PATCH] gbm: avoid null pointer dereference

Thanks Daniel for a detailed explain with link, that was totally my misunderstood. ignore this patch ^^. 2017-07-17 23:20 GMT+09:00 Daniel Stone : > Hi, > > On 17 July 2017 at 15:02, Gwan-gyeong Mun wrote: >> gbm_dri_surface_create() might create

Re: [Mesa-dev] [PATCH 1/2] egl_dri2: Add support for Tizen

Hi Emil, Thanks for review my patch, 2017-04-26 0:58 GMT+09:00 Daniel Stone : > Hi, > > On 25 April 2017 at 17:03, Emil Velikov wrote: >> From a quick look most of this code is copy/pasted from platform_wayland.c. >> >> At the same time, large

[Mesa-dev] [PATCH 1/2] egl_dri2: Add support for Tizen

From: "Mun, Gwan-gyeong" <kk.m...@samsung.com> Add platform_tizen.c that supports _EGL_PLATFORM_TIZEN. It works with libtpl-egl (Tizen Porting Layer for egl), libtbm(Tizen Buffer Manager) where back buffers of windows are backed by GEM objects. In Tizen a native wi

[Mesa-dev] [PATCH 2/2] configure.ac: Add tizen to supported egl platforms

From: "Mun, Gwan-gyeong" <kk.m...@samsung.com> It checks tpl-egl/libtbm/libtdm packages and defines HAVE_EGL_PLATFORM_TIZEN. This feature is enabled by the config option '--with-egl-platforms=tizen' Signed-off-by: Mun Gwan-gyeong <kk.m...@samsung.com> --- configure.ac | 5

[Mesa-dev] [PATCH 0/2] Introduce supporting of Tizen to mesa's egl platform

/Readme_RPI3_Setup_for_Tizen https://github.com/elongbug/mesa/blob/tizen_work/Readme_for_Tizen https://github.com/elongbug/mesa/blob/tizen_work/Tizen_Binary_Download_Instructions_for_RPI3 Mun, Gwan-gyeong (2): egl_dri2: Add support for Tizen configure.ac: Add tizen to supported egl platforms

[Mesa-dev] [PATCH 0/2] Introduce supporting of Tizen to mesa's egl platform

/Readme_RPI3_Setup_for_Tizen https://github.com/elongbug/mesa/blob/tizen_work/Readme_for_Tizen https://github.com/elongbug/mesa/blob/tizen_work/Tizen_Binary_Download_Instructions_for_RPI3 Mun, Gwan-gyeong (2): egl_dri2: Add support for Tizen configure.ac: Add tizen to supported egl platforms

[Mesa-dev] [PATCH v3 4/5] anv: Add missing error-checking to anv_CreateDevice (v3)

on allocation failure path v3: Fixes from Emil Velikov's review Add missing destructor for queue and scratch_pool on allocation failure path Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> --- src/intel/vulkan/anv_device.c | 65 +-- 1 file chang

[Mesa-dev] [PATCH v2 4/5] anv: Add missing error-checking to anv_CreateDevice (v2)

on allocation failure path Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> --- src/intel/vulkan/anv_device.c | 63 --- 1 file changed, 54 insertions(+), 9 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 0

[Mesa-dev] [PATCH] vulkan/wsi: Fix resource leak in success path of wsi_queue_init()

It fixes leakage of pthread_condattr resource on wsi_queue_init() Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> --- src/vulkan/wsi/wsi_common_queue.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vulkan/wsi/wsi_common_queue.h b/src/vulkan/wsi/wsi_common_queue.h index 0

[Mesa-dev] [PATCH 3/5] radv: drop the return type for radv_queue_init()

radv_queue_init() always returns VK_SUCCESS, so caller does not need to check return value of radv_queue_init(). Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> --- src/amd/vulkan/radv_device.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/amd/

[Mesa-dev] [PATCH 4/5] anv: Add missing error-checking to anv_CreateDevice

This patch adds missing error-checking and fixes resource leak in allocation failure path on anv_CreateDevice() Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> --- src/intel/vulkan/anv_device.c | 59 --- 1 file changed, 50 insertions(+), 9 del

[Mesa-dev] [PATCH 5/5] anv: Update the teardown in reverse order of the anv_CreateDevice

This updates releasing of resource in reverse order of the anv_CreateDevice to anv_DestroyDevice. And it fixes resource leak in pthread_mutex, pthread_cond, anv_gem_context. Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> --- src/intel/vulkan/anv_device.c | 23 ++-

[Mesa-dev] [PATCH 2/5] anv: drop the return type for anv_queue_init()

anv_queue_init() always returns VK_SUCCESS, so caller does not need to check return value of anv_queue_init(). Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> --- src/intel/vulkan/anv_device.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/intel/

[Mesa-dev] [PATCH 1/5] anv: Add missing error-checking to anv_block_pool_init (v2)

for propagating the return value to caller. b) Changed anv_block_pool_init() to return VK_ERROR_INITIALIZATION_FAILED on failure of initialization. Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> --- src/intel/vulkan/anv_allocator.c | 27 +-- src/intel/

[Mesa-dev] [PATCH] docs: get rid of duplicated description from sourcetree.html

Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> --- docs/sourcetree.html | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/sourcetree.html b/docs/sourcetree.html index aee3321..7013f65 100644 --- a/docs/sourcetree.html +++ b/docs/sourcetree.html @@ -140,7 +140,6 @@ each dir

[Mesa-dev] [PATCH v2] util/disk_cache: close a previously opened handle in disk_cache_put (v2)

We're missing the close() to the matching open(). CID 1373407 v2: Fixes from Emil Velikov's review Update the teardown in reverse order of the setup/init. Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> --- src/util/disk_cache.c | 11 +-- 1 file changed, 5 insertions

[Mesa-dev] [PATCH v2] radeonsi: Add missing error-checking to si_create_compute_state (v2)

pload() < 0" b) Update commit message. Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> --- src/gallium/drivers/radeonsi/si_compute.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi

Re: [Mesa-dev] [PATCH] intel: aubinator: Fix resource leak in gen_spec_load_from_path

t; Thanks! > > Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> > > > On 20/11/16 07:07, Mun Gwan-gyeong wrote: >> >> This fixes resource leak in gen_spec_load_from_path XML_ParserCreate >> failure path >> >> CID 1373564 >> >> S

Re: [Mesa-dev] [PATCH] radeonsi: Fix resource leak in gs_copy_shader allocation failure path

com>: > Reviewed-by: Nicolai Hähnle <nicolai.haeh...@amd.com> > > > On 20.11.2016 05:19, Mun Gwan-gyeong wrote: >> >> CID 1394028 >> >> Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> >> --- >> src/gallium/drivers/radeonsi/si_sha

Re: [Mesa-dev] [PATCH] anv: Add missing error-checking to anv_block_pool_init

nayan26deshm...@gmail.com> > > On Sun, Nov 20, 2016 at 4:41 PM, Mun Gwan-gyeong <elong...@gmail.com> wrote: >> When the allocation fails on u_vector_init(), it returns 0 >> This fixes u_vector_init failure path on anv_block_pool_init >> >> CID 1394319 >&

Re: [Mesa-dev] [PATCH] vc4: Fix resource leak

Thanks for reviewing and pushing! 2016-11-18 11:55 GMT+09:00 Eric Anholt <e...@anholt.net>: > Mun Gwan-gyeong <elong...@gmail.com> writes: > >> Add missed free() >> >> CID 1394322 >> >> Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> &g

[Mesa-dev] [PATCH] radeonsi: Add missing error-checking to si_create_compute_state

When the uploading of shader fails on si_shader_binary_upload(), it returns -ENOMEM. We handles si_shader_binary_upload() failure path on si_create_compute_state(). CID 1394027 Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> --- src/gallium/drivers/radeonsi/si_compute.c | 6 +-

[Mesa-dev] [PATCH] util/disk_cache: close a previously opened handle in disk_cache_put

We're missing the close() to the matching open(). CID 1373407 Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> --- src/util/disk_cache.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index 4287878..5ceb3aa

[Mesa-dev] [PATCH] anv: Fix unintentional integer overflow in anv_CreateDmaBufImageINTEL

pCreateInfo->strideInBytes * pCreateInfo->extent.height with type "unsigned int" is evaluated using 32-bit arithmetic. This fixes unintentional integer overflow by casting to uint64_t before multifying. CID 1394321 Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com>

[Mesa-dev] [PATCH] anv: Add missing error-checking to anv_block_pool_init

When the allocation fails on u_vector_init(), it returns 0 This fixes u_vector_init failure path on anv_block_pool_init CID 1394319 Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> --- src/intel/vulkan/anv_allocator.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH] intel: aubinator: Fix resource leak in gen_spec_load_from_path

This fixes resource leak in gen_spec_load_from_path XML_ParserCreate failure path CID 1373564 Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> --- src/intel/tools/decoder.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/tools/decoder.c b/src/intel/tools/decoder.c index 6

[Mesa-dev] [PATCH] radeonsi: Fix resource leak in gs_copy_shader allocation failure path

CID 1394028 Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> --- src/gallium/drivers/radeonsi/si_shader.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 917e148..6

[Mesa-dev] [PATCH] vc4: Fix resource leak

Add missed free() CID 1394322 Signed-off-by: Mun Gwan-gyeong <elong...@gmail.com> --- src/gallium/drivers/vc4/vc4_register_allocate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/vc4/vc4_register_allocate.c b/src/gallium/drivers/vc4/vc4_register_allocate.c