[Mesa-dev] [PATCH 3/6] gallium/u_blitter: split out a helper for common clear state

Signed-off-by: Rob Clark <robdcl...@gmail.com> --- src/gallium/auxiliary/util/u_blitter.c | 38 ++ src/gallium/auxiliary/util/u_blitter.h | 5 + 2 files changed, 30 insertions(+), 13 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c

[Mesa-dev] [PATCH 4/6] freedreno: support for using generic clear path

Since clears are more or less just normal draws, there isn't that much benefit in having hand-rolled clear path. Add support to use u_blitter instead if gen specific backend doesn't implement ctx->clear(). Signed-off-by: Rob Clark <robdcl...@gmail.com> --- src/gallium/drivers/

[Mesa-dev] [PATCH 0/6] Custom u_blitter clear

ric u_blitter path). So I end up re-using u_blitter's state restore and some of the common clear state setup, but doing the VBO/shader/etc state setup myself in terms of the pipe_context API (so that it is generation independent). Rob Clark (6): gallium/u_blitter: export some functions gall

[Mesa-dev] [PATCH 2/6] gallium/u_blitter: add helper to save FS const buffer state

Not (currently) state that is overwridden by u_blitter itself, but drivers with custom blit/clear which are reusing part of the u_blitter infrastructure will use it. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- src/gallium/auxiliary/util/u_blitter.c | 10 ++ src/gallium/aux

[Mesa-dev] [PATCH 1/6] gallium/u_blitter: export some functions

Signed-off-by: Rob Clark <robdcl...@gmail.com> --- src/gallium/auxiliary/util/u_blitter.c | 145 + src/gallium/auxiliary/util/u_blitter.h | 9 ++ 2 files changed, 84 insertions(+), 70 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c

Re: [Mesa-dev] cairo as state tracker

On Tue, Aug 9, 2016 at 11:11 AM, Enrico Weigelt, metux IT consult wrote: > On 07.08.2016 12:50, Marek Olšák wrote: > >> It would mainly be a futile task if it had to compete with their >> official Mesa driver. > > Not quite. Would give us all of gallium's capabilities

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

On Tue, Aug 9, 2016 at 9:47 AM, Nicolai Hähnle wrote: > Hi everybody, > > addrlib is the addressing and alignment calculator which is used by > radeonsi. It's developed (and also used) internally at AMD, and so far we've > had one open source copy living in the Mesa repository

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

how strict are we on that actually? I think whenever we add new gl entry points (ie. implementing new extension, etc) we kinda sorta break ABI, don't we? I thought mixing/matching libGL vs *_dri.so was at least not recommended.. BR, -R On Mon, Aug 8, 2016 at 12:22 PM, Ian Romanick

Re: [Mesa-dev] [PATCH 1/3] gallium: add a pipe_context parameter to fence_finish

On Sat, Aug 6, 2016 at 11:32 AM, Marek Olšák wrote: > From: Marek Olšák > > required by glClientWaitSync (GL 4.5 Core spec) that can optionally flush > the context Thanks, I've been meaning to add the same thing but haven't had time to work on the native

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: fix comparison out of range warnings

Thanks.. my expectation is that ~0 gets cast to the same enum on both sides of the != so I *think* we should be good. BR, -R On Sat, Aug 6, 2016 at 9:05 AM, Francesco Ansanelli wrote: > Hello, > > I did more tests... and I didn't experience any error. > I attach last

Re: [Mesa-dev] [PATCH] src: replace RTLD_NOW with RTLD_LAZY

On Sat, Aug 6, 2016 at 4:28 AM, Enrico Weigelt, metux IT consult wrote: > On 06.08.2016 04:05, ⚛ wrote: > >> Question 2: Exists there a reason for _not_ linking radeonsi_dri.so, >> swrastg_dri.so, etc, directly to Mesa's libGL.so? The Gallium >> *_dri.so libraries are the

Re: [Mesa-dev] [PATCH] src: replace RTLD_NOW with RTLD_LAZY

On Sat, Aug 6, 2016 at 3:01 AM, Eric Anholt <e...@anholt.net> wrote: > Rob Clark <robdcl...@gmail.com> writes: > >> On Fri, Aug 5, 2016 at 8:42 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: >>> Mesa source code prior to this patch uses both RTLD_NOW an

Re: [Mesa-dev] [PATCH] src: replace RTLD_NOW with RTLD_LAZY

On Fri, Aug 5, 2016 at 8:42 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: > Mesa source code prior to this patch uses both RTLD_NOW and RTLD_LAZY. > This patch removes all RTLD_NOW in favor of RTLD_LAZY. > > In comparison to early binding, lazy binding reduces CPU instruction count > of small GL

Re: [Mesa-dev] dead code

On Wed, Aug 3, 2016 at 2:48 PM, Rob Clark <robdcl...@gmail.com> wrote: > On Wed, Aug 3, 2016 at 2:18 PM, Enrico Weigelt, metux IT consult > <enrico.weig...@gr13.net> wrote: >> On 03.08.2016 13:25, Rob Clark wrote: >> >>> Probably it would be on a case-by-ca

Re: [Mesa-dev] dead code

On Wed, Aug 3, 2016 at 2:18 PM, Enrico Weigelt, metux IT consult <enrico.weig...@gr13.net> wrote: > On 03.08.2016 13:25, Rob Clark wrote: > >> Probably it would be on a case-by-case basis. There are at least a >> few places with some useful debug code, ie. not the kin

Re: [Mesa-dev] dead code

On Wed, Aug 3, 2016 at 5:00 AM, Enrico Weigelt, metux IT consult wrote: > Hi folks, > > > I've seen quite a lot of #if 0's - looks like dead code. > Should we remove that ? > Probably it would be on a case-by-case basis. There are at least a few places with some useful

Re: [Mesa-dev] [PATCH] ttn: Make FRAG_RESULT_DEPTH be a float variable to match gtn and ptn.

On Mon, Aug 1, 2016 at 1:45 PM, Eric Anholt wrote: > This lets TTN-using drivers handle FRAG_RESULT_DEPTH the same between all > their source paths. lgtm.. and nice to lose an extra tgsi hack ;-) r-b > --- > src/gallium/auxiliary/nir/tgsi_to_nir.c | 19

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: fix comparison out of range warnings

On Mon, Aug 1, 2016 at 8:10 AM, Eric Engestrom wrote: > On Sat, Jul 30, 2016 at 09:49:57AM +0200, Francesco Ansanelli wrote: >> Signed-off-by: Francesco Ansanelli >> --- >> src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 >> 1 file

Re: [Mesa-dev] virglrenderer regression in commit ad4f0f1941677c

On Mon, Aug 1, 2016 at 1:30 AM, Marc-André Lureau wrote: > > Hi > > - Original Message - >> On Fri, Jul 29, 2016 at 3:57 PM, Rob Herring wrote: >> > Hi, >> > >> > This commit in virglrenderer causes a regression in Android for me. >> > The parameters

[Mesa-dev] [PATCH] u_vbuf: fix potentially bogus assert

crash with debug build of mesa in: dEQP-GLES3.functional.vertex_arrays.single_attribute.strides.fixed.user_ptr_stride17_components2_quads1 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95000 Signed-off-by: Rob Clark <robdcl...@gmail.com> --- src/gallium/auxiliary/util/u_vbuf.c | 6 +++

Re: [Mesa-dev] virglrenderer regression in commit ad4f0f1941677c

On Fri, Jul 29, 2016 at 3:57 PM, Rob Herring wrote: > Hi, > > This commit in virglrenderer causes a regression in Android for me. > The parameters that get passed in are last_level = 8, width = 1. I'm > not really sure if this is valid (I'm guessing there should be some > min

Re: [Mesa-dev] [PATCH mesa] gallium/freedreno: move cast to avoid integer overflow

On Fri, Jul 29, 2016 at 8:33 PM, Eric Engestrom wrote: > Previously, the bitshift would be performed on a simple int (32 bits on > most systems), overflow, and then be cast to 64 bits. and actually 32b on 100% of systems that had a2xx ;-) I've picked this up locally and will

Re: [Mesa-dev] [PATCH mesa] freedreno/a2xx: add missing `break` after error message

hmm, these were actually intended to fall-thru to the 'x' case, just to give the hw something sensible. (Not that it is a case that should ever happen.) Maybe better to use unreachable()? BR, -R On Fri, Jul 29, 2016 at 8:27 PM, Eric Engestrom wrote: > CovID: 1362455,

Re: [Mesa-dev] [PATCH mesa] freedreno/a2xx: remove duplicate assignment

thanks, applied locally and will push in next day or two.. BR, -R On Fri, Jul 29, 2016 at 8:23 PM, Eric Engestrom wrote: > CovID: 1362445, 1362446 > Signed-off-by: Eric Engestrom > --- > src/gallium/drivers/freedreno/a2xx/ir-a2xx.h | 4 ++-- > 1 file

Re: [Mesa-dev] [PATCH] glsl: fix uninitialized instance variable

thanks, pushed On Fri, Jul 29, 2016 at 7:56 AM, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: > Valgrind detected that variable ir_copy_propagation_visitor::killed_all > is uninitialized. > > Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> > --- >

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

a patch. > > > 2016-07-29 1:53 GMT+02:00 Rob Clark <robdcl...@gmail.com>: >> >> On Thu, Jul 28, 2016 at 6:44 PM, Rob Herring <r...@kernel.org> wrote: >> > On Thu, Jul 28, 2016 at 1:07 PM, Rob Clark <robdcl...@gmail.com> wrote: >> >> tbh

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

On Thu, Jul 28, 2016 at 6:36 PM, Rob Herring wrote: > On Thu, Jun 30, 2016 at 12:16 PM, Francesco Ansanelli > wrote: >> --- >> src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

On Thu, Jul 28, 2016 at 6:44 PM, Rob Herring <r...@kernel.org> wrote: > On Thu, Jul 28, 2016 at 1:07 PM, Rob Clark <robdcl...@gmail.com> wrote: >> tbh, I haven't used anything as ancient as 4.6 in a while.. these days >> I'm using 6.1 and even with 5.x I don't r

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

r > initialization for ‘key.vsaturate_s’) [-Wmissing-field-initializers] > > With my latest suggestion no warnings on that row, neither from clang: > > Ubuntu clang version 3.4-1ubuntu3~precise2 (tags/RELEASE_34/final) (based on > LLVM 3.4) > > Up to you how to proceed..

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

On Thu, Jul 28, 2016 at 6:31 AM, Emil Velikov wrote: > On 28 July 2016 at 09:21, Eric Engestrom wrote: >> On Wed, Jul 27, 2016 at 07:37:56PM +0200, Francesco Ansanelli wrote: >>> Hello, >>> >>> unluckily this didn't fix the warning... >>> I've

Re: [Mesa-dev] [PATCH 3/9] st/mesa: completely rewrite state atoms

On Mon, Jul 25, 2016 at 1:19 PM, Marek Olšák <mar...@gmail.com> wrote: > On Mon, Jul 25, 2016 at 5:42 PM, Rob Clark <robdcl...@gmail.com> wrote: >> On Mon, Jul 25, 2016 at 11:16 AM, Brian Paul <bri...@vmware.com> wrote: >>> On 07/18/2016 07:11 AM, Marek Olšák

Re: [Mesa-dev] [PATCH v2] vc4: add hash table look-up for exported dmabufs

On Mon, Jul 25, 2016 at 8:47 PM, Eric Anholt wrote: > Rob Herring writes: > >> It is necessary to reuse existing BOs when dmabufs are imported. There >> are 2 cases that need to be handled. dmabufs can be created/exported and >> imported by the same process and

Re: [Mesa-dev] [PATCH 3/9] st/mesa: completely rewrite state atoms

On Mon, Jul 25, 2016 at 11:16 AM, Brian Paul wrote: > On 07/18/2016 07:11 AM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> The goal is to do this in st_validate_state: >> while (dirty) >>atoms[u_bit_scan()]->update(st); >> >> That implies

Re: [Mesa-dev] [PATCH 00/56] Die copy-and-paste code, die

On Tue, Jul 19, 2016 at 3:24 PM, Ian Romanick wrote: > After seeing Dave's series to add support GL_ARB_shader_gpu_int64 and > thinking about adding support for 8- and 16-bit integers, I decided > that something had to be done about the cut-and-paste madness that is >

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

On Fri, Jul 22, 2016 at 4:39 AM, Vedran Miletić <ved...@miletic.net> wrote: > On 07/22/2016 03:37 AM, Rob Clark wrote: >> >> On Thu, Jul 21, 2016 at 9:35 PM, Rob Clark <robdcl...@gmail.com> wrote: >>> >>> On Thu, Jul 21, 2016 at 1:48 PM,

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

On Thu, Jul 21, 2016 at 9:35 PM, Rob Clark <robdcl...@gmail.com> wrote: > On Thu, Jul 21, 2016 at 1:48 PM, Vedran Miletić <ved...@miletic.net> wrote: >> LLVM and Mesa both define the DEBUG macro in incompatible ways. As a >> general practice, we should avoid us

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

On Thu, Jul 21, 2016 at 1:48 PM, Vedran Miletić wrote: > LLVM and Mesa both define the DEBUG macro in incompatible ways. As a > general practice, we should avoid using such generic names when it is > possible to do so. > > This patch renames all occurrences of the DEBUG macro

Re: [Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

On Thu, Jul 21, 2016 at 6:07 PM, Stéphane Marchesin <stephane.marche...@gmail.com> wrote: > On Tue, Jul 19, 2016 at 6:36 AM, Rob Clark <robdcl...@gmail.com> wrote: >> On Tue, Jul 19, 2016 at 6:54 AM, Emil Velikov <emil.l.veli...@gmail.com> >> wrote: >>>

[Mesa-dev] [PATCH] os: add pipe_mutex_assert_locked()

Would be nice if we could also have lockdep, like in the linux kernel. But this is better than nothing. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- src/gallium/auxiliary/os/os_thread.h | 16 1 file changed, 16 insertions(+) diff --git a/src/gallium/auxili

Re: [Mesa-dev] [PATCH] anv: add function to get prime buffer from memory+image

On Wed, Jul 20, 2016 at 7:51 AM, Daniel Stone wrote: > On 20 July 2016 at 13:47, Daniel Stone wrote: >> On 19 July 2016 at 20:47, Jonathan wrote: >>> +typedef VkResult (VKAPI_PTR *PFN_vkGetDmaBufINTEL)(VkDevice device, >>>

Re: [Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

On Tue, Jul 19, 2016 at 11:40 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 19 July 2016 at 14:36, Rob Clark <robdcl...@gmail.com> wrote: >> On Tue, Jul 19, 2016 at 6:54 AM, Emil Velikov <emil.l.veli...@gmail.com> >> wrote: >>> On 19 July 2016

Re: [Mesa-dev] [PATCH 3/9] st/mesa: completely rewrite state atoms

() On Mon, Jul 18, 2016 at 9:11 AM, Marek Olšák wrote: > From: Marek Olšák > > The goal is to do this in st_validate_state: >while (dirty) > atoms[u_bit_scan()]->update(st); > > That implies that atoms can't specify which flags they consume. >

Re: [Mesa-dev] [PATCH 07/10] egl/android: Make drm_gralloc headers optional

On Tue, Jul 19, 2016 at 6:54 AM, Emil Velikov wrote: > On 19 July 2016 at 04:21, Tomasz Figa wrote: >> On Tue, Jul 19, 2016 at 2:35 AM, Emil Velikov >> wrote: >>> On 18 July 2016 at 16:38, Tomasz Figa

Re: [Mesa-dev] [RFC] gallium/u_queue: add barrier function

t most, I suggest you keep > N+1 fences around (a ring of fences) that you reuse for new jobs and > keep a pointer to the most-recently-used fence. That way you know > which fence you need to wait on to make the whole queue idle. > > Marek > > On Mon, Jul 18, 2016 at 10:25

Re: [Mesa-dev] [RFC] gallium/u_queue: add barrier function

On Mon, Jul 18, 2016 at 4:34 PM, Nicolai Hähnle <nhaeh...@gmail.com> wrote: > On 18.07.2016 22:25, Rob Clark wrote: >> >> Helper to block until all previous jobs are complete. >> --- >> So I think this might end up being useful to me in some cases.. but

[Mesa-dev] [RFC] gallium/u_queue: add barrier function

Helper to block until all previous jobs are complete. --- So I think this might end up being useful to me in some cases.. but the implementation only works for a single threaded queue (which is all I need). I could also just put a helper in my driver code. Opinions?

Re: [Mesa-dev] [RFC mesa] Introduce .editorconfig

On Sun, Jul 17, 2016 at 7:46 PM, Eric Engestrom wrote: > diff --git a/src/gallium/drivers/freedreno/.editorconfig > b/src/gallium/drivers/freedreno/.editorconfig > new file mode 100644 > index 000..cc8e11f > --- /dev/null > +++ b/src/gallium/drivers/freedreno/.editorconfig

Re: [Mesa-dev] [PATCH 1/2] gallium: add PIPE_FLUSH_DEFERRED

On Mon, Jul 18, 2016 at 9:24 AM, Marek Olšák <mar...@gmail.com> wrote: > On Mon, Jul 18, 2016 at 2:25 PM, Rob Clark <robdcl...@gmail.com> wrote: >> On Mon, Jul 18, 2016 at 8:16 AM, Marek Olšák <mar...@gmail.com> wrote: >>> From: Marek Olšák <marek.

Re: [Mesa-dev] [PATCH 1/2] gallium: add PIPE_FLUSH_DEFERRED

On Mon, Jul 18, 2016 at 8:16 AM, Marek Olšák wrote: > From: Marek Olšák > > There are 2 uses: > - Asynchronous flushing for multithreaded drivers. > - Return a fence without flushing (mid-command-buffer fence). The driver > can defer flushing until

Re: [Mesa-dev] [PATCH 00/12] render reordering for optimized tile buffer usage

On Fri, Jul 8, 2016 at 12:14 PM, Rob Clark <robdcl...@gmail.com> wrote: > One of the annoying things, since pipe_resource is per-screen, not > per-context, I end up having to push batch_cache down into screen. > Which means that, for example, one context switching fb state could &

Re: [Mesa-dev] [PATCH] mesa/st: reduce size of state->st bitmask

On Thu, Jul 14, 2016 at 4:41 PM, Gustaw Smolarczyk <wielkie...@gmail.com> wrote: > 2016-07-14 22:14 GMT+02:00 Rob Clark <robdcl...@gmail.com>: >> In d035d50 this changed to 64b.. which I'm pretty sure was >> unintentional. Revert it back to 32b so the entire state st

[Mesa-dev] [PATCH] mesa/st: reduce size of state->st bitmask

In d035d50 this changed to 64b.. which I'm pretty sure was unintentional. Revert it back to 32b so the entire state struct is a nice round 64b (cache-line size). (Note sure that it would actually be measurable, but I did notice that check_state() was hot in some benchmarks.) Signed-off-by: Rob

[Mesa-dev] [PATCH] gallium/u_queue: add optional cleanup callback

destroyed before it is signaled. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- v2: drop the util_queue_add_job2() and just fixup existing callers src/gallium/auxiliary/util/u_queue.c| 6 +- src/gallium/auxiliary/util/u_queue.h| 6 +- src/gallium/drivers/ra

Re: [Mesa-dev] mesa from git fails to compile

On Thu, Jul 14, 2016 at 10:41 AM, Eric Engestrom wrote: > On Thu, Jul 14, 2016 at 12:24:32PM +0200, Pali Rohár wrote: >> Any news? Or possible fix? > > Have you tried Emil's suggestion, ie. upgrading to at least 0.8.0? > > Build system wizards: > Any way to check the

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

I've pushed 'em, thx On Wed, Jul 13, 2016 at 1:03 PM, Francesco Ansanelli wrote: > Yes, please. > > Cheers, > Francesco ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

On Thu, Jun 30, 2016 at 1:16 PM, Francesco Ansanelli wrote: > this looks like the right thing to do.. r-b for the series. Do you need me to push? BR, -R > --- > src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 > 1 file changed, 4 insertions(+), 4

[Mesa-dev] [PATCH] gallium/u_queue: add optional cleanup callback

destroyed before it is signaled. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- Maybe adding util_queue_add_job2() is a bit overkill.. although I think Marek has some in-flight stuff using u_queue, so maybe this approach is less conflicty? src/gallium/auxiliary/util/u_queue.

Re: [Mesa-dev] [PATCH 04/13] todo! dri: Questions about fence fd ownership

On Fri, Jul 8, 2016 at 8:00 PM, Chad Versace wrote: > See the comments. > --- > include/GL/internal/dri_interface.h | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/include/GL/internal/dri_interface.h > b/include/GL/internal/dri_interface.h > index

Re: [Mesa-dev] [PATCH 00/12] render reordering for optimized tile buffer usage

On Sat, Jul 2, 2016 at 12:52 PM, Rob Clark <robdcl...@gmail.com> wrote: > So, games/apps that are aware of how a tiler gpu works will make an > effort to avoid mid-batch (tile pass) updates to textures, UBOs, etc, > since this will force a flush, and extra resolve (tile->mem)

Re: [Mesa-dev] Mesa 12.0.0 release candidate 4

On Thu, Jun 23, 2016 at 9:35 AM, Emil Velikov wrote: > Hi all, > > On 21 June 2016 at 15:35, Emil Velikov wrote: >> The fourth release candidate for Mesa 12.0.0 is now available. >> >> Note: this is the final release candidate, with Mesa 12.0.0

Re: [Mesa-dev] [PATCH 00/12] render reordering for optimized tile buffer usage

On Sat, Jul 2, 2016 at 12:52 PM, Rob Clark <robdcl...@gmail.com> wrote: > So, games/apps that are aware of how a tiler gpu works will make an > effort to avoid mid-batch (tile pass) updates to textures, UBOs, etc, > since this will force a flush, and extra resolve (tile->mem)

Re: [Mesa-dev] [PATCH] vbo: fix attr reset

On Wed, Jul 6, 2016 at 9:53 AM, Brian Paul <bri...@vmware.com> wrote: > On 07/05/2016 08:57 PM, Mathias Fröhlich wrote: >> >> On Tuesday, July 05, 2016 15:47:45 Rob Clark wrote: >> >> > In bc4e0c4 (vbo: Use a bitmask to track the active arrays in >> vb

[Mesa-dev] [PATCH] vbo: fix attr reset

that vbo_exec_bind_arrays() can re-use it to reset POS. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- src/mesa/vbo/vbo_exec.h | 1 + src/mesa/vbo/vbo_exec_api.c | 14 -- src/mesa/vbo/vbo_exec_draw.c | 2 +- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/me

Re: [Mesa-dev] [PATCH 28/29] vbo: Use a bitmask to track the active arrays in vbo_exec*.

= 0; + exec->vtx.active_sz[0] = 0; exec->vtx.enabled &= (~BITFIELD64_BIT(VBO_ATTRIB_POS)); exec->vtx.enabled |= BITFIELD64_BIT(VBO_ATTRIB_GENERIC0); } --- will fix it... BR, -R On Tue, Jul 5, 2016 at 2:56 PM, Rob Clark <robdcl...@

Re: [Mesa-dev] [PATCH 28/29] vbo: Use a bitmask to track the active arrays in vbo_exec*.

So, this is a bit sad, but this breaks things for 0ad.. and maybe others. I have an api-trace: https://people.freedesktop.org/~robclark/0ad-cycladic-archipelago.trace.xz The problem is the interaction with the VERT_ATTRIB_POS / VERT_ATTRIB_GENERIC0 switcharoo in vbo_exec_bind_arrays(),

[Mesa-dev] [PATCH 09/12] freedreno: batch re-ordering support

For now, not enabled by default, but can be enabled (on a3xx/a4xx) with FD_MESA_DEBUG=reorder. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- src/gallium/drivers/freedreno/freedreno_batch.c| 168 ++--- src/gallium/drivers/freedreno/freedreno_batch.h| 1

[Mesa-dev] [PATCH 07/12] freedreno: move more batch related tracking to fd_batch

). The alternative would be having to re-calculate GMEM layout on every batch, even if the dimensions of the render targets are the same. Note: This opens up the possibility of pushing gmem/submit into a helper thread. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- src/gallium/drivers/fre

[Mesa-dev] [PATCH 11/12] freedreno: shadow textures if possible to avoid stall/flush

reference is held by cmdstream) as a shadow. This is done by blitting the remaining other levels (and whatever part of current level that is not discarded) from the old/shadow buffer to the new one. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- src/gallium/drivers/fre

[Mesa-dev] [PATCH 12/12] freedreno: support discarding previous rendering in special cases

rateMipmap(). Signed-off-by: Rob Clark <robdcl...@gmail.com> --- src/gallium/drivers/freedreno/freedreno_context.h | 6 ++ src/gallium/drivers/freedreno/freedreno_draw.c | 10 ++ src/gallium/drivers/freedreno/freedreno_resource.c | 21 - 3 files changed, 32

[Mesa-dev] [PATCH 04/12] freedreno: introduce fd_batch

From: Rob Clark <robcl...@freedesktop.org> Introduce the batch object, to track a batch/submit's worth of ringbuffers and other bookkeeping. In this first step, just move the ringbuffers into batch, since that is mostly uninteresting churn. For now there is just a single batch at a time.

[Mesa-dev] [PATCH 08/12] freedreno: add batch-cache

Note that I originally also had a entry-point that would construct a key and do lookup from a pipe_surface. I ended up not needing that (yet?) but it is easy-enough to re-introduce later if we need it for the blit path. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- src/gallium/d

[Mesa-dev] [PATCH 10/12] freedreno: spiff up some debug traces

Make it easier to track batches, to ensure things happen properly when they are reordered. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- src/gallium/drivers/freedreno/freedreno_draw.c | 6 -- src/gallium/drivers/freedreno/freedreno_gmem.c | 6 -- 2 files changed, 8 insertions

[Mesa-dev] [PATCH 06/12] freedreno: dynamically sized/growable cmd buffers

From: Rob Clark <robcl...@freedesktop.org> Signed-off-by: Rob Clark <robdcl...@gmail.com> --- src/gallium/drivers/freedreno/freedreno_batch.c | 25 src/gallium/drivers/freedreno/freedreno_util.h | 31 ++--- 2 files changed, 33 insertions(+),

[Mesa-dev] [PATCH 05/12] freedreno: push resource tracking down into batch

From: Rob Clark <robcl...@freedesktop.org> Signed-off-by: Rob Clark <robdcl...@gmail.com> --- src/gallium/drivers/freedreno/freedreno_batch.c| 35 ++ src/gallium/drivers/freedreno/freedreno_batch.h| 7 + src/gallium/drivers/freedreno/freedreno_con

[Mesa-dev] [PATCH 03/12] list: fix list_replace() for empty lists

Before, it would happily copy list_head next/prev (ie. pointer to the *from* list_head), leaving things in a confused state and causing much mayhem. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- src/util/list.h | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-)

[Mesa-dev] [PATCH 02/12] gallium: un-inline pipe_surface_desc

Want to re-use this struct, so un-inline it. Signed-off-by: Rob Clark <robdcl...@gmail.com> --- src/gallium/include/pipe/p_state.h | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/includ

[Mesa-dev] [PATCH 01/12] gallium/util: make util_copy_framebuffer_state(src=NULL) work

From: Rob Clark <robcl...@freedesktop.org> Be more consistent with the other u_inlines util_copy_xyz_state() helpers and support NULL src. Signed-off-by: Rob Clark <robcl...@freedesktop.org> --- src/gallium/auxiliary/util/u_framebuffer.c | 37 +- 1 file

[Mesa-dev] [PATCH 00/12] render reordering for optimized tile buffer usage

emaining issues welcome, since there is still some room for further gains. [1] https://github.com/freedreno/libdrm/commits/fd-next Rob Clark (12): gallium/util: make util_copy_framebuffer_state(src=NULL) work gallium: un-inline pipe_surface_desc list: fix list_replace() for empty lists freed

Re: [Mesa-dev] [PATCH v3] mesa/st: Use 'struct nir_shader' instead of 'nir_shader'.

definition of typedef ‘nir_shader’ > ../../src/compiler/nir/nir.h:1830: note: previous declaration of ‘nir_shader’ > was here > > Suggested-by: Rob Clark <robcl...@freedesktop.org> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96235 > Signed-off-by: Vinson Lee <v...@fr

Re: [Mesa-dev] [PATCH 1/2] glsl: add driconf to zero-init unintialized vars

On Wed, Jun 29, 2016 at 12:43 AM, Eirik Byrkjeflot Anonsen <ei...@eirikba.org> wrote: > Rob Clark <robdcl...@gmail.com> writes: > >> On Tue, Jun 28, 2016 at 11:28 AM, Marek Olšák <mar...@gmail.com> wrote: >>> On Mon, Jun 27, 2016 at 9:28 PM, Rob Clark <ro

Re: [Mesa-dev] [PATCH 1/2] glsl: add driconf to zero-init unintialized vars

On Tue, Jun 28, 2016 at 11:28 AM, Marek Olšák <mar...@gmail.com> wrote: > On Mon, Jun 27, 2016 at 9:28 PM, Rob Clark <robdcl...@gmail.com> wrote: >> On Mon, Jun 27, 2016 at 3:06 PM, Kenneth Graunke <kenn...@whitecape.org> >> wrote: >>> On Monday, June

Re: [Mesa-dev] [PATCH] mesa/st: Include nir.h for nir_shader symbol.

On Mon, Jun 27, 2016 at 10:08 PM, Matt Turner wrote: > On Mon, Jun 27, 2016 at 6:45 PM, Vinson Lee wrote: >> Fix this build error with GCC 4.4. >> >> CC state_tracker/st_nir_lower_builtin.lo >> In file included from

Re: [Mesa-dev] [PATCH 1/2] glsl: add driconf to zero-init unintialized vars

On Mon, Jun 27, 2016 at 3:06 PM, Kenneth Graunke <kenn...@whitecape.org> wrote: > On Monday, June 27, 2016 11:43:28 AM PDT Matt Turner wrote: >> On Mon, Jun 27, 2016 at 4:44 AM, Rob Clark <robdcl...@gmail.com> wrote: >> > On Mon, Jun 27, 2016 at 7:13 AM, Alan Swa

Re: [Mesa-dev] [PATCH 1/2] glsl: add driconf to zero-init unintialized vars

On Mon, Jun 27, 2016 at 7:13 AM, Alan Swanson <rei...@improbability.net> wrote: > On 2016-06-25 13:37, Rob Clark wrote: >> >> Some games are sloppy.. perhaps because it is defined behavior for DX or >> perhaps because nv blob driver defaults things to zero. >>

Re: [Mesa-dev] [PATCH] vc4: add hash table look-up for exported dmabufs

On Sat, Jun 25, 2016 at 11:33 PM, Eric Anholt wrote: > Rob Herring writes: > >> It is necessary to reuse existing BOs when dmabufs are imported. There >> are 2 cases that need to be handled. dmabufs can be created/exported and >> imported by the same process and

Re: [Mesa-dev] [PATCH] nir: Fix copy_prop_src when src is an indirect access on a reg.

ause callers of NIR's copy prop are doing so in > SSA, before indirect variable dereferences have been lowered to registers. Reviewed-by: Rob Clark <robdcl...@gmail.com> > --- > src/compiler/nir/nir_opt_copy_propagate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deleti

Re: [Mesa-dev] [PATCH 2/2] i965: don't drop const initializers in vector splitting

On Sat, Jun 25, 2016 at 10:29 AM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > > On Jun 25, 2016 5:39 AM, "Rob Clark" <robdcl...@gmail.com> wrote: >> >> From: Rob Clark <robcl...@freedesktop.org> >> >> Not entirely sure how we did

[Mesa-dev] [PATCH 2/2] i965: don't drop const initializers in vector splitting

From: Rob Clark <robcl...@freedesktop.org> Not entirely sure how we didn't hit this before, but dropping the const initializer on the floor is obviously not correct. Signed-off-by: Rob Clark <robcl...@freedesktop.org> --- No idea why i965 even still uses this pass, vs nir scalariz

[Mesa-dev] [PATCH 1/2] glsl: add driconf to zero-init unintialized vars

From: Rob Clark <robcl...@freedesktop.org> Some games are sloppy.. perhaps because it is defined behavior for DX or perhaps because nv blob driver defaults things to zero. So add driconf param to force uninitialized variables to default to zero. This issue was observed with rust, from

Re: [Mesa-dev] [RFC] Coding style scripts (Was Re: [PATCH 1/2] gallium: replace [0-9]*.f with [0-9]*.0f)

On Wed, Jun 22, 2016 at 8:25 AM, Emil Velikov wrote: > Hi All, > > Seems like we have a few people are keen on the idea of having some > form of at least semi-automated way to handle coding style issues. > > Some options/ideas: > - Combine the emacs .dir-local.el +

Re: [Mesa-dev] [RFC] New dma_buf -> EGLImage EGL extension - Final spec published!

On Mon, Jun 20, 2016 at 8:37 AM, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Fri, 17 Jun 2016 11:44:34 -0400 > Rob Clark <robdcl...@gmail.com> wrote: > >> On Fri, Jun 17, 2016 at 9:31 AM, Pekka Paalanen <ppaala...@gmail.com> wrote: >> > On Fri,

Re: [Mesa-dev] [RFC 2/7] pipe-loader-drm: Add common pipe_screen refcounting

On Fri, Jun 17, 2016 at 2:23 PM, Emil Velikov wrote: > Hi Rob, > > On 17 June 2016 at 18:45, Rob Herring wrote: > >> struct pipe_screen { >> + int refcnt; > Can you please use struct pipe_reference throughout and the respective > pipe_reference API

Re: [Mesa-dev] [RFC] New dma_buf -> EGLImage EGL extension - Final spec published!

On Fri, Jun 17, 2016 at 9:31 AM, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Fri, 17 Jun 2016 08:26:04 -0400 > Rob Clark <robdcl...@gmail.com> wrote: > >> On Fri, Jun 17, 2016 at 3:59 AM, Pekka Paalanen <ppaala...@gmail.com> wrote: >> > On Thu,

Re: [Mesa-dev] [RFC] New dma_buf -> EGLImage EGL extension - Final spec published!

On Fri, Jun 17, 2016 at 3:59 AM, Pekka Paalanen <ppaala...@gmail.com> wrote: > On Thu, 16 Jun 2016 10:40:51 -0400 > Rob Clark <robdcl...@gmail.com> wrote: > >> So, if we wanted to extend this to support the fourcc-modifiers that >> we have on the kernel side for c

Re: [Mesa-dev] virgl and vc4 problem on Android

On Thu, Jun 16, 2016 at 2:57 PM, Rob Herring <r...@kernel.org> wrote: > On Thu, Jun 16, 2016 at 12:09 PM, Rob Clark <robdcl...@gmail.com> wrote: >> On Thu, Jun 16, 2016 at 12:56 PM, Rob Herring <r...@kernel.org> wrote: >>> On Thu, Jun 16, 2016 at 11:44 AM, R

Re: [Mesa-dev] virgl and vc4 problem on Android

On Thu, Jun 16, 2016 at 12:56 PM, Rob Herring <r...@kernel.org> wrote: > On Thu, Jun 16, 2016 at 11:44 AM, Rob Clark <robdcl...@gmail.com> wrote: >> On Wed, Jun 15, 2016 at 8:34 PM, Rob Herring <r...@kernel.org> wrote: >>> In the process of adding RGBX

Re: [Mesa-dev] virgl and vc4 problem on Android

On Wed, Jun 15, 2016 at 8:34 PM, Rob Herring wrote: > In the process of adding RGBX (XB24) format to mesa for Android, I > started seeing a new problem that makes the UI stop updating. It > happens about when the splash screen is stopped and the lock screen is > displayed. The

Re: [Mesa-dev] [RFC] New dma_buf -> EGLImage EGL extension - Final spec published!

the >> application >> has use one EGL doesn't support is sufficient. Any thoughts? >> >> >> Cheers, >> >> Tom >> >> >> 8< >> >> >> Name >> >> EXT_image

Re: [Mesa-dev] [PATCH 01/10] gallium: cleanup set_tess_state

ot;manually".. but those are also kind of different from the rest since they are already refcnt'd. And I figured it was easier to just deal w/ those manually than implement a 3rd type of state (CSO vs Param) in rsq_state.py.. BR, -R > Nicolai > >> >>-ilia >> >&

Re: [Mesa-dev] [PATCH 0/7] Fix ralloc/rzalloc usage v2

I (and I expect Eric too) would appreciate it if you went ahead and replaced the current use of non-"z" versions in code that you can't test w/ the "z" versions. That way we can switch over to non-zero'ing on our own time, rather than getting a surprise next time we pull/rebase I think it's only

<    4   5   6   7   8   9   10   11   12   13   >