Re: [Mesa-dev] [PATCH] anv: correct a duplicate check in an assert

Reviewed-by: Tapani Pälli On 23.01.2018 00:57, Grazvydas Ignotas wrote: Looks like checking both sources was intended, instead of the first one twice. Found with Coccinelle, coccinellery/xand/xand.cocci semantic patch. Signed-off-by: Grazvydas Ignotas --- src/intel/vulkan

Re: [Mesa-dev] [PATCH 2/7] egl: add support for EGL_ANDROID_blob_cache

On 01/22/2018 04:05 PM, Emil Velikov wrote: On 19 January 2018 at 06:53, Tapani Pälli wrote: On 01/18/2018 04:55 PM, Emil Velikov wrote: On 17 January 2018 at 16:11, Tapani Pälli wrote: On 17.01.2018 13:28, Nicolai Hähnle wrote: On 16.01.2018 18:45, Emil Velikov wrote: Hi

Re: [Mesa-dev] [PATCH v3 3/3] anv: implement VK_EXT_global_priority extension

On 01/22/2018 09:01 PM, Jason Ekstrand wrote: On Mon, Jan 22, 2018 at 4:29 AM, Tapani Pälli <mailto:tapani.pa...@intel.com>> wrote: v2: add ANV_CONTEXT_REALTIME_PRIORITY (Chris)     use unreachable with unknown priority (Samuel) v3: add stubs in gem_stubs.c (Emil)

Re: [Mesa-dev] [PATCH 0/7] EGL_ANDROID_blob_cache

On 22.01.2018 15:16, Nicolai Hähnle wrote: On 19.01.2018 07:05, Tapani Pälli wrote: On 01/18/2018 05:49 PM, Nicolai Hähnle wrote: On 17.01.2018 17:10, Tapani Pälli wrote: On 17.01.2018 13:34, Nicolai Hähnle wrote: On 15.01.2018 13:31, Tapani Pälli wrote: Hello; Here's a refac

Re: [Mesa-dev] [PATCH 1/3] intel: add new common header gen_defines.h

On 22.01.2018 17:10, Emil Velikov wrote: On 22 January 2018 at 12:29, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- src/intel/common/gen_defines.h | 52 ++ 1 file changed, 52 insertions(+) create mode 100644 src/intel/common/gen_defines.h

[Mesa-dev] [PATCH v2 4/5] disk cache: add callback functionality

v2: add disk_cache_has_key, disk_cache_put_key support using blob cache (Nicolai, Jordan) Signed-off-by: Tapani Pälli --- src/util/disk_cache.c | 49 + src/util/disk_cache.h | 19 +++ 2 files changed, 68 insertions(+) diff

[Mesa-dev] [PATCH 5/5] i965: add __DRI2_BLOB support and set cache functions

Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/intel_screen.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index a4e34e9f2c..84009382c6 100644 --- a/src/mesa/drivers/dri

[Mesa-dev] [PATCH 3/5] disk cache: initialize cache path and index only when used

This patch makes disk_cache initialize path and index lazily so that we can utilize disk_cache without a path using callback functionality introduced by next patch. Signed-off-by: Tapani Pälli --- src/util/disk_cache.c | 114 -- 1 file changed, 73

[Mesa-dev] [PATCH 1/5] dri: add interface for EGL_ANDROID_blob_cache extension

Signed-off-by: Tapani Pälli --- include/GL/internal/dri_interface.h | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index 34a5c9fb01..de367d8f77 100644 --- a/include/GL

[Mesa-dev] [PATCH v2 2/5] egl: add support for EGL_ANDROID_blob_cache

v2: cleanup, move callbacks to _egl_display struct (Emil Velikov) Signed-off-by: Tapani Pälli --- src/egl/drivers/dri2/egl_dri2.c | 39 +++ src/egl/drivers/dri2/egl_dri2.h | 1 + src/egl/main/eglapi.c | 30 ++ src/egl

[Mesa-dev] [PATCH 0/5] EGL_ANDROID_blob_cache

ed regular disk cache and blob cache on desktop with these changes, and blob cache functionality on Android. Thanks; Tapani Pälli (5): dri: add interface for EGL_ANDROID_blob_cache extension egl: add support for EGL_ANDROID_blob_cache disk cache: initialize cache path and index only when u

[Mesa-dev] [PATCH 1/3] intel: add new common header gen_defines.h

Signed-off-by: Tapani Pälli --- src/intel/common/gen_defines.h | 52 ++ 1 file changed, 52 insertions(+) create mode 100644 src/intel/common/gen_defines.h diff --git a/src/intel/common/gen_defines.h b/src/intel/common/gen_defines.h new file mode 100644

[Mesa-dev] [PATCH 2/3] i965: use context priority definitions from gen_defines.h

Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/brw_bufmgr.h | 4 src/mesa/drivers/dri/i965/brw_context.c | 8 +--- src/mesa/drivers/dri/i965/intel_screen.c | 8 +--- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.h

[Mesa-dev] [PATCH v3 3/3] anv: implement VK_EXT_global_priority extension

v2: add ANV_CONTEXT_REALTIME_PRIORITY (Chris) use unreachable with unknown priority (Samuel) v3: add stubs in gem_stubs.c (Emil) use priority defines from gen_defines.h Signed-off-by: Tapani Pälli Reviewed-by: Samuel Iglesias Gonsálvez (v2) Reviewed-by: Chris Wilson (v2) --- src

Re: [Mesa-dev] [PATCH] i965: Accept CONTEXT_ATTRIB_PRIORITY for brwCreateContext

Reviewed-by: Tapani Pälli On 01/20/2018 02:29 AM, Chris Wilson wrote: The forward port of commit 6d87500fe12e ("dri: Change __DriverApiRec::CreateContext to take a struct for attribs") failed to adapt the set of allowed attributes for the earlier introduction of context prioriti

Re: [Mesa-dev] [PATCH] mesa: Only require independent blending for GLES 3.2.

On 01/22/2018 08:48 AM, Ilia Mirkin wrote: What es3 does require, though, is mrt. Maybe add something that ensures that mrt is supported? I guess that would be EXT_draw_buffers? That is currently enabled with 'dummy_true'. On Jan 19, 2018 08:39, "Eric Anholt" > wro

Re: [Mesa-dev] [PATCH] mesa: enable ASTC/ETC1 compressed textures

On 01/19/2018 12:44 PM, Juan A. Suarez Romero wrote: Anyone could take a look at this patch? Can you pinpoint where the mentioned tests are located, which suite? Thanks in advance! J.A. On Thu, 2018-01-11 at 16:35 +0100, Juan A. Suarez Romero wrote: Enable these kind of texture

[Mesa-dev] [PATCH v2] anv: implement VK_EXT_global_priority extension

v2: add ANV_CONTEXT_REALTIME_PRIORITY (Chris) use unreachable with unknown priority (Samuel) Signed-off-by: Tapani Pälli --- Small crucible test available here: https://cgit.freedesktop.org/~tpalli/crucible/commit/?h=VK_EXT_global_priority src/intel/vulkan/anv_device.c | 25

Re: [Mesa-dev] [PATCH] anv: implement VK_EXT_global_priority extension

On 01/19/2018 01:20 PM, Samuel Iglesias Gonsálvez wrote: On 19/01/18 12:11, Tapani Pälli wrote: On 01/19/2018 01:08 PM, Samuel Iglesias Gonsálvez wrote: On 19/01/18 11:44, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- Small crucible test available here: https

Re: [Mesa-dev] [PATCH 7/7] android: set '/sdcard/' as MESA_GLSL_CACHE_DIR by default

On 01/19/2018 01:03 PM, Tapani Pälli wrote: On 01/19/2018 11:22 AM, Jordan Justen wrote: On 2018-01-18 22:08:17, Tapani Pälli wrote: On 01/18/2018 08:18 PM, Jordan Justen wrote: On 2018-01-15 04:31:43, Tapani Pälli wrote: This can/should be modified depending on needs. AFAIK by default

Re: [Mesa-dev] [PATCH] anv: implement VK_EXT_global_priority extension

On 01/19/2018 01:08 PM, Samuel Iglesias Gonsálvez wrote: On 19/01/18 11:44, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- Small crucible test available here: https://cgit.freedesktop.org/~tpalli/crucible/commit/?h=VK_EXT_global_priority src/intel/vulkan/anv_device.c | 25

Re: [Mesa-dev] [PATCH] anv: implement VK_EXT_global_priority extension

On 01/19/2018 01:00 PM, Chris Wilson wrote: Quoting Tapani Pälli (2018-01-19 10:44:49) diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c index 34c0989108..46069dcdc7 100644 --- a/src/intel/vulkan/anv_gem.c +++ b/src/intel/vulkan/anv_gem.c @@ -302,6 +302,55

Re: [Mesa-dev] [PATCH 7/7] android: set '/sdcard/' as MESA_GLSL_CACHE_DIR by default

On 01/19/2018 11:22 AM, Jordan Justen wrote: On 2018-01-18 22:08:17, Tapani Pälli wrote: On 01/18/2018 08:18 PM, Jordan Justen wrote: On 2018-01-15 04:31:43, Tapani Pälli wrote: This can/should be modified depending on needs. AFAIK by default, this is the only path that can be read

[Mesa-dev] [PATCH] anv: implement VK_EXT_global_priority extension

Signed-off-by: Tapani Pälli --- Small crucible test available here: https://cgit.freedesktop.org/~tpalli/crucible/commit/?h=VK_EXT_global_priority src/intel/vulkan/anv_device.c | 25 +++ src/intel/vulkan/anv_extensions.py | 2 ++ src/intel/vulkan/anv_gem.c | 49

Re: [Mesa-dev] [PATCH] mesa: Only require independent blending for GLES 3.2.

Yep, that is addition to GLES 3.2 spec. Reviewed-by: Tapani Pälli On 01/19/2018 07:36 AM, Eric Anholt wrote: We've been requiring this since GLES 3.0 was introduced, but the GLES 3.2 spec is the one that has "Supporting blending on a per-draw-buffer basis" in the new features.

Re: [Mesa-dev] [PATCH] anv: avoid segmentation fault due to vk_error()

Reviewed-by: Tapani Pälli (Fixes e5b1bd6ab8) On 01/19/2018 09:59 AM, Samuel Iglesias Gonsálvez wrote: vk_error() is a macro that calls __vk_errorf() with instance == NULL. Then, __vk_errorf() passes a pointer to instance->debug_report_callbacks to vk_debug_error(), which segfaults as t

Re: [Mesa-dev] [PATCH] egl: do not expose EGL_EXT_pixel_format_float yet

On 01/18/2018 03:31 PM, Emil Velikov wrote: On 18 January 2018 at 06:05, Tapani Pälli wrote: On 01/17/2018 11:59 PM, Rob Herring wrote: On Wed, Jan 17, 2018 at 12:27 PM, Tapani Pälli wrote: Let's expose this only when we have formats. There are some known issues when this is ex

[Mesa-dev] [PATCH v2] egl: add support for EGL_ANDROID_blob_cache

v2: cleanup, move callbacks to _egl_display struct (Emil Velikov) Signed-off-by: Tapani Pälli --- src/egl/drivers/dri2/egl_dri2.c | 39 +++ src/egl/drivers/dri2/egl_dri2.h | 1 + src/egl/main/eglapi.c | 30 ++ src/egl

Re: [Mesa-dev] [PATCH 2/7] egl: add support for EGL_ANDROID_blob_cache

On 01/18/2018 04:55 PM, Emil Velikov wrote: On 17 January 2018 at 16:11, Tapani Pälli wrote: On 17.01.2018 13:28, Nicolai Hähnle wrote: On 16.01.2018 18:45, Emil Velikov wrote: Hi Tapani, On 15 January 2018 at 12:31, Tapani Pälli wrote: +static void +update_blob_cache_functions

Re: [Mesa-dev] [PATCH 6/7] android: ignore MESA_GLSL_CACHE_DISABLE setting

On 01/18/2018 04:59 PM, Emil Velikov wrote: On 17 January 2018 at 08:12, Tapani Pälli wrote: On 16.01.2018 11:02, Jordan Justen wrote: On 2018-01-15 04:31:42, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 2 ++ src/util

Re: [Mesa-dev] Logging infrastructure?

Hi; On 01/18/2018 11:44 PM, Chuck Atkins wrote: Is there a logging infrastructure currently available to drivers in Mesa?  I was looking to clean up some of swr's debug / info output and have it conditional on the MESA_DEBUG and LIBGL_DEBUG variables but then I realized that it's really someth

Re: [Mesa-dev] [PATCH 7/7] android: set '/sdcard/' as MESA_GLSL_CACHE_DIR by default

On 01/18/2018 08:18 PM, Jordan Justen wrote: On 2018-01-15 04:31:43, Tapani Pälli wrote: This can/should be modified depending on needs. AFAIK by default, this is the only path that can be read/written to by anyone. Signed-off-by: Tapani Pälli --- Android.common.mk | 1 + 1 file changed

Re: [Mesa-dev] [PATCH 0/7] EGL_ANDROID_blob_cache

On 01/18/2018 05:49 PM, Nicolai Hähnle wrote: On 17.01.2018 17:10, Tapani Pälli wrote: On 17.01.2018 13:34, Nicolai Hähnle wrote: On 15.01.2018 13:31, Tapani Pälli wrote: Hello; Here's a refactored series of EGL_ANDROID_blob_cache. Now cache functions are stored in disk_cache struc

Re: [Mesa-dev] [PATCH] egl: do not expose EGL_EXT_pixel_format_float yet

On 01/17/2018 11:59 PM, Rob Herring wrote: On Wed, Jan 17, 2018 at 12:27 PM, Tapani Pälli wrote: Let's expose this only when we have formats. There are some known issues when this is exposed without formats (on Android). This is fixed now at least for master. OK cool .. then I gue

Re: [Mesa-dev] [PATCH 7/7] android: set '/sdcard/' as MESA_GLSL_CACHE_DIR by default

On 01/18/2018 12:03 AM, Rob Herring wrote: On Mon, Jan 15, 2018 at 6:31 AM, Tapani Pälli wrote: This can/should be modified depending on needs. AFAIK by default, this is the only path that can be read/written to by anyone. Signed-off-by: Tapani Pälli --- Android.common.mk | 1 + 1 file

[Mesa-dev] [PATCH] egl: do not expose EGL_EXT_pixel_format_float yet

Let's expose this only when we have formats. There are some known issues when this is exposed without formats (on Android). Signed-off-by: Tapani Pälli --- src/egl/drivers/dri2/egl_dri2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers

Re: [Mesa-dev] [PATCH 2/7] egl: add support for EGL_ANDROID_blob_cache

On 17.01.2018 13:28, Nicolai Hähnle wrote: On 16.01.2018 18:45, Emil Velikov wrote: Hi Tapani, On 15 January 2018 at 12:31, Tapani Pälli wrote: +static void +update_blob_cache_functions(struct dri2_egl_display *dri2_dpy, +    struct dri2_egl_context *dri2_ctx

Re: [Mesa-dev] [PATCH 0/7] EGL_ANDROID_blob_cache

On 17.01.2018 13:34, Nicolai Hähnle wrote: On 15.01.2018 13:31, Tapani Pälli wrote: Hello; Here's a refactored series of EGL_ANDROID_blob_cache. Now cache functions are stored in disk_cache struct and the functionality called within existing disk_cache put/get code. Problems/errors

Re: [Mesa-dev] Mesa 18.0.0 release plan

On 17.01.2018 16:03, Emil Velikov wrote: On 16 January 2018 at 21:57, Kenneth Graunke wrote: On Tuesday, January 16, 2018 11:18:13 AM PST Emil Velikov wrote: Hi all, As you've know the Mesa 18.0.0 release plan has been available for a while on the mesa3d.org website [1]. In case you've mis

Re: [Mesa-dev] [PATCH 2/7] egl: add support for EGL_ANDROID_blob_cache

On 16.01.2018 19:45, Emil Velikov wrote: Hi Tapani, On 15 January 2018 at 12:31, Tapani Pälli wrote: +static void +update_blob_cache_functions(struct dri2_egl_display *dri2_dpy, +struct dri2_egl_context *dri2_ctx) +{ + if (!dri2_dpy || !dri2_ctx) + return

Re: [Mesa-dev] [PATCH 6/7] android: ignore MESA_GLSL_CACHE_DISABLE setting

On 16.01.2018 11:02, Jordan Justen wrote: On 2018-01-15 04:31:42, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 2 ++ src/util/disk_cache.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH] st/dri: Default ALLOW_RGB10_CONFIGS to false on gallium as well.

Reviewed-by: Tapani Pälli On 16.01.2018 06:39, Mario Kleiner wrote: For consistency with the i965 default of "off". Signed-off-by: Mario Kleiner --- src/gallium/auxiliary/pipe-loader/driinfo_gallium.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/s

[Mesa-dev] [PATCH 2/7] egl: add support for EGL_ANDROID_blob_cache

Signed-off-by: Tapani Pälli --- src/egl/drivers/dri2/egl_dri2.c | 43 + src/egl/drivers/dri2/egl_dri2.h | 4 src/egl/main/eglapi.c | 29 +++ src/egl/main/eglapi.h | 4 src/egl/main/egldisplay.h

[Mesa-dev] [PATCH 5/7] i965: add __DRI2_BLOB support and set cache functions

Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/intel_screen.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 08032c9b22..4c19304f14 100644 --- a/src/mesa/drivers/dri

[Mesa-dev] [PATCH 6/7] android: ignore MESA_GLSL_CACHE_DISABLE setting

Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/brw_disk_cache.c | 2 ++ src/util/disk_cache.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_disk_cache.c b/src/mesa/drivers/dri/i965/brw_disk_cache.c index 65bb52726e

[Mesa-dev] [PATCH 4/7] disk cache: support setting MESA_GLSL_CACHE_DIR at compile time

Signed-off-by: Tapani Pälli --- src/util/disk_cache.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index b71363bcf3..d7891e3b70 100644 --- a/src/util/disk_cache.c +++ b/src/util/disk_cache.c @@ -47,6 +47,7

[Mesa-dev] [PATCH 3/7] disk cache: add callback functionality

Signed-off-by: Tapani Pälli --- src/util/disk_cache.c | 39 +++ src/util/disk_cache.h | 19 +++ 2 files changed, 58 insertions(+) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index 7ebfa8c045..b71363bcf3 100644 --- a/src/util

[Mesa-dev] [PATCH 0/7] EGL_ANDROID_blob_cache

n cache as seen in the log output: 01-15 07:40:26.329 2129 2129 D SurfaceFlinger: shader cache generated - 24 shaders in 57.687504 ms I'm not sure if /sdcard is sane default but I've tried everything else (/cache, /data/cache) and failed because of permission errors. Thanks; Tap

[Mesa-dev] [PATCH 7/7] android: set '/sdcard/' as MESA_GLSL_CACHE_DIR by default

This can/should be modified depending on needs. AFAIK by default, this is the only path that can be read/written to by anyone. Signed-off-by: Tapani Pälli --- Android.common.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/Android.common.mk b/Android.common.mk index 52dc7bff3b..7edbbfc0f2

[Mesa-dev] [PATCH 1/7] dri: add interface for EGL_ANDROID_blob_cache extension

Signed-off-by: Tapani Pälli --- include/GL/internal/dri_interface.h | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index 34a5c9fb01..de367d8f77 100644 --- a/include/GL

Re: [Mesa-dev] [PATCH] glsl/linker: link-error using the same name in unnamed block and outside

On 01/15/2018 12:56 PM, Juan A. Suarez Romero wrote: On Thu, 2018-01-11 at 16:51 +0100, Juan A. Suarez Romero wrote: On Wed, 2018-01-10 at 14:04 +0200, Tapani Pälli wrote: On 01/08/2018 03:19 PM, Juan A. Suarez Romero wrote: Please, could someone take a look at this patch? Thanks in

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option (v2)

Hi; On 11.01.2018 20:20, Mario Kleiner wrote: On 01/11/2018 09:14 AM, Tapani Pälli wrote: Yes, but as it broke regular visuals (on some of our testing machines as well) we needed a fast fix for this. While this is an issue, I think the visual corruption has higher priority than this. This

Re: [Mesa-dev] [PATCH] i965/screen: Allow drirc to set 'allow_rgb10_configs' again.

Yeah that works, thanks Mario! Reviewed-by: Tapani Pälli On 11.01.2018 18:00, Mario Kleiner wrote: Since setup of ALLOW_RGB10_CONFIGS was moved to i965's own brw_config_options.xml, this was hard-coded to false and could not be overriden by drirc. Add some parsing into i965's priv

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option (v2)

On 01/11/2018 08:14 AM, Mario Kleiner wrote: On 01/10/2018 07:04 AM, Tapani Pälli wrote: Hi Marek; This one works but only if you add DRI_CONF_ALLOW_RGB10_CONFIGS("false") to the DRI_CONF_SECTION_MISCELLANEOUS section in intel_screen. With that change: Reviewed-by: Tapani Pälli

Re: [Mesa-dev] [RFC 07/10] mesa: add program blob cache functionality

On 01/11/2018 12:43 AM, Jordan Justen wrote: On 2018-01-08 23:48:19, Tapani Pälli wrote: Cache set and get are called in similar fashion as what is happening with disk cache. Functionality requires ARB_get_program_binary and EGL_ANDROID_blob_cache support. Signed-off-by: Tapani Pälli

Re: [Mesa-dev] [PATCH 1/2] vulkan: move anv VK_EXT_debug_report implementation to common code.

This LGTM. You are taking away the instance constructor/destructor callback but it wasn't used anyway so that's fine. If someone needs it, it can be added later. Reviewed-by: Tapani Pälli On 01/09/2018 04:04 PM, Bas Nieuwenhuizen wrote: For also using it in radv. I moved the remai

Re: [Mesa-dev] [PATCH] glsl/linker: link-error using the same name in unnamed block and outside

On 01/08/2018 03:19 PM, Juan A. Suarez Romero wrote: Please, could someone take a look at this patch? Thanks in advance. This looks correct to me. Is there some dEQP/Piglit test for this situation? J.A. On Mon, 2017-12-04 at 17:35 +0100, Juan A. Suarez Romero wrote: According wit

Re: [Mesa-dev] [RFC 04/10] glsl: add function to create unique string from shader program

On 01/09/2018 04:30 PM, Eric Engestrom wrote: On Tuesday, 2018-01-09 09:48:16 +0200, Tapani Pälli wrote: Patch moves existing functionality from shader_cache_read_program_metadata to a helper function. Signed-off-by: Tapani Pälli --- src/compiler/Makefile.sources | 1 + src

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option (v2)

Hi Marek; This one works but only if you add DRI_CONF_ALLOW_RGB10_CONFIGS("false") to the DRI_CONF_SECTION_MISCELLANEOUS section in intel_screen. With that change: Reviewed-by: Tapani Pälli On 01/09/2018 04:04 PM, Marek Olšák wrote: From: Marek Olšák This is unused becaus

Re: [Mesa-dev] [RFC 07/10] mesa: add program blob cache functionality

On 01/09/2018 05:05 PM, Eric Engestrom wrote: On Tuesday, 2018-01-09 09:48:19 +0200, Tapani Pälli wrote: Cache set and get are called in similar fashion as what is happening with disk cache. Functionality requires ARB_get_program_binary and EGL_ANDROID_blob_cache support. Signed-off-by

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option

On 01/09/2018 08:37 AM, Tapani Pälli wrote: On 01/08/2018 06:59 PM, Marek Olšák wrote: From: Marek Olšák This is unused because it's for libGL/libEGL, not drivers. IMO this is not enough, you would need to also remove the query for this as well (driQueryOptionb in intel_scr

[Mesa-dev] [RFC 06/10] glsl: create shader sha1 if disk cache or blob cache is active

Signed-off-by: Tapani Pälli --- src/compiler/glsl/glsl_parser_extras.cpp | 26 ++ src/util/disk_cache.c| 5 +++-- 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/src/compiler/glsl/glsl_parser_extras.cpp b/src/compiler/glsl

[Mesa-dev] [RFC 10/10] egl: XXX debug framework for EGL_ANDROID_blob_cache

Patch disables EGL_ANDROID_blob_cache and sets own get/set cache functions internally, this makes any EGL app to utilize cache automatically. Signed-off-by: Tapani Pälli --- src/egl/drivers/dri2/egl_dri2.c | 3 -- src/egl/main/eglapi.c | 77

[Mesa-dev] [RFC 08/10] egl: add support for EGL_ANDROID_blob_cache

Signed-off-by: Tapani Pälli --- src/egl/drivers/dri2/egl_dri2.c | 43 + src/egl/drivers/dri2/egl_dri2.h | 4 src/egl/main/eglapi.c | 29 +++ src/egl/main/eglapi.h | 4 src/egl/main/egldisplay.h

[Mesa-dev] [RFC 07/10] mesa: add program blob cache functionality

Cache set and get are called in similar fashion as what is happening with disk cache. Functionality requires ARB_get_program_binary and EGL_ANDROID_blob_cache support. Signed-off-by: Tapani Pälli --- src/mesa/Makefile.sources | 2 + src/mesa/main/program_blob_cache.c | 141

[Mesa-dev] [RFC 09/10] i965: add __DRI2_BLOB support and set cache functions

Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/intel_screen.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 3e016b5b7a..01752700cf 100644 --- a/src/mesa/drivers/dri

[Mesa-dev] [RFC 02/10] android: disable disk cache on Android

Original reason why this was enabled was to get sha1 functionality which used to be guarded by shader cache define. Instead of disk cache, Android will utilize EGL_ANDROID_blob_cache for caching. Signed-off-by: Tapani Pälli --- Android.common.mk | 1 - 1 file changed, 1 deletion(-) diff --git

[Mesa-dev] [RFC 00/10] EGL_ANDROID_blob_cache RFC

tion. Any comments appreciated, thanks! Tapani Pälli (10): glsl: cleanup shader_cache header guard android: disable disk cache on Android dri: add interface for EGL_ANDROID_blob_cache extension glsl: add function to create unique string from shader program mesa: add set and get functions to

[Mesa-dev] [RFC 04/10] glsl: add function to create unique string from shader program

Patch moves existing functionality from shader_cache_read_program_metadata to a helper function. Signed-off-by: Tapani Pälli --- src/compiler/Makefile.sources | 1 + src/compiler/glsl/meson.build | 1 + src/compiler/glsl/program.cpp | 88

[Mesa-dev] [RFC 03/10] dri: add interface for EGL_ANDROID_blob_cache extension

Signed-off-by: Tapani Pälli --- include/GL/internal/dri_interface.h | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index 34a5c9fb01..de367d8f77 100644 --- a/include/GL

[Mesa-dev] [RFC 05/10] mesa: add set and get functions to gl_context

These will be utilized by EGL_ANDROID_blob_cache extension. Signed-off-by: Tapani Pälli --- src/mesa/main/mtypes.h | 16 1 file changed, 16 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index a4f1e78f41..073b6c8536 100644 --- a/src/mesa/main

[Mesa-dev] [RFC 01/10] glsl: cleanup shader_cache header guard

Signed-off-by: Tapani Pälli --- src/compiler/glsl/shader_cache.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/shader_cache.h b/src/compiler/glsl/shader_cache.h index c0598f37e8..eeefb3aeb2 100644 --- a/src/compiler/glsl/shader_cache.h +++ b/src

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option

On 01/08/2018 06:59 PM, Marek Olšák wrote: From: Marek Olšák This is unused because it's for libGL/libEGL, not drivers. IMO this is not enough, you would need to also remove the query for this as well (driQueryOptionb in intel_screen.c), otherwise we hit assertion. Maybe just set bool allo

Re: [Mesa-dev] [PATCH 07/22] dri/common: Add option to allow exposure of 10 bpc color configs. (v2)

to enabled. v2: Rename expose_rgb10_configs to allow_rgb10_configs, as suggested by Emil. Add comment to option parsing, to make sure it stays before the ->InitScreen(). Signed-off-by: Mario Kleiner Reviewed-by: Tapani Pälli Reviewed-by: Marek Olšák --- src/mesa/drivers/dri/comm

Re: [Mesa-dev] [PATCH] egl/android: Fix build break with dri2_initialize_android _EGLDisplay parameter

Reviewed-by: Tapani Pälli On 01/03/2018 06:28 PM, Rob Herring wrote: Commit 2f421651aca9 ("egl: let each platform decided how to handle LIBGL_ALWAYS_SOFTWARE") broke the build due to copy-n-paste of misnamed function parameter.: src/egl/drivers/dri2/platform_android.c:1183:8: err

Re: [Mesa-dev] Retrieving useful debug infos about (AMD) Mesa and Firefox quirks

Hi; On 01/02/2018 10:46 PM, Germano Massullo wrote: Hi everyone! Bugreport "Latest mesa breaks firefox on kde plasma with compositing on" https://bugs.freedesktop.org/show_bug.cgi?id=103699 is about Intel cards, and it looks like the bug has been fixed with an Intel only patch. Personally,

Re: [Mesa-dev] [PATCH 13/16] meta: Track temporary textures using gl_texture_object instead of GL API object handle

On 19.12.2017 02:14, Ian Romanick wrote: From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 43 ++--- src/mesa/drivers/common/meta.h | 2 +- src/mesa/drivers/common/meta_blit.c | 8 --- 3 files changed, 36

Re: [Mesa-dev] [PATCH 16/16] meta: Don't pollute the texture namespace

series is Reviewed-by: Tapani Pälli On 19.12.2017 02:14, Ian Romanick wrote: From: Ian Romanick tl;dr: For many types of GL object, we can *NEVER* use the Gen function. In OpenGL ES (all versions!) and OpenGL compatibility profile, applications don't have to call Gen functions. The GL

Re: [Mesa-dev] [PATCH 03/16] mesa: Add _mesa_bind_texture method

On 20.12.2017 20:04, Tapani Pälli wrote: On 20.12.2017 01:36, Ian Romanick wrote: On 12/19/2017 03:45 AM, Tapani Pälli wrote: On 12/19/2017 01:39 PM, Tapani Pälli wrote: On 12/19/2017 02:14 AM, Ian Romanick wrote: From: Ian Romanick Light-weight glBindTexture for internal use

Re: [Mesa-dev] [PATCH 03/16] mesa: Add _mesa_bind_texture method

On 20.12.2017 01:36, Ian Romanick wrote: On 12/19/2017 03:45 AM, Tapani Pälli wrote: On 12/19/2017 01:39 PM, Tapani Pälli wrote: On 12/19/2017 02:14 AM, Ian Romanick wrote: From: Ian Romanick Light-weight glBindTexture for internal use. Signed-off-by: Ian Romanick ---   src/mesa

[Mesa-dev] [PATCH] drirc: set allow_glsl_cross_stage_interpolation_mismatch for more games

Signed-off-by: Tapani Pälli Suggested-by: Darius Spitznagel https://bugs.freedesktop.org/show_bug.cgi?id=104288 --- src/util/drirc | 8 1 file changed, 8 insertions(+) diff --git a/src/util/drirc b/src/util/drirc index 73d27c07b0..bdc90227c6 100644 --- a/src/util/drirc +++ b/src/util

Re: [Mesa-dev] [PATCH 05/16] meta/blit: Don't restore state of the temporary texture

patches 4,5 Reviewed-by: Tapani Pälli On 12/19/2017 02:14 AM, Ian Romanick wrote: From: Ian Romanick It's about to be destroyed, so there's no point. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta_blit.c | 48 + 1 file c

Re: [Mesa-dev] [PATCH 03/16] mesa: Add _mesa_bind_texture method

On 12/19/2017 01:39 PM, Tapani Pälli wrote: On 12/19/2017 02:14 AM, Ian Romanick wrote: From: Ian Romanick Light-weight glBindTexture for internal use. Signed-off-by: Ian Romanick ---   src/mesa/main/texobj.c | 17 -   src/mesa/main/texobj.h |  4 +++-   2 files changed

Re: [Mesa-dev] [PATCH 03/16] mesa: Add _mesa_bind_texture method

On 12/19/2017 02:14 AM, Ian Romanick wrote: From: Ian Romanick Light-weight glBindTexture for internal use. Signed-off-by: Ian Romanick --- src/mesa/main/texobj.c | 17 - src/mesa/main/texobj.h | 4 +++- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/sr

Re: [Mesa-dev] [PATCH 3/9] glsl: minor simplification in assign_varying_locations()

On 12/19/2017 11:14 AM, Timothy Arceri wrote: On 19/12/17 19:47, Tapani Pälli wrote: On 12/18/2017 10:47 PM, Brian Paul wrote: ---   src/compiler/glsl/link_varyings.cpp | 8 +++-   1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src

Re: [Mesa-dev] [PATCH 08/16] meta/blit: Since _mesa_meta_bind_rb_as_tex_image has only one output, return it

Nice cleanup, patches 6,7,8 Reviewed-by: Tapani Pälli On 12/19/2017 02:14 AM, Ian Romanick wrote: From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.h | 5 ++--- src/mesa/drivers/common/meta_blit.c | 23 --- 2 files changed, 14

Re: [Mesa-dev] [PATCH 3/9] glsl: minor simplification in assign_varying_locations()

On 12/18/2017 10:47 PM, Brian Paul wrote: --- src/compiler/glsl/link_varyings.cpp | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 9039c3b..6d74f9a 100644 --- a/src/compiler/glsl/link_

Re: [Mesa-dev] [PATCH 1/9] glsl: trivial comment fix in lower_packed_varyings.cpp

On 12/18/2017 10:47 PM, Brian Paul wrote: --- src/compiler/glsl/lower_packed_varyings.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/lower_packed_varyings.cpp b/src/compiler/glsl/lower_packed_varyings.cpp index 1aec7ee..b840d26 100644 --- a/src/com

Re: [Mesa-dev] [PATCH 22/22] mesa: Add GL_UNSIGNED_INT_2_10_10_10_REV OES read type for BGRX1010102.

Reviewed-by: Tapani Pälli On 12/16/2017 12:05 AM, Mario Kleiner wrote: As Marek noted, the GL_RGBA + GL_UNSIGNED_INT_2_10_10_10_REV type combo is also good for readback of BGRX1010102 framebuffers, not only for BGRA1010102 framebuffers for use with glReadPixels() under GLES, so add it for the

Re: [Mesa-dev] [PATCH 1/2] android: fix vulkan driver futex usage issues

Ping .. These 2 patches are required because build is broken without them (when vulkan=true in build options). This patch should be renamed as "fix undefined futex API references" or something better like that. On 12/12/2017 10:01 AM, Tapani Pälli wrote: Fixes: f98a2768ca &quo

Re: [Mesa-dev] [PATCH 0/4] GL_EXT_disjoint_timer_query series

eview Ian! On 12/14/2017 04:03 AM, Tapani Pälli wrote: Hi; Here's a revisited GL_EXT_disjoint_timer_query series. One patch got dropped (as discussed with Lionel) and enabling is now via EXT_disjoint_timer_query boolean as was intended (Ian). Thanks; Tapani Pälli (4): mesa: add D

[Mesa-dev] [PATCH 1/4] mesa: add DisjointOperation to gl_shared_state

This state will be used by EXT_disjoint_timer_query. As first usage, patch sets DisjointOperation true when gpu reset happens. Signed-off-by: Tapani Pälli Reviewed-by: Lionel Landwerlin --- src/mesa/main/mtypes.h | 8 src/mesa/main/robustness.c | 1 + 2 files changed, 9 insertions

[Mesa-dev] [PATCH 4/4] i965: enable EXT_disjoint_timer_query extension

Following dEQP cases pass: dEQP-EGL.functional.get_proc_address.extension.gl_ext_disjoint_timer_query dEQP-EGL.functional.client_extensions.disjoint Piglit test 'ext_disjoint_timer_query-simple' passes with these changes. No changes/regression observed in Intel CI. Signed-off-

[Mesa-dev] [PATCH 3/4] mesa: GL_EXT_disjoint_timer_query extension API bits

Patch adds GL_GPU_DISJOINT_EXT and enables to use timer queries when EXT_disjoint_timer_query is enabled. v2: enable extension only when EXT_disjoint_timer_query set Signed-off-by: Tapani Pälli Reviewed-by: Lionel Landwerlin (v1) --- src/mesa/main/extensions_table.h | 1 + src/mesa/main

[Mesa-dev] [PATCH 2/4] glapi: add GL_EXT_disjoint_timer_query

Most entrypoints already available via other extensions like GL_EXT_occlusion_query_boolean, GL_EXT_timer_query. Signed-off-by: Tapani Pälli Reviewed-by: Lionel Landwerlin --- src/mapi/glapi/gen/es_EXT.xml | 16 src/mapi/glapi/gen/gl_API.xml | 4 ++-- src

[Mesa-dev] [PATCH 0/4] GL_EXT_disjoint_timer_query series

Hi; Here's a revisited GL_EXT_disjoint_timer_query series. One patch got dropped (as discussed with Lionel) and enabling is now via EXT_disjoint_timer_query boolean as was intended (Ian). Thanks; Tapani Pälli (4): mesa: add DisjointOperation to gl_shared_state glapi

Re: [Mesa-dev] [PATCH 4/4] mesa: enable GL_EXT_disjoint_timer_query extension

On 12/12/2017 07:00 PM, Ian Romanick wrote: On 11/19/2017 11:18 PM, Tapani Pälli wrote: Add GL_GPU_DISJOINT_EXT and enable extension when ARB_timer_query is supported by the driver. Following dEQP cases pass: dEQP-EGL.functional.get_proc_address.extension.gl_ext_disjoint_timer_query

[Mesa-dev] [PATCH 1/2] android: fix vulkan driver futex usage issues

Fixes: f98a2768ca "mesa: Add new fast mtx_t mutex type for basic use cases" Signed-off-by: Tapani Pälli --- Android.common.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/Android.common.mk b/Android.common.mk index 103e3fec61..d9f871c08c 100644 --- a/Android.commo

[Mesa-dev] [PATCH 2/2] android: fix vulkan driver build

fixes undefined references by adding missing wsi common API Signed-off-by: Tapani Pälli --- src/vulkan/Android.mk | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/vulkan/Android.mk b/src/vulkan/Android.mk index 47c5c51081..6d6df938ab 100644 --- a/src/vulkan

Re: [Mesa-dev] [PATCH] egl/android: Provide an option for the backend to expose KHR_image

On 12/07/2017 08:45 PM, Emil Velikov wrote: Hi Harish, On 7 December 2017 at 13:34, Harish Krupo wrote: From android cts 8.0_r4, a new test case checks if all the required egl extensions are exposed. In the current implementation we expose KHR_image if KHR_image_base and KHR_image_pixmap ar

<    1   2   3   4   5   6   7   8   9   10   >