[Mesa-dev] [PATCH v2] glsl: Correct several built-in functions availability

2018-10-31 Thread Vadym Shovkoplias
) v2: genIType sign(genIType x) was added in 1.30 GLSL spec, not in 1.50 spec Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108160 Signed-off-by: Vadym Shovkoplias --- src/compiler/glsl/builtin_functions.cpp | 30 - 1 file changed, 15 insertions(+), 15 deletions(-)

[Mesa-dev] [PATCH] glsl: Correct several built-in functions availability

2018-10-31 Thread Vadym Shovkoplias
zilla: https://bugs.freedesktop.org/show_bug.cgi?id=108160 Signed-off-by: Vadym Shovkoplias --- src/compiler/glsl/builtin_functions.cpp | 57 ++--- 1 file changed, 41 insertions(+), 16 deletions(-) diff --git a/src/compiler/glsl/builtin_functions.cpp b/src/compiler

[Mesa-dev] [PATCH] glsl/linker: Fix out variables linking during single stage

2018-10-24 Thread Vadym Shovkoplias
://bugs.freedesktop.org/show_bug.cgi?id=105731 Signed-off-by: Vadym Shovkoplias --- src/compiler/glsl/linker.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index 7db34ebf95..8b1b03322a 100644 --- a/src/compiler/glsl

[Mesa-dev] [PATCH] glsl/linker: Change the format of spec quotation

2018-10-10 Thread Vadym Shovkoplias
Also there is no "OpenGL ES Shading Language 4.00" spec, so change it to GLSL 4.00 spec. Signed-off-by: Vadym Shovkoplias --- src/compiler/glsl/linker.cpp | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/

[Mesa-dev] [PATCH] glsl: Check the subroutine associated functions names

2018-10-09 Thread Vadym Shovkoplias
tains two or more functions with the same name if the name is associated with a subroutine type." Fixes: * no-overloads.vert Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108109 Signed-off-by: Vadym Shovkoplias --- src/compiler/glsl/ast_to_hi

[Mesa-dev] [PATCH] glsl: Fix input/output structure matching across shader stages

2018-10-05 Thread Vadym Shovkoplias
t-location-struct.shader_test Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108250 Signed-off-by: Vadym Shovkoplias --- src/compiler/glsl/ast_to_hir.cpp| 2 +- src/compiler/glsl/link_varyings.cpp | 55 +++-- src/compiler/glsl_types.cpp | 17 ++--- sr

[Mesa-dev] [PATCH] glsl/linker: Check the subroutine associated functions names

2018-10-03 Thread Vadym Shovkoplias
lla: https://bugs.freedesktop.org/show_bug.cgi?id=108109 Signed-off-by: Vadym Shovkoplias --- src/compiler/glsl/linker.cpp | 40 1 file changed, 40 insertions(+) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index 3fde7e78d3..aca5488a1e 10

Re: [Mesa-dev] [PATCH] glsl/linker: Check the subroutine associated functions names

2018-10-02 Thread Vadym Shovkoplias
wrote: > > On 10/1/18 5:03 PM, Vadym Shovkoplias wrote: > > From Section 6.1.2 (Subroutines) of the GLSL 4.00 specification > > > > "A program will fail to compile or link if any shader > > or stage contains two or more functions with the same >

[Mesa-dev] [PATCH] glsl/linker: Check the subroutine associated functions names

2018-10-01 Thread Vadym Shovkoplias
lla: https://bugs.freedesktop.org/show_bug.cgi?id=108109 Signed-off-by: Vadym Shovkoplias --- src/compiler/glsl/linker.cpp | 40 1 file changed, 40 insertions(+) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index 3fde7e78d3..d0d017c7ff 10

[Mesa-dev] [PATCH] intel/blorp: Fix buffer blit with the max buffer sizes

2018-09-27 Thread Vadym Shovkoplias
Fixes: * fbo-blit-check-limits Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108088 Signed-off-by: Vadym Shovkoplias --- src/intel/blorp/blorp.h | 8 ++-- src/intel/blorp/blorp_blit.c | 8 ++-- src/mesa/drivers/dri/i965/brw_blorp.c | 20

[Mesa-dev] [PATCH v2] glsl/linker: Check the invariance of built-in special variables

2018-09-07 Thread Vadym Shovkoplias
ot; Fixes: * glsl-pcoord-invariant.shader_test * glsl-fcoord-invariant.shader_test * glsl-fface-invariant.shader_test Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107734 Signed-off-by: Vadym Shovkoplias --- src/compiler/glsl/linker.cpp | 66 ++

Re: [Mesa-dev] [PATCH] glsl/linker: Check the invariance of built-in special variables

2018-09-07 Thread Vadym Shovkoplias
g with > here IMO it's fine to have a separate pass for it. > > Reviewed-by: Tapani Pälli > > One tiny nit below .. > > > On 08/29/2018 12:16 PM, Vadym Shovkoplias wrote: > >> From Section 4.6.4 (Invariance and Linkage) of the GLSL ES 1.0 >> specificati

[Mesa-dev] [PATCH] glsl/linker: Check the invariance of built-in special variables

2018-08-29 Thread Vadym Shovkoplias
ot; Fixes: * glsl-pcoord-invariant.shader_test * glsl-fcoord-invariant.shader_test * glsl-fface-invariant.shader_test Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107734 Signed-off-by: Vadym Shovkoplias --- src/compiler/glsl/linker.cpp | 66 ++

[Mesa-dev] [PATCH] glsl/linker: Link all out vars from a shader objects on a single stage

2018-08-28 Thread Vadym Shovkoplias
bug.cgi?id=105731 Signed-off-by: Vadym Shovkoplias --- src/compiler/glsl/linker.cpp | 37 1 file changed, 37 insertions(+) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index 3ce78fe642..dbd76b7fcc 100644 --- a/src/compiler/glsl/

Re: [Mesa-dev] [PATCH] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-28 Thread Vadym Shovkoplias
> > > > Fixes: > > * interstage-multiple-shader-objects.shader_test > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101247 > > Signed-off-by: Vadym Shovkoplias > > --- > > src/compiler/glsl/link_interface_blocks.cpp | 8

[Mesa-dev] [PATCH] glsl/linker: Link all out vars from a shader objects on a single stage

2018-08-27 Thread Vadym Shovkoplias
bug.cgi?id=105731 Signed-off-by: Vadym Shovkoplias --- src/compiler/glsl/linker.cpp | 38 1 file changed, 38 insertions(+) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index 3ce78fe642..3b0c01c316 100644 --- a/src/compiler/glsl/

Re: [Mesa-dev] [PATCH v2] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-27 Thread Vadym Shovkoplias
I haven't got write permissions, so I'll appreciate if someone can push it. Thanks! On Mon, Aug 27, 2018 at 12:52 PM, Alejandro Piñeiro wrote: > On 27/08/18 11:12, Vadym Shovkoplias wrote: > > Hi Timothy, Alejandro, Marek, > > Thanks for review! Can we merge the patch

Re: [Mesa-dev] [PATCH v2] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-27 Thread Vadym Shovkoplias
r-objects.shader_test >>> >>> v2: >>> Update comment in ir.h since the usage of "used" field >>>has been extended. >>> >>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101247 >>> Signed-off-by: Vadym Shovkoplias >&

Re: [Mesa-dev] [PATCH] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-22 Thread Vadym Shovkoplias
I agree that this comment is obsolete now. I'll update the patch, thanks! On Wed, Aug 22, 2018 at 12:09 PM, Alejandro Piñeiro wrote: > On 21/08/18 11:42, Vadym Shovkoplias wrote: > > Hi Timothy, Alejandro, > > Thanks for the review comments! > I'd just like to menti

Re: [Mesa-dev] [PATCH] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-21 Thread Vadym Shovkoplias
gt; > >> "Only the input variables that are actually read need to be written > >> by the previous stage; it is allowed to have superfluous > >> declarations of input variables." > >> > >> Fixes: > >> * interstage-mu

Re: [Mesa-dev] [PATCH v2] drirc: Allow extension midshader for Metro Redux

2018-08-09 Thread Vadym Shovkoplias
ixes both Metro 2033 Redux and Metro Last Light Redux > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99730 > > Signed-off-by: Eero Tamminen > > Signed-off-by: Vadym Shovkoplias > > --- > > src/util/drirc | 4 > > 1 file changed,

Re: [Mesa-dev] [PATCH] i965: Disable guardband clipping on SandyBridge for odd dimensions

2018-07-26 Thread Vadym Shovkoplias
if (m00 != 0 && m11 != 0) { >>>> /* First, we compute the screen-space render area */ >>>> const float ss_ra_xmin = MIN3(0, m30 + m00, m30 - m00); >>>> >>> >>> ___ >>

Re: [Mesa-dev] [PATCH] i965: Disable guardband clipping on SandyBridge for odd dimensions

2018-05-29 Thread Vadym Shovkoplias
/* First, we compute the screen-space render area */ >const float ss_ra_xmin = MIN3(0, m30 + m00, m30 - m00); > -- > 2.7.4 > > _______ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freede

Re: [Mesa-dev] [PATCH] nir/lower_vec_to_movs: Only coalesce if the vec had a SSA destination

2018-03-26 Thread Vadym Shovkoplias
Tested on Haswell. Patch works well for me, thanks! Tested-by: Vadym Shovkoplias On Fri, Mar 23, 2018 at 8:35 PM, Jason Ekstrand wrote: > Otherwise we may end up trying to coalesce in a case such as > > ssa_1 = fadd r1, r2 > r3.x = fneg(r2); > r3 = vec4(ssa_1, ssa_1.y, ...) >

[Mesa-dev] [PATCH v2] mesa: add glsl version query (v4)

2018-02-13 Thread Vadym Shovkoplias
_mesa_get_shading_language_version() function to src/mesa/main/version.c. v4: - Add OpenGL version check. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104915 Signed-off-by: Andriy Khulap Signed-off-by: Vadym Shovkoplias --- src/mapi/glapi/gen/GL4x.xml | 1 + src/mesa/main

[Mesa-dev] [PATCH] mesa: add glsl version query (v4)

2018-02-13 Thread Vadym Shovkoplias
_mesa_get_shading_language_version() function to src/mesa/main/version.c. v4: - Add OpenGL version check. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104915 Signed-off-by: Andriy Khulap Signed-off-by: Vadym Shovkoplias --- src/mapi/glapi/gen/GL4x.xml | 1 + src/mesa/main

Re: [Mesa-dev] [PATCH] mesa: add glsl version query (v2)

2018-02-08 Thread Vadym Shovkoplias
Hi Brian, Thanks for review comments! We've just finished v3 of this patch. Regarding Piglit test I'll try to implement appropriate changes. Regards, Vadym On Wed, Feb 7, 2018 at 5:58 PM, Brian Paul wrote: > On 02/07/2018 03:01 AM, Vadym Shovkoplias wrote: > &g

[Mesa-dev] [PATCH] mesa: add glsl version query (v3)

2018-02-08 Thread Vadym Shovkoplias
_mesa_get_shading_language_version() function to src/mesa/main/version.c. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104915 Signed-off-by: Andriy Khulap Signed-off-by: Vadym Shovkoplias --- src/mapi/glapi/gen/GL4x.xml | 1 + src/mesa/main/get.c | 4 +++ src

[Mesa-dev] [PATCH] mesa: add glsl version query (v2)

2018-02-07 Thread Vadym Shovkoplias
Signed-off-by: Andriy Khulap Signed-off-by: Vadym Shovkoplias --- src/mapi/glapi/gen/GL4x.xml | 1 + src/mesa/main/get.c | 4 +++ src/mesa/main/get_hash_params.py | 3 ++ src/mesa/main/getstring.c| 74 src/mesa/main/version.h

[Mesa-dev] [PATCH] mesa: add glsl version query

2018-02-06 Thread Vadym Shovkoplias
From: Vadym Shovkoplias Add support for GL_NUM_SHADING_LANGUAGE_VERSIONS and glGetStringi for GL_SHADING_LANGUAGE_VERSION Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104915 Signed-off-by: Andriy Khulap Signed-off-by: Vadym Shovkoplias --- src/mapi/glapi/gen/GL4x.xml | 1

Re: [Mesa-dev] [PATCH] egl/x11: Remove unneeded free() on always null string

2017-12-06 Thread Vadym Shovkoplias
ules should be separate. > > Don't worry too much about it though, if people ask you to merge or > split commits, it's not that complicated to do for a v2 :) > > > > > 2017-12-01 17:41 GMT+02:00 Eric Engestrom : > > > > > On Friday, 2017-12-01 17:08

Re: [Mesa-dev] [PATCH] egl/x11: Remove unneeded free() on always null string

2017-12-01 Thread Vadym Shovkoplias
wrote: > On Friday, 2017-12-01 17:08:53 +0200, vadim.shovkopl...@gmail.com wrote: > > From: Vadym Shovkoplias > > > > In this condition dri2_dpy->driver_name string always equals > > NULL, so call to free() is useless > > > > Signed-off-by: Vadym Shovkopli