Re: [Mesa-dev] [PATCH] nouveau: fix double free when screen_create fails

2015-12-28 Thread samuel.pitoiset
, samuel.pitoiset wrote: On 27/10/2015 12:52, Emil Velikov wrote: On 27 October 2015 at 10:50, samuel.pitoiset wrote: On 27/10/2015 11:37, Emil Velikov wrote: On 22 October 2015 at 00:16, Julien Isorce wrote: The real fix is in nouveau_drm_winsys.c by setting dev to 0. Which means dev&#

Re: [Mesa-dev] [PATCH] nouveau: fix double free when screen_create fails

2015-10-27 Thread samuel.pitoiset
On 27/10/2015 12:52, Emil Velikov wrote: On 27 October 2015 at 10:50, samuel.pitoiset wrote: On 27/10/2015 11:37, Emil Velikov wrote: On 22 October 2015 at 00:16, Julien Isorce wrote: The real fix is in nouveau_drm_winsys.c by setting dev to 0. Which means dev's ownership has been p

Re: [Mesa-dev] [PATCH] nouveau: fix double free when screen_create fails

2015-10-27 Thread samuel.pitoiset
On 27/10/2015 11:37, Emil Velikov wrote: On 22 October 2015 at 00:16, Julien Isorce wrote: The real fix is in nouveau_drm_winsys.c by setting dev to 0. Which means dev's ownership has been passed to previous call. Other changes are there to be consistent with what the screen_create functions

Re: [Mesa-dev] [PATCH v2] nouveau: fix double free when screen_create fails

2015-10-27 Thread samuel.pitoiset
se if (dupfd) which was not closed on failure. Yes, it fixes both issues. On 27 October 2015 at 09:10, samuel.pitoiset mailto:samuel.pitoi...@gmail.com>> wrote: What about this one http://hastebin.com/uboruxicof.coffee ? This patch is loosely based on your first attempt, ex

Re: [Mesa-dev] [PATCH v2] nouveau: fix double free when screen_create fails

2015-10-27 Thread samuel.pitoiset
What about this one http://hastebin.com/uboruxicof.coffee ? This patch is loosely based on your first attempt, except that I removed the call to nouveau_device_del() in nouveau_drm_screen_create(). On 27/10/2015 09:52, Julien Isorce wrote: This patch prevents to call nouveau_device_del twice

Re: [Mesa-dev] [PATCH v2 1/7] nvc0: fix crash when nv50_miptree_from_handle fails

2015-10-20 Thread samuel.pitoiset
Is there a particular situation where nv50_miptree_from_handle() fails? And did you check nv50? Anyway, this patch is: Reviewed-by: Samuel Pitoiset On 20/10/2015 18:34, Julien Isorce wrote: Signed-off-by: Julien Isorce --- src/gallium/drivers/nouveau/nvc0/nvc0_resource.c | 3 ++- 1 file c

Re: [Mesa-dev] [PATCH] nouveau: use bool instead of boolean

2015-07-18 Thread samuel.pitoiset
On 17/07/2015 23:08, Ilia Mirkin wrote: On Fri, Jul 17, 2015 at 5:02 PM, Emil Velikov wrote: On 16/07/15 22:39, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 2 +- .../drivers/nouveau/codegen/nv50_ir_driver.h | 14

Re: [Mesa-dev] [PATCH] nvc0: fix geometry program revalidation of clipping params

2015-07-16 Thread samuel.pitoiset
Seems reasonable. Please, let me know the result of the full piglit run. If everything is okay, this patch is : Reviewed-by: Samuel Pitoiset On 13/07/2015 20:08, Ilia Mirkin wrote: This was, btw, introduced in commit 3a8ae6ac243b (nvc0: adapt to new clip state). Back then there was no real ge

Re: [Mesa-dev] [PATCH] nv50: limit the maximum number of samplers to 16

2015-07-13 Thread samuel.pitoiset
On 13/07/2015 18:08, Emil Velikov wrote: Is there some widely know issue with it ? mesa & envytools does not mention anything (based of a quick scan). There is no know issue with NV50_3D_BIND_TSC2, but Ilia doesn't seem to want to use it. :-) That's why I followed his suggestion by reducing