Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v2)

2017-07-16 Thread Wu, Zhongmin
Antognolli, Rafael Cc: Chris Wilson; ML mesa-dev; Marathe, Yogesh; Wu, Zhongmin; Liu, Zhiquan; Kondapally, Kalyan; Chad Versace; Eric Engestrom; Emil Velikov; Rob Clark; Kenneth Graunke; Widawsky, Benjamin; Kristian H . Kristensen; Timothy Arceri; Dominik Behr Subject: Re: [Mesa-dev] [EGL android: a

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v2)

2017-07-14 Thread Kenneth Graunke
On Friday, July 14, 2017 10:50:39 AM PDT Rafael Antognolli wrote: > On Sat, Jul 15, 2017 at 01:58:19AM +0900, Tomasz Figa wrote: > > > So, the right place to do so would be inside platform_android.c, > > > right? And since I don't see any private struct that could store such > > > fence > > > ther

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v2)

2017-07-14 Thread Rafael Antognolli
On Sat, Jul 15, 2017 at 01:58:19AM +0900, Tomasz Figa wrote: > > So, the right place to do so would be inside platform_android.c, > > right? And since I don't see any private struct that could store such fence > > there, one option would be to extend the struct dri2_egl_surface for > > android, >

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v2)

2017-07-14 Thread Tomasz Figa
[resend from right email address, without bouncing recipients and with all the people involved in v1... Zhongmin, please remember to add all people participating in the discussion to CC next time.] On Sat, Jul 15, 2017 at 1:45 AM, Rafael Antognolli wrote: > On Fri, Jul 14, 2017 at 09:13:49AM +010

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v2)

2017-07-14 Thread Rafael Antognolli
On Sat, Jul 15, 2017 at 01:52:43AM +0900, Tomasz Figa wrote: > Hi Rafael, > > On Sat, Jul 15, 2017 at 1:45 AM, Rafael Antognolli > wrote: > > On Fri, Jul 14, 2017 at 09:13:49AM +0100, Chris Wilson wrote: > >> Quoting Zhongmin Wu (2017-07-14 07:55:45) > [snip] > >> > extern uint32_t > >> > diff -

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v2)

2017-07-14 Thread Tomasz Figa
Hi Rafael, On Sat, Jul 15, 2017 at 1:45 AM, Rafael Antognolli wrote: > On Fri, Jul 14, 2017 at 09:13:49AM +0100, Chris Wilson wrote: >> Quoting Zhongmin Wu (2017-07-14 07:55:45) [snip] >> > extern uint32_t >> > diff --git a/src/mesa/drivers/dri/i915/intel_screen.c >> > b/src/mesa/drivers/dri/i9

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v2)

2017-07-14 Thread Rafael Antognolli
On Fri, Jul 14, 2017 at 09:13:49AM +0100, Chris Wilson wrote: > Quoting Zhongmin Wu (2017-07-14 07:55:45) > > Before we queued the buffer with a invalid fence (-1), it will > > make some benchmarks failed to test such as flatland. > > > > Now we get the out fence during the flushing buffer and the

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v2)

2017-07-14 Thread Emil Velikov
Hi Zhongmin Wu, On 14 July 2017 at 07:55, Zhongmin Wu wrote: > Before we queued the buffer with a invalid fence (-1), it will > make some benchmarks failed to test such as flatland. > > Now we get the out fence during the flushing buffer and then pass > it to SurfaceFlinger in eglSwapbuffer funct

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v2)

2017-07-14 Thread Eric Engestrom
On Friday, 2017-07-14 14:55:45 +0800, Zhongmin Wu wrote: > Before we queued the buffer with a invalid fence (-1), it will > make some benchmarks failed to test such as flatland. > > Now we get the out fence during the flushing buffer and then pass > it to SurfaceFlinger in eglSwapbuffer function.

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v2)

2017-07-14 Thread Wu, Zhongmin
: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v2) Quoting Zhongmin Wu (2017-07-14 07:55:45) > Before we queued the buffer with a invalid fence (-1), it will make > some benchmarks failed to test such as flatland. > >

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v2)

2017-07-14 Thread Chris Wilson
Quoting Zhongmin Wu (2017-07-14 07:55:45) > Before we queued the buffer with a invalid fence (-1), it will > make some benchmarks failed to test such as flatland. > > Now we get the out fence during the flushing buffer and then pass > it to SurfaceFlinger in eglSwapbuffer function. > > v2: a) Als

[Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v2)

2017-07-14 Thread Zhongmin Wu
Before we queued the buffer with a invalid fence (-1), it will make some benchmarks failed to test such as flatland. Now we get the out fence during the flushing buffer and then pass it to SurfaceFlinger in eglSwapbuffer function. v2: a) Also implement the fence in cancelBuffer. b) The last s