Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/bdw: Fix 3DSTATE_VF_INSTANCING when the edge flag is used

2015-08-03 Thread Neil Roberts
Hi Emil, I posted a v2 of this patch because the v1 wouldn't work in combination with a fix for bug 84677. I think it would be better to wait for review on those two and land both of them instead of this patch. Neither of them are particulary urgent bugs so it's probably not worth worrying about

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/bdw: Fix 3DSTATE_VF_INSTANCING when the edge flag is used

2015-08-01 Thread Emil Velikov
Hello Neil, On 10 July 2015 at 18:04, Neil Roberts n...@linux.intel.com wrote: When the edge flag element is enabled then the elements are slightly reordered so that the edge flag is always the last one. This was confusing the code to upload the 3DSTATE_VF_INSTANCING state because that is

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/bdw: Fix 3DSTATE_VF_INSTANCING when the edge flag is used

2015-07-10 Thread Chris Forbes
Surely the *right* thing would be to have the correct order expressed in brw-vb.*, instead so you don't have this workaround in multiple places. As a minimal fix for stable though, this seems OK, so - Reviewed-by: Chris Forbes chr...@ijw.co.nz On Sat, Jul 11, 2015 at 5:04 AM, Neil Roberts