On Tue, 2018-06-26 at 23:49 +0200, Fredrik Höglund wrote:
> These are not automatically performed during a render pass instance.
> 
> Cc: <mesa-sta...@lists.freedesktop.org>
> Signed-off-by: Fredrik Höglund <fred...@kde.org>


A similar patch like this, 457ac6ce1e2 ("radv: ignore subpass self-
dependencies"), is on master, but without the @stable CC.


Unless told the contrary, I'll keep it out of 18.2 stable branch.


        J.A.

> ---
>  src/amd/vulkan/radv_pass.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/amd/vulkan/radv_pass.c b/src/amd/vulkan/radv_pass.c
> index c41d4c2ba92..2827f5f1a8d 100644
> --- a/src/amd/vulkan/radv_pass.c
> +++ b/src/amd/vulkan/radv_pass.c
> @@ -172,7 +172,13 @@ VkResult radv_CreateRenderPass(
>       }
>  
>       for (unsigned i = 0; i < pCreateInfo->dependencyCount; ++i) {
> +             uint32_t src = pCreateInfo->pDependencies[i].srcSubpass;
>               uint32_t dst = pCreateInfo->pDependencies[i].dstSubpass;
> +
> +             /* Ignore subpass self-dependencies */
> +             if (src == dst)
> +                     continue;
> +
>               if (dst == VK_SUBPASS_EXTERNAL) {
>                       if (pCreateInfo->pDependencies[i].dstStageMask != 
> VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT)
>                               pass->end_barrier.src_stage_mask |= 
> pCreateInfo->pDependencies[i].srcStageMask;

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to