On 30.07.2015 01:27, Anuj Phogat wrote:
On Wed, Jul 29, 2015 at 12:20 AM, Iago Toral ito...@igalia.com wrote:
Funny, we had 3 instances of the same function with the same
implementation :), there is still util_is_power_of_two in Gallium btw.
Yes. I wasn't sure if we can use main/imports.h in
On Wed, Jul 29, 2015 at 12:20 AM, Iago Toral ito...@igalia.com wrote:
Funny, we had 3 instances of the same function with the same
implementation :), there is still util_is_power_of_two in Gallium btw.
Yes. I wasn't sure if we can use main/imports.h in gallium. So, I didn't
touch it.
It seems a bit weird to modify the the is_power_of_two functions in
format_parser.py, was that intentional? It doesn't look like those
functions are actually used anywhere so maybe we could just remove them,
although it would probably make sense to do that in a separate patch.
Regards,
- Neil
On Wed, Jul 29, 2015 at 8:16 AM, Neil Roberts n...@linux.intel.com wrote:
It seems a bit weird to modify the the is_power_of_two functions in
format_parser.py, was that intentional? It doesn't look like those
functions are actually used anywhere so maybe we could just remove them,
although it
Funny, we had 3 instances of the same function with the same
implementation :), there is still util_is_power_of_two in Gallium btw.
Reviewed-by: Iago Toral Quiroga ito...@igalia.com
On Tue, 2015-07-28 at 16:48 -0700, Anuj Phogat wrote:
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/common/meta_blit.c | 6 +++---
src/mesa/drivers/dri/i915/i915_texstate.c | 2 +-
src/mesa/drivers/dri/i965/brw_fs_vector_splitting.cpp | 2 +-
src/mesa/drivers/dri/i965/brw_reg.h
Reviewed-by: Tapani Pälli tapani.pa...@intel.com
On 07/29/2015 02:48 AM, Anuj Phogat wrote:
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
---
src/mesa/drivers/common/meta_blit.c | 6 +++---
src/mesa/drivers/dri/i915/i915_texstate.c | 2 +-