Re: [Mesa-dev] [PATCH] Fix for throwing BadDrawable (invalid Pixmap or Window parameter) by Xserver

2013-09-05 Thread Maniak, Lukasz
Original explanatory text: Fix for throwing BadDrawable (invalid Pixmap or Window parameter) by Xserver when calling XCreatePixmap or fill_bitmap from DRI_glXUseXFont. currentDrawable which came from __glXGetCurrentContext was not correct in this case, we use

Re: [Mesa-dev] [PATCH] Fix for throwing BadDrawable (invalid Pixmap or Window parameter) by Xserver

2013-09-05 Thread Alexander Monakov
On Thu, Sep 5, 2013 at 6:25 PM, Maniak, Lukasz lukasz.man...@intel.com wrote: Original explanatory text: Fix for throwing BadDrawable (invalid Pixmap or Window parameter) by Xserver when calling XCreatePixmap or fill_bitmap from DRI_glXUseXFont. currentDrawable which came

Re: [Mesa-dev] [PATCH] Fix for throwing BadDrawable (invalid Pixmap or Window parameter) by Xserver

2013-09-05 Thread Alexander Monakov
On Thu, Sep 5, 2013 at 6:40 PM, Alexander Monakov amona...@gmail.com wrote: But it doesn't make sense to call glXUseXFont without a current context. However ARB_create_context allows to make a context current without an associated drawable. ___

[Mesa-dev] [PATCH] Fix for throwing BadDrawable (invalid Pixmap or Window parameter) by Xserver

2013-09-04 Thread Lukasz Maniak
Signed-off-by: Lukasz Maniak lukasz.man...@intel.com --- src/glx/xfont.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/glx/xfont.c b/src/glx/xfont.c index 316c585..60e28ab 100644 --- a/src/glx/xfont.c +++ b/src/glx/xfont.c @@ -215,7 +215,6 @@ _X_HIDDEN void

Re: [Mesa-dev] [PATCH] Fix for throwing BadDrawable (invalid Pixmap or Window parameter) by Xserver

2013-09-04 Thread Ian Romanick
The explanatory text from the mangled version of the patch should be included here as well. Can you give some more explanation of how this can occur? I'd like to have a piglit test. Looking at the documentation for glXUseXFont, there needs to be a valid context bound, and there is some