Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

2016-07-25 Thread Christian König
Am 22.07.2016 um 17:21 schrieb Emil Velikov: On 22 July 2016 at 09:42, Christian König wrote: Am 22.07.2016 um 03:37 schrieb Rob Clark: On Thu, Jul 21, 2016 at 9:35 PM, Rob Clark wrote: On Thu, Jul 21, 2016 at 1:48 PM, Vedran Miletić wrote: LLVM and Mesa both define the DEBUG macro in inco

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

2016-07-25 Thread Brian Paul
On 07/22/2016 11:40 AM, Jose Fonseca wrote: (2nd try. 1st email is being held due to size.) On 21/07/16 18:48, Vedran Miletić wrote: LLVM and Mesa both define the DEBUG macro in incompatible ways. As a general practice, we should avoid using such generic names when it is possible to do so. Thi

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

2016-07-22 Thread Matt Turner
On Thu, Jul 21, 2016 at 10:48 AM, Vedran Miletić wrote: > LLVM and Mesa both define the DEBUG macro in incompatible ways. As a > general practice, we should avoid using such generic names when it is > possible to do so. > > This patch renames all occurrences of the DEBUG macro to MESA_DEBUG, > and

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

2016-07-22 Thread Jose Fonseca
(2nd try. 1st email is being held due to size.) On 21/07/16 18:48, Vedran Miletić wrote: LLVM and Mesa both define the DEBUG macro in incompatible ways. As a general practice, we should avoid using such generic names when it is possible to do so. This patch renames all occurrences of the DEBUG

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

2016-07-22 Thread Rob Clark
On Fri, Jul 22, 2016 at 4:39 AM, Vedran Miletić wrote: > On 07/22/2016 03:37 AM, Rob Clark wrote: >> >> On Thu, Jul 21, 2016 at 9:35 PM, Rob Clark wrote: >>> >>> On Thu, Jul 21, 2016 at 1:48 PM, Vedran Miletić >>> wrote: LLVM and Mesa both define the DEBUG macro in incompatible ways. A

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

2016-07-22 Thread Jose Fonseca
On 22/07/16 16:21, Emil Velikov wrote: On 22 July 2016 at 09:42, Christian König wrote: Am 22.07.2016 um 03:37 schrieb Rob Clark: On Thu, Jul 21, 2016 at 9:35 PM, Rob Clark wrote: On Thu, Jul 21, 2016 at 1:48 PM, Vedran Miletić wrote: LLVM and Mesa both define the DEBUG macro in incompa

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

2016-07-22 Thread Emil Velikov
On 22 July 2016 at 09:42, Christian König wrote: > Am 22.07.2016 um 03:37 schrieb Rob Clark: >> >> On Thu, Jul 21, 2016 at 9:35 PM, Rob Clark wrote: >>> >>> On Thu, Jul 21, 2016 at 1:48 PM, Vedran Miletić >>> wrote: LLVM and Mesa both define the DEBUG macro in incompatible ways. As a >

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

2016-07-22 Thread Christian König
Am 22.07.2016 um 03:37 schrieb Rob Clark: On Thu, Jul 21, 2016 at 9:35 PM, Rob Clark wrote: On Thu, Jul 21, 2016 at 1:48 PM, Vedran Miletić wrote: LLVM and Mesa both define the DEBUG macro in incompatible ways. As a general practice, we should avoid using such generic names when it is possibl

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

2016-07-22 Thread Vedran Miletić
On 07/22/2016 03:37 AM, Rob Clark wrote: On Thu, Jul 21, 2016 at 9:35 PM, Rob Clark wrote: On Thu, Jul 21, 2016 at 1:48 PM, Vedran Miletić wrote: LLVM and Mesa both define the DEBUG macro in incompatible ways. As a general practice, we should avoid using such generic names when it is possible

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

2016-07-21 Thread Rob Clark
On Thu, Jul 21, 2016 at 9:35 PM, Rob Clark wrote: > On Thu, Jul 21, 2016 at 1:48 PM, Vedran Miletić wrote: >> LLVM and Mesa both define the DEBUG macro in incompatible ways. As a >> general practice, we should avoid using such generic names when it is >> possible to do so. >> >> This patch rename

Re: [Mesa-dev] [PATCH] Rename the DEBUG macro to MESA_DEBUG

2016-07-21 Thread Rob Clark
On Thu, Jul 21, 2016 at 1:48 PM, Vedran Miletić wrote: > LLVM and Mesa both define the DEBUG macro in incompatible ways. As a > general practice, we should avoid using such generic names when it is > possible to do so. > > This patch renames all occurrences of the DEBUG macro to MESA_DEBUG, > and