Re: [Mesa-dev] [PATCH] ac, radv: fix removing the vec3 restriction on SI

2019-06-03 Thread Samuel Pitoiset
On 6/3/19 9:33 PM, Marek Olšák wrote: SI doesn't support buffer_load_dwordx3 and buffer_store_dwordx3, but it supports buffer_load_format_xyz and buffer_store_format_xyz. OK, I will update. Marek On Mon, Jun 3, 2019 at 9:09 AM Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote:

Re: [Mesa-dev] [PATCH] ac, radv: fix removing the vec3 restriction on SI

2019-06-03 Thread Marek Olšák
SI doesn't support buffer_load_dwordx3 and buffer_store_dwordx3, but it supports buffer_load_format_xyz and buffer_store_format_xyz. Marek On Mon, Jun 3, 2019 at 9:09 AM Samuel Pitoiset wrote: > I thought LLVM was able to handle that itself but actually it > does not. That means we shouldn't

Re: [Mesa-dev] [PATCH] ac, radv: fix removing the vec3 restriction on SI

2019-06-03 Thread Samuel Pitoiset
On 6/3/19 3:48 PM, Matt Arsenault wrote: On Jun 3, 2019, at 9:13 AM, Samuel Pitoiset wrote: I thought LLVM was able to handle that itself but actually it does not. That means we shouldn't try to emit vec3 on SI because it's unsupported. It should. Can you file a bug with an example that

Re: [Mesa-dev] [PATCH] ac, radv: fix removing the vec3 restriction on SI

2019-06-03 Thread Matt Arsenault
> On Jun 3, 2019, at 9:13 AM, Samuel Pitoiset wrote: > > I thought LLVM was able to handle that itself but actually it > does not. That means we shouldn't try to emit vec3 on SI because > it's unsupported. > It should. Can you file a bug with an example that doesn’t work? > Fixes:

[Mesa-dev] [PATCH] ac, radv: fix removing the vec3 restriction on SI

2019-06-03 Thread Samuel Pitoiset
I thought LLVM was able to handle that itself but actually it does not. That means we shouldn't try to emit vec3 on SI because it's unsupported. Fixes: 6970a9a6ca9 ("ac,radv: remove the vec3 restriction with LLVM 9+")" Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c| 12