Re: [Mesa-dev] [PATCH] amd/addrlib: Rename the GB_ADDR_CONFIGs to GB_ADDR_CONFIG_{SI, GFX9}

2017-09-27 Thread Nicholas Miell
On 09/27/2017 11:53 AM, Nicolai Hähnle wrote: > On 27.09.2017 20:42, Nicholas Miell wrote: >> Giving the same name to two different types violates the C++ One >> Definition >> Rule and gcc will complain about it in LTO builds. > > Oh my. What does the gcc warning look like? (I assume it's just a

Re: [Mesa-dev] [PATCH] amd/addrlib: Rename the GB_ADDR_CONFIGs to GB_ADDR_CONFIG_{SI, GFX9}

2017-09-27 Thread Nicolai Hähnle
On 27.09.2017 20:42, Nicholas Miell wrote: Giving the same name to two different types violates the C++ One Definition Rule and gcc will complain about it in LTO builds. Oh my. What does the gcc warning look like? (I assume it's just a warning.) Since these are auto-generated headers which are

[Mesa-dev] [PATCH] amd/addrlib: Rename the GB_ADDR_CONFIGs to GB_ADDR_CONFIG_{SI, GFX9}

2017-09-27 Thread Nicholas Miell
Giving the same name to two different types violates the C++ One Definition Rule and gcc will complain about it in LTO builds. Signed-off-by: Nicholas Miell --- src/amd/addrlib/gfx9/gfx9addrlib.cpp| 2 +- src/amd/addrlib/inc/chip/gfx9/gfx9_gb_reg.h | 2 +- src/amd/addrlib/inc/chip/r800/s