Re: [Mesa-dev] [PATCH] anv: Take write mask into account in has_color_buffer_write_enabled

Seems reasonable. Only one comment which you can feel free to ignore. Reviewed-by: Jason Ekstrand On Fri, Jan 5, 2018 at 7:23 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Looks good to me too. > > Reviewed-by: Lionel Landwerlin

Re: [Mesa-dev] [PATCH] anv: Take write mask into account in has_color_buffer_write_enabled

Looks good to me too. Reviewed-by: Lionel Landwerlin Thanks a lot! - Lionel On 05/01/18 09:19, Iago Toral wrote: Looks good to me, unless Jason or Lionel say otherwise: Reviewed-by: Iago Toral Quiroga Iago On Thu, 2018-01-04 at 18:13

Re: [Mesa-dev] [PATCH] anv: Take write mask into account in has_color_buffer_write_enabled

Looks good to me, unless Jason or Lionel say otherwise: Reviewed-by: Iago Toral Quiroga Iago On Thu, 2018-01-04 at 18:13 +, Alex Smith wrote: > If we have a color attachment, but its writes are masked, this would > have still returned true. This is inconsistent with how

[Mesa-dev] [PATCH] anv: Take write mask into account in has_color_buffer_write_enabled

If we have a color attachment, but its writes are masked, this would have still returned true. This is inconsistent with how HasWriteableRT in 3DSTATE_PS_BLEND is set, which does take the mask into account. This could lead to PixelShaderHasUAV not being set in 3DSTATE_PS_EXTRA if the fragment