Re: [Mesa-dev] [PATCH] anv: fix alphaToCoverage when there is no color attachment

2019-05-02 Thread Iago Toral
On Tue, 2019-04-30 at 17:29 -0500, Jason Ekstrand wrote: > On Tue, Apr 30, 2019 at 4:36 AM Iago Toral wrote: > > Hi Jason, > > > > it seems that this was never addressed so I'll try to take it from > > here. A couple of comments regarding your feedback: > > > > We always setup a null render

Re: [Mesa-dev] [PATCH] anv: fix alphaToCoverage when there is no color attachment

2019-04-30 Thread Jason Ekstrand
On Tue, Apr 30, 2019 at 4:36 AM Iago Toral wrote: > Hi Jason, > > it seems that this was never addressed so I'll try to take it from here. A > couple of comments regarding your feedback: > > We always setup a null render target if we don't have any, so I think that > part of the patch is not

Re: [Mesa-dev] [PATCH] anv: fix alphaToCoverage when there is no color attachment

2019-04-30 Thread Iago Toral
Hi Jason, it seems that this was never addressed so I'll try to take it from here. A couple of comments regarding your feedback: We always setup a null render target if we don't have any, so I think that part of the patch is not necessary. I checked that simply making sure that we don't remove the

Re: [Mesa-dev] [PATCH] anv: fix alphaToCoverage when there is no color attachment

2019-03-25 Thread Samuel Iglesias Gonsálvez
On Fri, 2019-03-22 at 10:06 -0500, Jason Ekstrand wrote: > I'm confused. Don't we always have a NULL render target at location > 0? Is the problem really that we need the NULL render target or is > it that we can't throw away the alpha component of the RT write in > the shader? It is the

Re: [Mesa-dev] [PATCH] anv: fix alphaToCoverage when there is no color attachment

2019-03-22 Thread Jason Ekstrand
I'm confused. Don't we always have a NULL render target at location 0? Is the problem really that we need the NULL render target or is it that we can't throw away the alpha component of the RT write in the shader? If it's that we can't throw away the alpha component of the RT write, then I'd

Re: [Mesa-dev] [PATCH] anv: fix alphaToCoverage when there is no color attachment

2019-03-04 Thread Samuel Iglesias Gonsálvez
Still unreviewed. Sam On Thu, 2019-02-21 at 12:08 +0100, Samuel Iglesias Gonsálvez wrote: > CL#3532 added a test for alpha to coverage without a color > attachment. > First the test draws a primitive with alpha 0 and a subpass with only > a depth buffer. No writes to a depth buffer are expected.

[Mesa-dev] [PATCH] anv: fix alphaToCoverage when there is no color attachment

2019-02-21 Thread Samuel Iglesias Gonsálvez
CL#3532 added a test for alpha to coverage without a color attachment. First the test draws a primitive with alpha 0 and a subpass with only a depth buffer. No writes to a depth buffer are expected. Then a second draw with a color buffer and the same depth buffer is done to verify the depth buffer