Re: [Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-15 Thread Sedat Dilek
On Sun, Mar 1, 2015 at 8:51 PM, Marc Dietrich wrote: > Am Sonntag 01 März 2015, 17:28:18 schrieb Sedat Dilek: >> On Sun, Mar 1, 2015 at 3:09 PM, Marc Dietrich wrote: >> > This patch simplifies the visibility compiler flag detection in configure >> > and makes it more generic to also support compi

Re: [Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-13 Thread Marc Dietrich
Am Donnerstag, 12. März 2015, 19:57:39 schrieb Sedat Dilek: > On Sun, Mar 1, 2015 at 8:51 PM, Marc Dietrich wrote: > > Am Sonntag 01 März 2015, 17:28:18 schrieb Sedat Dilek: > >> On Sun, Mar 1, 2015 at 3:09 PM, Marc Dietrich wrote: > >> > This patch simplifies the visibility compiler flag detecti

Re: [Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-03 Thread Emil Velikov
On 3 March 2015 at 05:21, Alan Coopersmith wrote: > On 03/ 1/15 02:31 PM, Emil Velikov wrote: >> >> - Considering the lack of -fvisibility, what is the normal visibility >> "level" - hidden or default ? If the latter this means that every >> library/module built exports a ton of internal symbols

Re: [Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-02 Thread Alan Coopersmith
On 03/ 1/15 02:31 PM, Emil Velikov wrote: - Considering the lack of -fvisibility, what is the normal visibility "level" - hidden or default ? If the latter this means that every library/module built exports a ton of internal symbols. Default, unless you pass the -xldscope=hidden flag to Studi

Re: [Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-01 Thread Sedat Dilek
On Sun, Mar 1, 2015 at 5:45 PM, Emil Velikov wrote: > On 01/03/15 14:09, Marc Dietrich wrote: >> This patch simplifies the visibility compiler flag detection in configure and >> makes it more generic to also support compilers other than gcc. >> >> Cc: Emil Velikov >> Signed-off-by: Marc Dietrich

Re: [Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-01 Thread Sedat Dilek
On Sun, Mar 1, 2015 at 3:09 PM, Marc Dietrich wrote: > This patch simplifies the visibility compiler flag detection in configure and > makes it more generic to also support compilers other than gcc. > > Cc: Emil Velikov > Signed-off-by: Marc Dietrich > [ CC Matt ] What happened to 2/2 (mapi tl

Re: [Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-01 Thread Sedat Dilek
On Sun, Mar 1, 2015 at 11:31 PM, Emil Velikov wrote: > On 01/03/15 21:05, Alan Coopersmith wrote: >> On 03/ 1/15 10:57 AM, Emil Velikov wrote: >>> On 01/03/15 18:30, Matt Turner wrote: On Sun, Mar 1, 2015 at 6:09 AM, Marc Dietrich wrote: > This patch simplifies the visibility compiler fl

Re: [Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-01 Thread Sedat Dilek
On Sun, Mar 1, 2015 at 7:30 PM, Matt Turner wrote: > On Sun, Mar 1, 2015 at 6:09 AM, Marc Dietrich wrote: >> This patch simplifies the visibility compiler flag detection in configure and >> makes it more generic to also support compilers other than gcc. > > This simplification relies on the assum

Re: [Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-01 Thread Emil Velikov
On 1 March 2015 at 22:38, Sedat Dilek wrote: > On Sun, Mar 1, 2015 at 11:31 PM, Emil Velikov > wrote: >> On 01/03/15 21:05, Alan Coopersmith wrote: >>> On 03/ 1/15 10:57 AM, Emil Velikov wrote: On 01/03/15 18:30, Matt Turner wrote: > On Sun, Mar 1, 2015 at 6:09 AM, Marc Dietrich wrote:

Re: [Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-01 Thread Emil Velikov
On 01/03/15 21:05, Alan Coopersmith wrote: > On 03/ 1/15 10:57 AM, Emil Velikov wrote: >> On 01/03/15 18:30, Matt Turner wrote: >>> On Sun, Mar 1, 2015 at 6:09 AM, Marc Dietrich wrote: This patch simplifies the visibility compiler flag detection in configure and makes it more generi

Re: [Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-01 Thread Alan Coopersmith
On 03/ 1/15 10:57 AM, Emil Velikov wrote: On 01/03/15 18:30, Matt Turner wrote: On Sun, Mar 1, 2015 at 6:09 AM, Marc Dietrich wrote: This patch simplifies the visibility compiler flag detection in configure and makes it more generic to also support compilers other than gcc. This simplificati

Re: [Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-01 Thread Marc Dietrich
Am Sonntag 01 März 2015, 17:28:18 schrieb Sedat Dilek: > On Sun, Mar 1, 2015 at 3:09 PM, Marc Dietrich wrote: > > This patch simplifies the visibility compiler flag detection in configure > > and makes it more generic to also support compilers other than gcc. > > > > Cc: Emil Velikov > > Signed-

Re: [Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-01 Thread Marc Dietrich
Am Sonntag 01 März 2015, 10:30:08 schrieb Matt Turner: > On Sun, Mar 1, 2015 at 6:09 AM, Marc Dietrich wrote: > > This patch simplifies the visibility compiler flag detection in configure > > and makes it more generic to also support compilers other than gcc. > > This simplification relies on the

Re: [Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-01 Thread Emil Velikov
On 01/03/15 18:30, Matt Turner wrote: > On Sun, Mar 1, 2015 at 6:09 AM, Marc Dietrich wrote: >> This patch simplifies the visibility compiler flag detection in configure and >> makes it more generic to also support compilers other than gcc. > > This simplification relies on the assumption that co

Re: [Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-01 Thread Matt Turner
On Sun, Mar 1, 2015 at 6:09 AM, Marc Dietrich wrote: > This patch simplifies the visibility compiler flag detection in configure and > makes it more generic to also support compilers other than gcc. This simplification relies on the assumption that compilers support -fvisibility=... if and only i

Re: [Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-01 Thread Emil Velikov
On 01/03/15 14:09, Marc Dietrich wrote: > This patch simplifies the visibility compiler flag detection in configure and > makes it more generic to also support compilers other than gcc. > > Cc: Emil Velikov > Signed-off-by: Marc Dietrich > Reviewed-by: Emil Velikov Looks great thank you. I'm

[Mesa-dev] [PATCH] configure: simplify visibility compiler flag detection

2015-03-01 Thread Marc Dietrich
This patch simplifies the visibility compiler flag detection in configure and makes it more generic to also support compilers other than gcc. Cc: Emil Velikov Signed-off-by: Marc Dietrich --- configure.ac | 32 +++- 1 file changed, 7 insertions(+), 25 deletions(-)