Re: [Mesa-dev] [PATCH] draw: fix splitting of line loops

2015-10-20 Thread Brian Paul
On 10/19/2015 08:29 AM, Brian Paul wrote: On 10/19/2015 04:53 AM, Roland Scheidegger wrote: I thought just changing the prim type would cause the loop to not get closed in the end, albeit I looked at it only briefly (I thought the DRAW_SPLIT_AFTER/BEFORE flags were supposed to be able to deal

Re: [Mesa-dev] [PATCH] draw: fix splitting of line loops (v2)

2015-10-20 Thread Roland Scheidegger
Looks good to me - this stuff is tricky... Reviewed-by: Roland Scheidegger Am 21.10.2015 um 01:21 schrieb Brian Paul: > When the draw module splits long line loops, the sections are emitted > as line strips. But the primitive type wasn't set correctly so each > section was

[Mesa-dev] [PATCH] draw: fix splitting of line loops (v2)

2015-10-20 Thread Brian Paul
When the draw module splits long line loops, the sections are emitted as line strips. But the primitive type wasn't set correctly so each section was being drawn as a loop, introducing extra line segments. To fix this, we pass a new DRAW_LINE_LOOP_AS_STRIP flag to the run() function. The

Re: [Mesa-dev] [PATCH] draw: fix splitting of line loops

2015-10-19 Thread Roland Scheidegger
I thought just changing the prim type would cause the loop to not get closed in the end, albeit I looked at it only briefly (I thought the DRAW_SPLIT_AFTER/BEFORE flags were supposed to be able to deal with this but couldn't figure out how). But if this works correctly, Reviewed-by: Roland

Re: [Mesa-dev] [PATCH] draw: fix splitting of line loops

2015-10-19 Thread Brian Paul
On 10/19/2015 04:53 AM, Roland Scheidegger wrote: I thought just changing the prim type would cause the loop to not get closed in the end, albeit I looked at it only briefly (I thought the DRAW_SPLIT_AFTER/BEFORE flags were supposed to be able to deal with this but couldn't figure out how). But

[Mesa-dev] [PATCH] draw: fix splitting of line loops

2015-10-17 Thread Brian Paul
When the draw module splits long line loops, the sections are emitted as line strips. But the primitive type wasn't set correctly so each section was being drawn as a loop, introducing extra line segments. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=81174 ---