Re: [Mesa-dev] [PATCH] dri3: Only update number of back buffers in loader_dri3_get_buffers

2018-05-09 Thread Michel Dänzer
On 2018-05-05 12:59 PM, Jason Ekstrand wrote: > On Wed, May 2, 2018 at 2:35 AM, Michel Dänzer wrote: > >> From: Michel Dänzer >> >> And only free no longer needed back buffers there as well. >> >> We want to stick to the same back buffer throughout a frame, otherwise >> we can run into various i

Re: [Mesa-dev] [PATCH] dri3: Only update number of back buffers in loader_dri3_get_buffers

2018-05-05 Thread Jason Ekstrand
On Wed, May 2, 2018 at 2:35 AM, Michel Dänzer wrote: > From: Michel Dänzer > > And only free no longer needed back buffers there as well. > > We want to stick to the same back buffer throughout a frame, otherwise > we can run into various issues. > > Bugzilla: https://bugs.freedesktop.org/105906

[Mesa-dev] [PATCH] dri3: Only update number of back buffers in loader_dri3_get_buffers

2018-05-02 Thread Michel Dänzer
From: Michel Dänzer And only free no longer needed back buffers there as well. We want to stick to the same back buffer throughout a frame, otherwise we can run into various issues. Bugzilla: https://bugs.freedesktop.org/105906 Fixes: 3160cb86aa92 "egl/x11: Re-allocate buffers if format is subo

Re: [Mesa-dev] [PATCH] dri3: Only update number of back buffers in loader_dri3_get_buffers

2018-04-30 Thread Daniel Stone
On 27 April 2018 at 16:56, Michel Dänzer wrote: > And only free no longer needed back buffers there as well. > > We want to stick to the same back buffer throughout a frame, otherwise > we can run into various issues. Thanks for dealing with this Michel! Acked-by: Daniel Stone _

Re: [Mesa-dev] [PATCH] dri3: Only update number of back buffers in loader_dri3_get_buffers

2018-04-30 Thread Eero Tamminen
Hi, On 27.04.2018 18:56, Michel Dänzer wrote: From: Michel Dänzer And only free no longer needed back buffers there as well. We want to stick to the same back buffer throughout a frame, otherwise we can run into various issues. Bugzilla: https://bugs.freedesktop.org/105906 Fixes: 3160cb86aa9

Re: [Mesa-dev] [PATCH] dri3: Only update number of back buffers in loader_dri3_get_buffers

2018-04-30 Thread Michel Dänzer
On 2018-04-30 08:58 AM, Sergii Romantsov wrote: > Hello, > with my simple tests it works, Thanks for testing. > but have some remarks (but don't have much experience with dri3): > > 1. It looks little dangerous to move logic of destroying buffers and seems > in your version we are loosing some

Re: [Mesa-dev] [PATCH] dri3: Only update number of back buffers in loader_dri3_get_buffers

2018-04-29 Thread Sergii Romantsov
Hello, with my simple tests it works, but have some remarks (but don't have much experience with dri3): 1. It looks little dangerous to move logic of destroying buffers and seems in your version we are loosing some logic with 'busy' and 'num_back' 2. And also looks like buffers just will not be de

[Mesa-dev] [PATCH] dri3: Only update number of back buffers in loader_dri3_get_buffers

2018-04-27 Thread Michel Dänzer
From: Michel Dänzer And only free no longer needed back buffers there as well. We want to stick to the same back buffer throughout a frame, otherwise we can run into various issues. Bugzilla: https://bugs.freedesktop.org/105906 Fixes: 3160cb86aa92 "egl/x11: Re-allocate buffers if format is subo