Re: [Mesa-dev] [PATCH] egl/android: prevent deadlock in droid_query_buffer_age

2018-04-30 Thread Tomasz Figa
Hi Min, On Sat, Apr 28, 2018 at 11:56 AM He, Min wrote: > Hi, Tomasz > On 4/27/2018 5:01 PM, Tomasz Figa wrote: > > Hi Min, > > > > On Fri, Apr 27, 2018 at 11:36 AM Min He wrote: > > > >> To avoid blocking other EGL calls, release the display mutex before >

Re: [Mesa-dev] [PATCH] egl/android: prevent deadlock in droid_query_buffer_age

2018-04-27 Thread He, Min
Hi, Tomasz On 4/27/2018 5:01 PM, Tomasz Figa wrote: Hi Min, On Fri, Apr 27, 2018 at 11:36 AM Min He wrote: To avoid blocking other EGL calls, release the display mutex before calling update_buffers(), which will call droid_window_dequeue_buffer(). The lock appears like

Re: [Mesa-dev] [PATCH] egl/android: prevent deadlock in droid_query_buffer_age

2018-04-27 Thread Tapani Pälli
On 27.04.2018 12:01, Tomasz Figa wrote: Hi Min, On Fri, Apr 27, 2018 at 11:36 AM Min He wrote: To avoid blocking other EGL calls, release the display mutex before calling update_buffers(), which will call droid_window_dequeue_buffer(). The lock appears like below: 1.

Re: [Mesa-dev] [PATCH] egl/android: prevent deadlock in droid_query_buffer_age

2018-04-27 Thread Tomasz Figa
Hi Min, On Fri, Apr 27, 2018 at 11:36 AM Min He wrote: > To avoid blocking other EGL calls, release the display mutex before > calling update_buffers(), which will call droid_window_dequeue_buffer(). > The lock appears like below: > 1. Consumer thread: updateTexImage() ->

Re: [Mesa-dev] [PATCH] egl/android: prevent deadlock in droid_query_buffer_age

2018-04-27 Thread Tapani Pälli
As discussed offline, this is similar to commit 1ea233c. LGTM; Reviewed-by: Tapani Pälli On 04/27/2018 05:17 AM, Min He wrote: To avoid blocking other EGL calls, release the display mutex before calling update_buffers(), which will call droid_window_dequeue_buffer().

[Mesa-dev] [PATCH] egl/android: prevent deadlock in droid_query_buffer_age

2018-04-27 Thread Min He
To avoid blocking other EGL calls, release the display mutex before calling update_buffers(), which will call droid_window_dequeue_buffer(). The lock appears like below: 1. Consumer thread: updateTexImage() -> updateAndReleaseLocked() -> syncForReleaseLocked() -> eglDupNativeFenceFDANDROID() ->