Re: [Mesa-dev] [PATCH] egl: Fix for not setting EGL_BAD_ALLOC on try to create multiple window surfaces on single window v2.

Hi Adrian, Thanks for the patch! Some comments inline. On 22 March 2017 at 13:40, Adrian Pielech wrote: > +struct list_head window_list = {NULL, NULL}; > + > +/* Checks if a EGLWindow already have a created surface */ > +static inline bool >

Re: [Mesa-dev] [PATCH] egl: Fix for not setting EGL_BAD_ALLOC on try to create multiple window surfaces on single window v2.

Hi Adrian, Welcome to Mesa ! On 22 March 2017 at 13:40, Adrian Pielech wrote: > According to the EGL 1.5 spec, section 3.5.1, page 34,35 > eglCreateWindowSurface should return EGL_BAD_ALLOC if there is already > surface for given window. Similarly it is written in EGL

Re: [Mesa-dev] [PATCH] egl: Fix for not setting EGL_BAD_ALLOC on try to create multiple window surfaces on single window v2.

Hi Adrian, Thanks for this patch! I have only had a quick look at the logic itself, but it looks correct. Inline are a few comments to address before we can merge this patch. I also recommend reading our guidelines on submitting patches: https://mesa3d.org/submittingpatches.html > Subject:

[Mesa-dev] [PATCH] egl: Fix for not setting EGL_BAD_ALLOC on try to create multiple window surfaces on single window v2.

According to the EGL 1.5 spec, section 3.5.1, page 34,35 eglCreateWindowSurface should return EGL_BAD_ALLOC if there is already surface for given window. Similarly it is written in EGL 1.4 spec, section 3.5.1, page 29. I apologize for small mistakes on earlier message... Signed-off-by: Adrian