Re: [Mesa-dev] [PATCH] egl: fix check for KHR_no_error vs debug/robustness

2017-07-26 Thread Emil Velikov
On 26 July 2017 at 08:59, Grigori Goronzy wrote: > On 2017-07-19 23:51, Grigori Goronzy wrote: >> >> The check is too aggressive and might also fail if context flags >> appear after the no-error attribute in the context attribute list. >> >> Delay the check to after attribute

Re: [Mesa-dev] [PATCH] egl: fix check for KHR_no_error vs debug/robustness

2017-07-26 Thread Grigori Goronzy
On 2017-07-19 23:51, Grigori Goronzy wrote: The check is too aggressive and might also fail if context flags appear after the no-error attribute in the context attribute list. Delay the check to after attribute parsing to fix this. --- This was found by the piglit test I just sent to the piglit

[Mesa-dev] [PATCH] egl: fix check for KHR_no_error vs debug/robustness

2017-07-19 Thread Grigori Goronzy
The check is too aggressive and might also fail if context flags appear after the no-error attribute in the context attribute list. Delay the check to after attribute parsing to fix this. --- This was found by the piglit test I just sent to the piglit ML. I promise, next time I'll write tests