Re: [Mesa-dev] [PATCH] gallium/auxiliary: Fix Autotools on Android (v2)

2018-07-26 Thread Tomasz Figa
On Fri, Jul 27, 2018 at 6:52 AM Chad Versace wrote: > > On Wed 25 Jul 2018, Tomasz Figa wrote: > > Hi Chad, > > > > On Wed, Jul 25, 2018 at 10:11 AM Chad Versace > > wrote: > > > > > > Problem 1: u_debug_stack_android.cpp transitively included > > > "pipe/p_compiler.h", but src/gallium/include

Re: [Mesa-dev] [PATCH] gallium/auxiliary: Fix Autotools on Android (v2)

2018-07-26 Thread Chad Versace
On Wed 25 Jul 2018, Tomasz Figa wrote: > Hi Chad, > > On Wed, Jul 25, 2018 at 10:11 AM Chad Versace > wrote: > > > > Problem 1: u_debug_stack_android.cpp transitively included > > "pipe/p_compiler.h", but src/gallium/include was missing from the C++ > > include path. > > > > Problem 2: Add

Re: [Mesa-dev] [PATCH] gallium/auxiliary: Fix Autotools on Android (v2)

2018-07-24 Thread Tomasz Figa
Hi Chad, On Wed, Jul 25, 2018 at 10:11 AM Chad Versace wrote: > > Problem 1: u_debug_stack_android.cpp transitively included > "pipe/p_compiler.h", but src/gallium/include was missing from the C++ > include path. > > Problem 2: Add -std=c++11 to AM_CXXFLAGS. Android's libbacktrace headers >

Re: [Mesa-dev] [PATCH] gallium/auxiliary: Fix Autotools on Android (v2)

2018-07-24 Thread Gurchetan Singh
Reviewed-by: Gurchetan Singh On Tue, Jul 24, 2018 at 6:11 PM Chad Versace wrote: > > Problem 1: u_debug_stack_android.cpp transitively included > "pipe/p_compiler.h", but src/gallium/include was missing from the C++ > include path. > > Problem 2: Add -std=c++11 to AM_CXXFLAGS. Android's

[Mesa-dev] [PATCH] gallium/auxiliary: Fix Autotools on Android (v2)

2018-07-24 Thread Chad Versace
Problem 1: u_debug_stack_android.cpp transitively included "pipe/p_compiler.h", but src/gallium/include was missing from the C++ include path. Problem 2: Add -std=c++11 to AM_CXXFLAGS. Android's libbacktrace headers require C++11, but the Android toolchain (at least in the Chrome OS SDK) does not