Re: [Mesa-dev] [PATCH] gallium/dri2: Avoid uneeded stride to pitch conversion

2016-01-05 Thread Marek Olšák
On Tue, Jan 5, 2016 at 5:19 PM, Axel Davy wrote: > Hi Nicolas, > > I believe this patch doesn't fully solve the problem and could introduce > some bugs. > > For example you change dri2_create_image_from_name pitch argument to stride, > whereas this function is used as is to

Re: [Mesa-dev] [PATCH] gallium/dri2: Avoid uneeded stride to pitch conversion

2016-01-05 Thread Nicolas Dufresne
Le mardi 05 janvier 2016 à 17:19 +0100, Axel Davy a écrit : > Hi Nicolas, > > I believe this patch doesn't fully solve the problem and could > introduce some bugs. > > For example you change dri2_create_image_from_name pitch argument to > stride, > whereas this function is used as is to

Re: [Mesa-dev] [PATCH] gallium/dri2: Avoid uneeded stride to pitch conversion

2016-01-05 Thread Axel Davy
Hi Nicolas, I believe this patch doesn't fully solve the problem and could introduce some bugs. For example you change dri2_create_image_from_name pitch argument to stride, whereas this function is used as is to implement createImageFromName from __DRIimageExtensionRec, which takes a pitch.

Re: [Mesa-dev] [PATCH] gallium/dri2: Avoid uneeded stride to pitch conversion

2016-01-05 Thread Nicolas Dufresne
Le me know if this patch needs an update. cheers, Nicolas Le jeudi 24 décembre 2015 à 15:15 -0500, Nicolas Dufresne a écrit : > In order to convert from stride to pitch, few functions were diving > by 4 > the stride. This is not valid for RGB565 and this conversion was not > needed anyway in

[Mesa-dev] [PATCH] gallium/dri2: Avoid uneeded stride to pitch conversion

2015-12-24 Thread Nicolas Dufresne
In order to convert from stride to pitch, few functions were diving by 4 the stride. This is not valid for RGB565 and this conversion was not needed anyway in this context. Signed-off-by: Nicolas Dufresne --- src/gallium/state_trackers/dri/dri2.c | 33