Re: [Mesa-dev] [PATCH] gallium: Do not add -Wframe-address option for gcc <= 4.4.

On 21/03/18 22:10, Vinson Lee wrote: This patch fixes these build errors with GCC 4.4. Compiling src/gallium/auxiliary/util/u_debug_stack.c ... src/gallium/auxiliary/util/u_debug_stack.c: In function ‘debug_backtrace_capture’: src/gallium/auxiliary/util/u_debug_stack.c:268: error: #pragma

Re: [Mesa-dev] [PATCH] gallium: Do not add -Wframe-address option for gcc <= 4.4.

Hi Vinson, Thanks for the patch. I was considering moving the gcc stuff out into its own function e.g get_gcc_frame_pointer() which could then be wrapped with #pragma GCC diagnostic which gcc 4.4 should be able to handle. However I'm not too worried about GCC 4.4 and lower so this patch is

[Mesa-dev] [PATCH] gallium: Do not add -Wframe-address option for gcc <= 4.4.

This patch fixes these build errors with GCC 4.4. Compiling src/gallium/auxiliary/util/u_debug_stack.c ... src/gallium/auxiliary/util/u_debug_stack.c: In function ‘debug_backtrace_capture’: src/gallium/auxiliary/util/u_debug_stack.c:268: error: #pragma GCC diagnostic not allowed inside