Re: [Mesa-dev] [PATCH] gallium: add PIPE_CAP_RASTERIZER_SUBPIXEL_BITS

2018-09-06 Thread Marek Olšák
On Thu, Sep 6, 2018 at 5:42 PM, Eric Anholt wrote: > Marek Olšák writes: > >> From: Marek Olšák > > Could you please work on providing explanatory text in your commit > messages? Something like: > > This fixes the default value of GL_SUBPIXEL_BITS, while leaving > GL_VIEWPORT_SUBPIXEL_BITS in

Re: [Mesa-dev] [PATCH] gallium: add PIPE_CAP_RASTERIZER_SUBPIXEL_BITS

2018-09-06 Thread Eric Anholt
Marek Olšák writes: > From: Marek Olšák Could you please work on providing explanatory text in your commit messages? Something like: This fixes the default value of GL_SUBPIXEL_BITS, while leaving GL_VIEWPORT_SUBPIXEL_BITS in place. Maybe including the test name that motivated the fix.

Re: [Mesa-dev] [PATCH] gallium: add PIPE_CAP_RASTERIZER_SUBPIXEL_BITS

2018-09-05 Thread Roland Scheidegger
Looks great to me. Thanks! Reviewed-by: Roland Scheidegger Am 06.09.2018 um 06:10 schrieb Marek Olšák: > From: Marek Olšák > > --- > src/gallium/auxiliary/util/u_screen.c | 3 +++ > src/gallium/docs/source/screen.rst | 2 ++ > src/gallium/drivers/r600/r600_pipe.c | 1 + >

[Mesa-dev] [PATCH] gallium: add PIPE_CAP_RASTERIZER_SUBPIXEL_BITS

2018-09-05 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_screen.c | 3 +++ src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/r600/r600_pipe.c | 1 + src/gallium/drivers/radeonsi/si_get.c | 1 + src/gallium/include/pipe/p_defines.h | 1 + src/mesa/state_tracker/st_extensions.c |