Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI (v2)

2017-03-31 Thread Roland Scheidegger
Am 30.03.2017 um 14:42 schrieb Marek Olšák: > From: Marek Olšák > > Neved used. > > v2: gallivm: rename "pred" -> "exec_mask" > etnaviv: remove the cap > gallium: fix tgsi_instruction::Padding > --- Reviewed-by: Roland Scheidegger

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2017-03-29 Thread Jose Fonseca
On 29/03/17 19:02, Roland Scheidegger wrote: [resend with snipped bits as it's too big] A couple comments inline. [snip] --- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c +++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c @@ -746,39 +746,30 @@ static void lp_exec_default(struct

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2017-03-29 Thread Roland Scheidegger
[resend with snipped bits as it's too big] A couple comments inline. [snip] > --- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c > +++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c > @@ -746,39 +746,30 @@ static void lp_exec_default(struct lp_exec_mask *mask, > } > > > /* stores

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2017-03-29 Thread Emil Velikov
On 29 March 2017 at 16:51, Marek Olšák wrote: > From: Marek Olšák > > Neved used. > --- > src/gallium/auxiliary/gallivm/lp_bld_limits.h | 4 - > src/gallium/auxiliary/gallivm/lp_bld_tgsi.h| 2 - >

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2015-09-25 Thread Jose Fonseca
On 24/09/15 19:01, Marek Olšák wrote: On Wed, Sep 2, 2015 at 12:55 AM, Jose Fonseca wrote: I'm all for TGIS simplification, but I just checked, and we rely on TGSI predicates for some of our internal state trackers. So I'll need more time to evaluate how much effort it

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2015-09-24 Thread Marek Olšák
On Wed, Sep 2, 2015 at 12:55 AM, Jose Fonseca wrote: > I'm all for TGIS simplification, but I just checked, and we rely on TGSI > predicates for some of our internal state trackers. So I'll need more time > to evaluate how much effort it would be to not rely on it, and when

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2015-09-03 Thread Jose Fonseca
On the flip side, we could remove TGSI_FILE_ADDR, TGSI_OPCODE_ARL, and TGSI_OPCODE_ARR. We already remove all dependencies of these from our internal state tracers. And it is trivial to do so, at least for HW with native integer support. Jose On 01/09/15 23:55, Jose Fonseca wrote: I'm all

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2015-09-03 Thread Marek Olšák
On Thu, Sep 3, 2015 at 1:17 PM, Jose Fonseca wrote: > On the flip side, we could remove TGSI_FILE_ADDR, TGSI_OPCODE_ARL, and > TGSI_OPCODE_ARR. > > We already remove all dependencies of these from our internal state tracers. > > And it is trivial to do so, at least for HW

[Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2015-09-01 Thread Marek Olšák
From: Marek Olšák Neved used. --- Take 2. Let's see how people feel about TGSI now. src/gallium/auxiliary/gallivm/lp_bld_limits.h | 4 - src/gallium/auxiliary/gallivm/lp_bld_tgsi.h| 2 - src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c| 46 ---

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2015-09-01 Thread Jose Fonseca
I'm all for TGIS simplification, but I just checked, and we rely on TGSI predicates for some of our internal state trackers. So I'll need more time to evaluate how much effort it would be to not rely on it, and when can it be done. Jose On 01/09/15 22:19, Marek Olšák wrote: From: Marek

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2015-09-01 Thread Axel Davy
Hi, There is predication in direct3D9 HLSL, however we don't implement them and never had any complaint about that. Reason is that HLSL Microsoft compiler doesn't generate any predication. I read somewhere they did this choice because for drivers it is possible to lower efficiently if

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2014-08-12 Thread Marek Olšák
On Tue, Aug 12, 2014 at 4:22 AM, Connor Abbott cwabbo...@gmail.com wrote: On Mon, Aug 11, 2014 at 4:32 PM, Eric Anholt e...@anholt.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Wed, Aug 6, 2014 at 6:29 PM, Marek Olšák mar...@gmail.com wrote: What IR? A flatland GLSL IR? A

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2014-08-11 Thread Roland Scheidegger
Am 09.08.2014 05:24, schrieb Connor Abbott: On Wed, Aug 6, 2014 at 6:29 PM, Marek Olšák mar...@gmail.com wrote: What IR? A flatland GLSL IR? A replacement for Mesa IR? Something else? It's a flatland IR, similar to TGSI/Direct3D style with enough GLSL IR-like stuff to get existing things

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2014-08-11 Thread Marek Olšák
On Sat, Aug 9, 2014 at 5:24 AM, Connor Abbott cwabbo...@gmail.com wrote: On Wed, Aug 6, 2014 at 6:29 PM, Marek Olšák mar...@gmail.com wrote: What IR? A flatland GLSL IR? A replacement for Mesa IR? Something else? It's a flatland IR, similar to TGSI/Direct3D style with enough GLSL IR-like

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2014-08-11 Thread Ilia Mirkin
On Mon, Aug 11, 2014 at 1:31 PM, Marek Olšák mar...@gmail.com wrote: On Sat, Aug 9, 2014 at 5:24 AM, Connor Abbott cwabbo...@gmail.com wrote: On Wed, Aug 6, 2014 at 6:29 PM, Marek Olšák mar...@gmail.com wrote: What IR? A flatland GLSL IR? A replacement for Mesa IR? Something else? It's a

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2014-08-11 Thread Eric Anholt
Connor Abbott cwabbo...@gmail.com writes: On Wed, Aug 6, 2014 at 6:29 PM, Marek Olšák mar...@gmail.com wrote: What IR? A flatland GLSL IR? A replacement for Mesa IR? Something else? It's a flatland IR, similar to TGSI/Direct3D style with enough GLSL IR-like stuff to get existing things

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2014-08-11 Thread Connor Abbott
On Mon, Aug 11, 2014 at 4:32 PM, Eric Anholt e...@anholt.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Wed, Aug 6, 2014 at 6:29 PM, Marek Olšák mar...@gmail.com wrote: What IR? A flatland GLSL IR? A replacement for Mesa IR? Something else? It's a flatland IR, similar to

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2014-08-08 Thread Connor Abbott
On Wed, Aug 6, 2014 at 6:29 PM, Marek Olšák mar...@gmail.com wrote: What IR? A flatland GLSL IR? A replacement for Mesa IR? Something else? It's a flatland IR, similar to TGSI/Direct3D style with enough GLSL IR-like stuff to get existing things working now and enable us to eventually do linking

[Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2014-08-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com Neved used. --- src/gallium/auxiliary/gallivm/lp_bld_limits.h | 4 - src/gallium/auxiliary/gallivm/lp_bld_tgsi.h| 2 - src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c| 46 --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_info.c | 6

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2014-08-06 Thread Matt Turner
On Wed, Aug 6, 2014 at 5:10 PM, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com Neved used. --- Connor's new IR has predication. You may not want to remove this quite yet. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI

2014-08-06 Thread Marek Olšák
What IR? A flatland GLSL IR? A replacement for Mesa IR? Something else? It's more of a question of which gallium hardware drivers are going to support it. I don't think there will be any eager candidates. The D3D9 state tracker already converts predicates to IFs. Marek On Thu, Aug 7, 2014 at