Re: [Mesa-dev] [PATCH] gallivm: Improve lp_build_rcp_refine.

2019-06-27 Thread Jose Fonseca
On 25/06/2019 16:22, Roland Scheidegger wrote: > Looks good to me, albeit it's potentially minimally slower, so I'm > wondering if the higher precision is actually useful? It gets you an extra bit, and is necessary if you want to reach 0.5 ULP (otherwise it never gets there.) Anyway, it's still

Re: [Mesa-dev] [PATCH] gallivm: Improve lp_build_rcp_refine.

2019-06-25 Thread Roland Scheidegger
Looks good to me, albeit it's potentially minimally slower, so I'm wondering if the higher precision is actually useful? I guess though the last two steps could use lp_build_fmuladd? Reviewed-by: Roland Scheidegger Am 25.06.19 um 11:17 schrieb Jose Fonseca: > Use the alternative more accurate

[Mesa-dev] [PATCH] gallivm: Improve lp_build_rcp_refine.

2019-06-25 Thread Jose Fonseca
Use the alternative more accurate expression from https://en.wikipedia.org/wiki/Division_algorithm#Newton%E2%80%93Raphson_division Tested by enabling this code path, and running gloss mesa demo. --- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 9 + 1 file changed, 5 insertions(+), 4