Re: [Mesa-dev] [PATCH] gallivm: fix indirect addressing of inputs

2013-11-06 Thread Jose Fonseca
Looks good. Though I thought we had fixed this once before. Could you double check there are no similar issues with the remaining register files (output, etc)? Jose - Original Message - > From: Roland Scheidegger > > We weren't adding the soa offsets when constructing the indices > f

[Mesa-dev] [PATCH] gallivm: fix indirect addressing of inputs

2013-11-06 Thread sroland
From: Roland Scheidegger We weren't adding the soa offsets when constructing the indices for the gather functions. That meant that we were always returning the data in the first element. (Copied straight from the same fix for temps.) While here fix up a couple of broken comments in the fetch func