Re: [Mesa-dev] [PATCH] glcpp: Rewrite line-continuation support to act globally.

2012-12-03 Thread Carl Worth
Kenneth Graunke kenn...@whitecape.org writes: I'm pretty tempted by ralloc_rewrite_tail ralloc_strn_rewrite_tail. I still don't like the lack of symmetry here. Maybe bite the bullet and make the first one ralloc_str_rewrite_tail? But that rewrite_tail keeps feeling so awkward. I think the real

[Mesa-dev] [PATCH] glcpp: Rewrite line-continuation support to act globally.

2012-12-02 Thread
From: Carl Worth cwo...@cworth.org Previously, we were only supporting line-continuation backslash characters within lines of pre-processor directives, (as per the specification). With OpenGL 4.2 and GLES3, line continuations are now supported anywhere within a shader. While changing this, also

Re: [Mesa-dev] [PATCH] glcpp: Rewrite line-continuation support to act globally.

2012-12-01 Thread Kenneth Graunke
On 11/30/2012 03:20 PM, Carl Worth wrote: Kenneth Graunke kenn...@whitecape.org writes: Other than than, looks good to me...thanks Carl! Reviewed-by: Kenneth Graunke kenn...@whitecape.org Thanks, Ken. Pushed now. Someday we may want to use ralloc's rewrite_tail functions to avoid the extra

Re: [Mesa-dev] [PATCH] glcpp: Rewrite line-continuation support to act globally.

2012-11-30 Thread Kenneth Graunke
On 11/29/2012 03:44 PM, Carl Worth wrote: Previously, we were only supporting line-continuation backslash characters within lines of pre-processor directives, (as per the specification). With OpenGL 4.3, line continuations are now supported anywhere within a shader. OpenGL 4.2, actually. I'm

Re: [Mesa-dev] [PATCH] glcpp: Rewrite line-continuation support to act globally.

2012-11-30 Thread Ian Romanick
On 11/30/2012 02:29 PM, Kenneth Graunke wrote: On 11/29/2012 03:44 PM, Carl Worth wrote: Previously, we were only supporting line-continuation backslash characters within lines of pre-processor directives, (as per the specification). With OpenGL 4.3, line continuations are now supported

Re: [Mesa-dev] [PATCH] glcpp: Rewrite line-continuation support to act globally.

2012-11-30 Thread Carl Worth
Kenneth Graunke kenn...@whitecape.org writes: Other than than, looks good to me...thanks Carl! Reviewed-by: Kenneth Graunke kenn...@whitecape.org Thanks, Ken. Pushed now. Someday we may want to use ralloc's rewrite_tail functions to avoid the extra strlen() overhead. But that can be done

[Mesa-dev] [PATCH] glcpp: Rewrite line-continuation support to act globally.

2012-11-29 Thread Carl Worth
Previously, we were only supporting line-continuation backslash characters within lines of pre-processor directives, (as per the specification). With OpenGL 4.3, line continuations are now supported anywhere within a shader. While changing this, also fix a bug where the preprocessor was ignoring