Re: [Mesa-dev] [PATCH] gles2: Support for GL_EXT_occlusion_query_boolean

2017-08-20 Thread Tapani Pälli
On 08/21/2017 08:47 AM, Harish Krupo wrote: Hi Ilia, On 08/21/2017 10:42 AM, Ilia Mirkin wrote: On Mon, Aug 21, 2017 at 12:52 AM, Harish Krupo wrote: Hi Ilia, On 08/18/2017 07:20 PM, Ilia Mirkin wrote: Why the static data changes? Also, I haven't double checked the code, but I'm almost

Re: [Mesa-dev] [PATCH] gles2: Support for GL_EXT_occlusion_query_boolean

2017-08-20 Thread Harish Krupo
Hi Ilia, On 08/21/2017 10:42 AM, Ilia Mirkin wrote: On Mon, Aug 21, 2017 at 12:52 AM, Harish Krupo wrote: Hi Ilia, On 08/18/2017 07:20 PM, Ilia Mirkin wrote: Why the static data changes? Also, I haven't double checked the code, but I'm almost certain this is incomplete. You have to add code

Re: [Mesa-dev] [PATCH] gles2: Support for GL_EXT_occlusion_query_boolean

2017-08-20 Thread Ilia Mirkin
On Mon, Aug 21, 2017 at 12:52 AM, Harish Krupo wrote: > Hi Ilia, > > On 08/18/2017 07:20 PM, Ilia Mirkin wrote: >> >> Why the static data changes? Also, I haven't double checked the code, but >> I'm almost certain this is incomplete. You have to add code disallowing the >> other enums from being u

Re: [Mesa-dev] [PATCH] gles2: Support for GL_EXT_occlusion_query_boolean

2017-08-20 Thread Harish Krupo
Hi Ilia, On 08/18/2017 07:20 PM, Ilia Mirkin wrote: Why the static data changes? Also, I haven't double checked the code, but I'm almost certain this is incomplete. You have to add code disallowing the other enums from being used on es2. Thank you for pointing out that code is required to dis

Re: [Mesa-dev] [PATCH] gles2: Support for GL_EXT_occlusion_query_boolean

2017-08-18 Thread Ilia Mirkin
Why the static data changes? Also, I haven't double checked the code, but I'm almost certain this is incomplete. You have to add code disallowing the other enums from being used on es2. On Aug 18, 2017 6:42 AM, "Harish Krupo" wrote: > It passes dEQP-GLES2.capability.extensions.other.GL_EXT_ > oc

[Mesa-dev] [PATCH] gles2: Support for GL_EXT_occlusion_query_boolean

2017-08-18 Thread Harish Krupo
It passes dEQP-GLES2.capability.extensions.other.GL_EXT_occlusion_query_boolean test. I think the test is just a check for the existence of the extension. On gles3 and above, occlusion queries are part of the spec. Signed-off-by: Harish Krupo --- There is a piglit test for this extension in the