Re: [Mesa-dev] [PATCH] glsl: Change loop_analysis to not look like a resource leak

2013-01-31 Thread Kenneth Graunke
On 01/30/2013 11:27 AM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Previously the loop_state was allocated in the loop_analysis constructor, but not freed in the (nonexistent) destructor. Moving the allocation of the loop_state makes this code appear less sketchy. Either

[Mesa-dev] [PATCH] glsl: Change loop_analysis to not look like a resource leak

2013-01-30 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Previously the loop_state was allocated in the loop_analysis constructor, but not freed in the (nonexistent) destructor. Moving the allocation of the loop_state makes this code appear less sketchy. Either way, there is no actual leak. The loop_state

Re: [Mesa-dev] [PATCH] glsl: Change loop_analysis to not look like a resource leak

2013-01-30 Thread Matt Turner
On Wed, Jan 30, 2013 at 11:27 AM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Previously the loop_state was allocated in the loop_analysis constructor, but not freed in the (nonexistent) destructor. Moving the allocation of the loop_state makes this