Re: [Mesa-dev] [PATCH] glsl: Drop bogus is_vertex_input from add_shader_variable().

On Fri, Dec 16, 2016 at 9:46 PM, Kenneth Graunke wrote: > > stage_mask is a bitmask of shader stages, so the proper comparison would > be (1 << MESA_SHADER_VERTEX), not MESA_SHADER_VERTEX itself. > > But we only care for structure types, and VS inputs cannot be structs. >

Re: [Mesa-dev] [PATCH] glsl: Drop bogus is_vertex_input from add_shader_variable().

lgtm Reviewed-by: Alejandro Piñeiro On 17/12/16 03:46, Kenneth Graunke wrote: > stage_mask is a bitmask of shader stages, so the proper comparison would > be (1 << MESA_SHADER_VERTEX), not MESA_SHADER_VERTEX itself. > > But we only care for structure types, and VS inputs

[Mesa-dev] [PATCH] glsl: Drop bogus is_vertex_input from add_shader_variable().

stage_mask is a bitmask of shader stages, so the proper comparison would be (1 << MESA_SHADER_VERTEX), not MESA_SHADER_VERTEX itself. But we only care for structure types, and VS inputs cannot be structs. So we can just drop this entirely. Signed-off-by: Kenneth Graunke