Re: [Mesa-dev] [PATCH] glsl: Fix program interface queries relating to interface blocks.

2016-12-19 Thread Kenneth Graunke
On Monday, December 19, 2016 8:41:17 PM PST Matt Turner wrote: > On Mon, Dec 19, 2016 at 4:13 PM, Kenneth Graunke > wrote: > > For what it's worth, the OpenGL wiki's Program Introspection page(*), > > under "Interface block member naming" gives an example matching my above > > reply. It says: >

Re: [Mesa-dev] [PATCH] glsl: Fix program interface queries relating to interface blocks.

2016-12-19 Thread Matt Turner
On Mon, Dec 19, 2016 at 4:13 PM, Kenneth Graunke wrote: > For what it's worth, the OpenGL wiki's Program Introspection page(*), > under "Interface block member naming" gives an example matching my above > reply. It says: > > uniform BlockName3 > { > int mem; > } instanceName3[4]

Re: [Mesa-dev] [PATCH] glsl: Fix program interface queries relating to interface blocks.

2016-12-19 Thread Kenneth Graunke
On Monday, December 19, 2016 1:36:00 PM PST Ian Romanick wrote: > On 12/16/2016 09:35 PM, Kenneth Graunke wrote: > > This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's > > arb_program_interface_query/arb_program_interface_query-resource-query, > > and GL45-CTS.program_interface_q

Re: [Mesa-dev] [PATCH] glsl: Fix program interface queries relating to interface blocks.

2016-12-19 Thread Ian Romanick
On 12/16/2016 09:35 PM, Kenneth Graunke wrote: > This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's > arb_program_interface_query/arb_program_interface_query-resource-query, > and GL45-CTS.program_interface_query.separate-programs-{tess-control, > tess-eval,geometry}. Only one d

Re: [Mesa-dev] [PATCH] glsl: Fix program interface queries relating to interface blocks.

2016-12-19 Thread Alejandro Piñeiro
On 17/12/16 17:57, Kenneth Graunke wrote: > On Saturday, December 17, 2016 5:41:35 PM PST Alejandro Piñeiro wrote: >> On 17/12/16 03:35, Kenneth Graunke wrote: >>> This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's >>> arb_program_interface_query/arb_program_interface_query-resou

Re: [Mesa-dev] [PATCH] glsl: Fix program interface queries relating to interface blocks.

2016-12-19 Thread Alejandro Piñeiro
On 17/12/16 17:57, Kenneth Graunke wrote: > On Saturday, December 17, 2016 5:41:35 PM PST Alejandro Piñeiro wrote: >> On 17/12/16 03:35, Kenneth Graunke wrote: >>> This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's >>> arb_program_interface_query/arb_program_interface_query-resou

Re: [Mesa-dev] [PATCH] glsl: Fix program interface queries relating to interface blocks.

2016-12-17 Thread Kenneth Graunke
On Saturday, December 17, 2016 5:41:35 PM PST Alejandro Piñeiro wrote: > On 17/12/16 03:35, Kenneth Graunke wrote: > > This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's > > arb_program_interface_query/arb_program_interface_query-resource-query, > > Somewhat offtopic: FWIW, pigl

Re: [Mesa-dev] [PATCH] glsl: Fix program interface queries relating to interface blocks.

2016-12-17 Thread Alejandro Piñeiro
On 17/12/16 03:35, Kenneth Graunke wrote: > This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's > arb_program_interface_query/arb_program_interface_query-resource-query, Somewhat offtopic: FWIW, piglit tests for arb_program_interface_query doesn't tests too much the REFERENCED_BY

[Mesa-dev] [PATCH] glsl: Fix program interface queries relating to interface blocks.

2016-12-16 Thread Kenneth Graunke
This fixes 555 dEQP tests (using the nougat-cts-dev branch), Piglit's arb_program_interface_query/arb_program_interface_query-resource-query, and GL45-CTS.program_interface_query.separate-programs-{tess-control, tess-eval,geometry}. Only one dEQP program interface failure remains. I would have li