Re: [Mesa-dev] [PATCH] glsl: Make blend_colordodge compare against 1.0 - FLT_EPSILON.

2016-10-02 Thread Kenneth Graunke
On Thursday, September 8, 2016 10:33:06 PM PDT Francisco Jerez wrote: [snip] > Heh, right, my concern was that this smells strongly like a test relying > on not terribly well-defined behavior... AFAICT the problem addressed > here is ultimately caused by the discontinuity that the COLORBURN >

Re: [Mesa-dev] [PATCH] glsl: Make blend_colordodge compare against 1.0 - FLT_EPSILON.

2016-09-10 Thread Francisco Jerez
Alejandro Piñeiro writes: > On 09/09/16 07:33, Francisco Jerez wrote: >> Alejandro Piñeiro writes: >> >>> On 02/09/16 23:13, Kenneth Graunke wrote: On Friday, August 26, 2016 10:49:18 PM PDT Kenneth Graunke wrote: > This fixes a numerical

Re: [Mesa-dev] [PATCH] glsl: Make blend_colordodge compare against 1.0 - FLT_EPSILON.

2016-09-10 Thread Alejandro Piñeiro
On 09/09/16 07:33, Francisco Jerez wrote: > Alejandro Piñeiro writes: > >> On 02/09/16 23:13, Kenneth Graunke wrote: >>> On Friday, August 26, 2016 10:49:18 PM PDT Kenneth Graunke wrote: This fixes a numerical precision issue that was causing two CTS failures:

Re: [Mesa-dev] [PATCH] glsl: Make blend_colordodge compare against 1.0 - FLT_EPSILON.

2016-09-08 Thread Francisco Jerez
Alejandro Piñeiro writes: > On 02/09/16 23:13, Kenneth Graunke wrote: >> On Friday, August 26, 2016 10:49:18 PM PDT Kenneth Graunke wrote: >>> This fixes a numerical precision issue that was causing two CTS >>> failures: >>> >>>

Re: [Mesa-dev] [PATCH] glsl: Make blend_colordodge compare against 1.0 - FLT_EPSILON.

2016-09-08 Thread Alejandro Piñeiro
On 02/09/16 23:13, Kenneth Graunke wrote: > On Friday, August 26, 2016 10:49:18 PM PDT Kenneth Graunke wrote: >> This fixes a numerical precision issue that was causing two CTS >> failures: >> >> ES31-CTS.blend_equation_advanced.blend_specific.GL_COLORBURN_KHR >>

Re: [Mesa-dev] [PATCH] glsl: Make blend_colordodge compare against 1.0 - FLT_EPSILON.

2016-09-02 Thread Kenneth Graunke
On Friday, August 26, 2016 10:49:18 PM PDT Kenneth Graunke wrote: > This fixes a numerical precision issue that was causing two CTS > failures: > > ES31-CTS.blend_equation_advanced.blend_specific.GL_COLORBURN_KHR > ES31-CTS.blend_equation_advanced.blend_all.GL_COLORBURN_KHR_all_qualifier > >

[Mesa-dev] [PATCH] glsl: Make blend_colordodge compare against 1.0 - FLT_EPSILON.

2016-08-26 Thread Kenneth Graunke
This fixes a numerical precision issue that was causing two CTS failures: ES31-CTS.blend_equation_advanced.blend_specific.GL_COLORBURN_KHR ES31-CTS.blend_equation_advanced.blend_all.GL_COLORBURN_KHR_all_qualifier When blending with GL_COLORDODGE_KHR and these colors: dst = <0.372549027,