Re: [Mesa-dev] [PATCH] glsl: Use ir_var_temporary when generating inline functions.

Reviewed-by: Iago Toral Quiroga On Mon, 2016-12-19 at 15:29 -0800, Kenneth Graunke wrote: > We were using ir_var_auto for the inlined function parameter > variables, > which is wrong, as it suggests that those are real variables declared > by the program. > > Normally this

Re: [Mesa-dev] [PATCH] glsl: Use ir_var_temporary when generating inline functions.

Makes sense. Reviewed-by: Ilia Mirkin On Mon, Dec 19, 2016 at 6:33 PM, Kenneth Graunke wrote: > On Monday, December 19, 2016 3:29:13 PM PST Kenneth Graunke wrote: >> We were using ir_var_auto for the inlined function parameter variables, >> which is

Re: [Mesa-dev] [PATCH] glsl: Use ir_var_temporary when generating inline functions.

On Monday, December 19, 2016 3:29:13 PM PST Kenneth Graunke wrote: > We were using ir_var_auto for the inlined function parameter variables, > which is wrong, as it suggests that those are real variables declared > by the program. > > Normally this doesn't matter. However, if you called

[Mesa-dev] [PATCH] glsl: Use ir_var_temporary when generating inline functions.

We were using ir_var_auto for the inlined function parameter variables, which is wrong, as it suggests that those are real variables declared by the program. Normally this doesn't matter. However, if you called built-ins at global scope, it would pollute the global variable namespace with these