Re: [Mesa-dev] [PATCH] glsl: link error if unsized array not-last in ssbo

2017-02-17 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga You can also add the new piglit tests that this fixes to the commit log. Iago  On Wed, 2017-02-15 at 15:12 +0100, Jose Maria Casanova Crespo wrote: > If an unsized declared array is not the last in an SSBO > and an implicit size can not be

Re: [Mesa-dev] [PATCH] glsl: link error if unsized array not-last in ssbo

2017-02-15 Thread Chema Casanova
I've forgot the --annotate to submit this comment about this patch, so here it is: This patch fixes an incorrect behavior exposed by the piglit tests about SSBOs and unsized arrays submitted by Dave Airlie not yet in master https://lists.freedesktop.org/archives/piglit/2016-May/019852.html Chema

[Mesa-dev] [PATCH] glsl: link error if unsized array not-last in ssbo

2017-02-15 Thread Jose Maria Casanova Crespo
If an unsized declared array is not the last in an SSBO and an implicit size can not be defined on linking time, the linker should raise an error instead of reaching an assertion on GL. This reverts part of commit 3da08e166415a745139c1127040a24e8a45dc553 getting back to the behavior of commit