Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-03 Thread Timothy Arceri
On Mon, 2015-08-03 at 19:32 +1000, Timothy Arceri wrote: > On Sun, 2015-08-02 at 20:39 -0400, Ilia Mirkin wrote: > > Given that this is a debug-only thing, I doubt perf numbers are that > > interesting. > > > > I have no clue what the diff is between the two hash tables, but if > > one is allegedl

Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-03 Thread Timothy Arceri
On Mon, 2015-08-03 at 03:54 +0200, Alejandro Seguí Díaz wrote: > I'm starting to contribute and Timothy Arceri told me about this > task. The change was made at that sole file because we talked > about no need to migrate all tables at once, but we discuss this > and I take note to migrate all hash

Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-03 Thread Timothy Arceri
On Sun, 2015-08-02 at 20:39 -0400, Ilia Mirkin wrote: > Given that this is a debug-only thing, I doubt perf numbers are that > interesting. > > I have no clue what the diff is between the two hash tables, but if > one is allegedly faster than the other, that should be determined, and > we should j

Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-02 Thread Alejandro Seguí Díaz
I'm starting to contribute and Timothy Arceri told me about this task. The change was made at that sole file because we talked about no need to migrate all tables at once, but we discuss this and I take note to migrate all hash tables at once if everyone agrees. PS.: I forgot to add Reviewed-by Ti

Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-02 Thread Chris Forbes
Oh, fair enough then. On Aug 3, 2015 12:39 PM, "Ilia Mirkin" wrote: > Given that this is a debug-only thing, I doubt perf numbers are that > interesting. > > I have no clue what the diff is between the two hash tables, but if > one is allegedly faster than the other, that should be determined, an

Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-02 Thread Ilia Mirkin
Given that this is a debug-only thing, I doubt perf numbers are that interesting. I have no clue what the diff is between the two hash tables, but if one is allegedly faster than the other, that should be determined, and we should just mass-migrate... -ilia On Sun, Aug 2, 2015 at 8:05 PM, Chri

[Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-02 Thread Alejandro Seguí
The util/hash_table was intended to be a fast hash table replacement for the program/hash_table see 35fd61bd99c1 and 72e55bb6888ff. --- src/glsl/ir_print_visitor.cpp | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/glsl/ir_print_visitor.cpp b/src/glsl/ir_

Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-02 Thread Chris Forbes
Some perf numbers would be nice. How much is this winning? - Chris On Mon, Aug 3, 2015 at 11:18 AM, Timothy Arceri wrote: > On Sun, 2015-08-02 at 19:50 +0200, Alejandro Seguí wrote: > > Maybe just for completeness you could add this to the commit message > > The util/hash_table was intended to b

Re: [Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-02 Thread Timothy Arceri
On Sun, 2015-08-02 at 19:50 +0200, Alejandro Seguí wrote: Maybe just for completeness you could add this to the commit message The util/hash_table was intended to be a fast hash table replacement for the program/hash_table see 35fd61bd99c1 and 72e55bb6888ff. > --- > src/glsl/ir_print_visitor.cp

[Mesa-dev] [PATCH] glsl: replace old hash table with new and faster one

2015-08-02 Thread Alejandro Seguí
--- src/glsl/ir_print_visitor.cpp | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/glsl/ir_print_visitor.cpp b/src/glsl/ir_print_visitor.cpp index 78475f3..641a996 100644 --- a/src/glsl/ir_print_visitor.cpp +++ b/src/glsl/ir_print_visitor.cpp @@ -25,7 +2