Re: [Mesa-dev] [PATCH] glsl: subroutine types cannot be compared

2016-07-22 Thread Andres Gomez
On Fri, 2016-07-22 at 06:07 +1000, Dave Airlie wrote: > > > > On Mon, 2016-07-18 at 16:39 +0300, Andres Gomez wrote: > > > subroutine variables are to be used just in the way functions are > > > called. Although the spec doesn't say it explicitely, this means that > > > these variables are not to

Re: [Mesa-dev] [PATCH] glsl: subroutine types cannot be compared

2016-07-21 Thread Dave Airlie
> On Mon, 2016-07-18 at 16:39 +0300, Andres Gomez wrote: >> subroutine variables are to be used just in the way functions are >> called. Although the spec doesn't say it explicitely, this means that >> these variables are not to be used in any other way than those left >> for function calls. Theref

Re: [Mesa-dev] [PATCH] glsl: subroutine types cannot be compared

2016-07-19 Thread Andres Gomez
Dropping this patch. It seems I overlooked: https://lists.freedesktop.org/archives/mesa-dev/2016-June/119616.html On Mon, 2016-07-18 at 16:39 +0300, Andres Gomez wrote: > subroutine variables are to be used just in the way functions are > called. Although the spec doesn't say it explicitely, this

Re: [Mesa-dev] [PATCH] glsl: subroutine types cannot be compared

2016-07-18 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Mon, 2016-07-18 at 16:39 +0300, Andres Gomez wrote: > subroutine variables are to be used just in the way functions are > called. Although the spec doesn't say it explicitely, this means that > these variables are not to be used in any other way than those left

[Mesa-dev] [PATCH] glsl: subroutine types cannot be compared

2016-07-18 Thread Andres Gomez
subroutine variables are to be used just in the way functions are called. Although the spec doesn't say it explicitely, this means that these variables are not to be used in any other way than those left for function calls. Therefore, a comparison between 2 subroutine variables should also cause a