Re: [Mesa-dev] [PATCH] i965/blit: Remove Yf/Ys tiled check under a FIXME at can_fast_copy_blit

2016-12-08 Thread Alejandro Piñeiro
On 06/12/16 22:26, Anuj Phogat wrote: > On Tue, Dec 6, 2016 at 10:58 AM, Alejandro Piñeiro > wrote: >> The FIXME suggest that the check should be removed. >> > Only if we see any performance or feature benefits in doing that. > Last I checked I didn't see any performance

Re: [Mesa-dev] [PATCH] i965/blit: Remove Yf/Ys tiled check under a FIXME at can_fast_copy_blit

2016-12-07 Thread Anuj Phogat
On Wed, Dec 7, 2016 at 3:38 AM, Alejandro Piñeiro wrote: > > > On 07/12/16 09:36, Alejandro Piñeiro wrote: >> On 06/12/16 22:26, Anuj Phogat wrote: >>> On Tue, Dec 6, 2016 at 10:58 AM, Alejandro Piñeiro >>> wrote: The FIXME suggest that the check

Re: [Mesa-dev] [PATCH] i965/blit: Remove Yf/Ys tiled check under a FIXME at can_fast_copy_blit

2016-12-07 Thread Alejandro Piñeiro
On 07/12/16 09:36, Alejandro Piñeiro wrote: > On 06/12/16 22:26, Anuj Phogat wrote: >> On Tue, Dec 6, 2016 at 10:58 AM, Alejandro Piñeiro >> wrote: >>> The FIXME suggest that the check should be removed. >>> >> Only if we see any performance or feature benefits in doing

Re: [Mesa-dev] [PATCH] i965/blit: Remove Yf/Ys tiled check under a FIXME at can_fast_copy_blit

2016-12-07 Thread Alejandro Piñeiro
On 06/12/16 22:26, Anuj Phogat wrote: > On Tue, Dec 6, 2016 at 10:58 AM, Alejandro Piñeiro > wrote: >> The FIXME suggest that the check should be removed. >> > Only if we see any performance or feature benefits in doing that. > Last I checked I didn't see any performance

Re: [Mesa-dev] [PATCH] i965/blit: Remove Yf/Ys tiled check under a FIXME at can_fast_copy_blit

2016-12-06 Thread Anuj Phogat
On Tue, Dec 6, 2016 at 4:26 PM, Anuj Phogat wrote: > On Tue, Dec 6, 2016 at 10:58 AM, Alejandro Piñeiro > wrote: >> The FIXME suggest that the check should be removed. >> > Only if we see any performance or feature benefits in doing that. > Last I

Re: [Mesa-dev] [PATCH] i965/blit: Remove Yf/Ys tiled check under a FIXME at can_fast_copy_blit

2016-12-06 Thread Anuj Phogat
On Tue, Dec 6, 2016 at 10:58 AM, Alejandro Piñeiro wrote: > The FIXME suggest that the check should be removed. > Only if we see any performance or feature benefits in doing that. Last I checked I didn't see any performance benefits on Skylake. I also couldn't figure out the

[Mesa-dev] [PATCH] i965/blit: Remove Yf/Ys tiled check under a FIXME at can_fast_copy_blit

2016-12-06 Thread Alejandro Piñeiro
The FIXME suggest that the check should be removed. This change helps the following test: GL45-CTS.texture_cube_map_array.color_depth_attachments to pass consistently on Skylake GT3e. Without this patch, on Skylake GT3e that test has a ~76% pass rate, with some random intel_do_flush_locked