Re: [Mesa-dev] [PATCH] i965/fs: Improve accuracy of dFdy() to match dFdx().

2013-10-02 Thread Eric Anholt
Paul Berry stereotype...@gmail.com writes: Previously, we computed dFdy() using the following instruction: add(8) dst1F src4,4,0)F -src.24,4,0F { align1 1Q } That had the disadvantage that it computed the same value for all 4 pixels of a 2x2 subspan, which meant that it was less accurate

[Mesa-dev] [PATCH] i965/fs: Improve accuracy of dFdy() to match dFdx().

2013-10-01 Thread Paul Berry
Previously, we computed dFdy() using the following instruction: add(8) dst1F src4,4,0)F -src.24,4,0F { align1 1Q } That had the disadvantage that it computed the same value for all 4 pixels of a 2x2 subspan, which meant that it was less accurate than dFdx(). This patch changes it to the

Re: [Mesa-dev] [PATCH] i965/fs: Improve accuracy of dFdy() to match dFdx().

2013-10-01 Thread Chris Forbes
Acked-by: Chris Forbes chr...@ijw.co.nz On Wed, Oct 2, 2013 at 8:38 AM, Paul Berry stereotype...@gmail.com wrote: Previously, we computed dFdy() using the following instruction: add(8) dst1F src4,4,0)F -src.24,4,0F { align1 1Q } That had the disadvantage that it computed the same value for