Re: [Mesa-dev] [PATCH] i965: Disable compaction for EOT send messages

2015-05-29 Thread Matt Turner
On Wed, May 27, 2015 at 10:16 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: AFAICT, there is no real way to make sure a send message with EOT is properly ignored from compact, nor can I see a way to actually encode EOT while compacting. Before the single send optimization we'd always bail

Re: [Mesa-dev] [PATCH] i965: Disable compaction for EOT send messages

2015-05-28 Thread Ben Widawsky
On Thu, May 28, 2015 at 04:58:23PM -0700, Matt Turner wrote: On Wed, May 27, 2015 at 10:16 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: AFAICT, there is no real way to make sure a send message with EOT is properly ignored from compact, nor can I see a way to actually encode EOT

Re: [Mesa-dev] [PATCH] i965: Disable compaction for EOT send messages

2015-05-28 Thread Mark Janes
This patch allows us to enable our Braswell in our continuous integration pool. Without it, gpu hangs prevent piglit from completing. Getting Braswell enabled in the pool will help us prevent future regressions on the platform. Tested-by: Mark Janes mark.a.ja...@intel.com Ben Widawsky

Re: [Mesa-dev] [PATCH] i965: Disable compaction for EOT send messages

2015-05-28 Thread Matt Turner
On Wed, May 27, 2015 at 10:16 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: AFAICT, there is no real way to make sure a send message with EOT is properly ignored from compact, nor can I see a way to actually encode EOT while compacting. Before the single send optimization we'd always bail

Re: [Mesa-dev] [PATCH] i965: Disable compaction for EOT send messages

2015-05-28 Thread Neil Roberts
Ben Widawsky benjamin.widaw...@intel.com writes: AFAICT, there is no real way to make sure a send message with EOT is properly ignored from compact, nor can I see a way to actually encode EOT while compacting. Before the single send optimization we'd always bail because we hit the

Re: [Mesa-dev] [PATCH] i965: Disable compaction for EOT send messages

2015-05-28 Thread Matt Turner
On Thu, May 28, 2015 at 3:31 AM, Neil Roberts n...@linux.intel.com wrote: Ben Widawsky benjamin.widaw...@intel.com writes: AFAICT, there is no real way to make sure a send message with EOT is properly ignored from compact, nor can I see a way to actually encode EOT while compacting. Before

Re: [Mesa-dev] [PATCH] i965: Disable compaction for EOT send messages

2015-05-28 Thread Ben Widawsky
On Thu, May 28, 2015 at 11:31:40AM +0100, Neil Roberts wrote: Ben Widawsky benjamin.widaw...@intel.com writes: AFAICT, there is no real way to make sure a send message with EOT is properly ignored from compact, nor can I see a way to actually encode EOT while compacting. Before the single

Re: [Mesa-dev] [PATCH] i965: Disable compaction for EOT send messages

2015-05-28 Thread Ben Widawsky
On Thu, May 28, 2015 at 07:00:38AM -0700, Matt Turner wrote: On Thu, May 28, 2015 at 3:31 AM, Neil Roberts n...@linux.intel.com wrote: Ben Widawsky benjamin.widaw...@intel.com writes: AFAICT, there is no real way to make sure a send message with EOT is properly ignored from compact, nor

[Mesa-dev] [PATCH] i965: Disable compaction for EOT send messages

2015-05-27 Thread Ben Widawsky
AFAICT, there is no real way to make sure a send message with EOT is properly ignored from compact, nor can I see a way to actually encode EOT while compacting. Before the single send optimization we'd always bail because we hit the is_immediate !is_compactable_immediate case. However, with

Re: [Mesa-dev] [PATCH] i965: Disable compaction for EOT send messages

2015-05-27 Thread Ben Widawsky
I forgot to mention that the predecessor to this patch fixed around 70 BSW failures on Jenkins. Note that our current Jenkins baseline for BSW is probably not fully baked atm. On Wed, May 27, 2015 at 10:16:04PM -0700, Ben Widawsky wrote: AFAICT, there is no real way to make sure a send message