Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

On Tuesday, April 3, 2018 11:56:27 PM PDT Sergii Romantsov wrote: > Hello, Mark. > I've done: Cc, Tested-by and Reviewed-by also added. I pushed your patch. Thanks so much for tracking this down! signature.asc Description: This is a digitally signed message part.

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

Hello, Mark. I've done: Cc, Tested-by and Reviewed-by also added. On Wed, Apr 4, 2018 at 8:16 AM, Mark Janes wrote: > This patch passes Intel's CI suites. > It needs a CC for stable in the commit message. > > Tested-by: Mark Janes > > Sergii

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

This patch passes Intel's CI suites. It needs a CC for stable in the commit message. Tested-by: Mark Janes Sergii Romantsov writes: > Gen8+ use 48-bit address relocations so need to extend the sign > to 64-bit return value. Without it we

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

On 27 March 2018 at 09:40, Sergii Romantsov wrote: > Hello Chris and Emil. > Could we make a final decision? Because I'm bit confused what you are > expecting exactly. > > I would prefer to left initial patch as is (if its possible). > Same inclination here. Changing

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

Quoting Sergii Romantsov (2018-04-02 07:59:06) > Gen8+ use 48-bit address relocations so need to extend the sign > to 64-bit return value. Without it we have higher bits zeroed > and missing the negavive values. > Haswell and older use 32-bit deltas so are unaffected by this issue. > > v2: >

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

Hi Sergii, I built this into mesa 17.3.7 and it seems to solve all the issues I've seen that were mentioned in 101408. This includes not just the issues with the Mortar, but the other visual artefacts that I've noticed with the player models and with other weapons in the game. Many thanks for

[Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

Gen8+ use 48-bit address relocations so need to extend the sign to 64-bit return value. Without it we have higher bits zeroed and missing the negavive values. Haswell and older use 32-bit deltas so are unaffected by this issue. v2: used int32_t fucntion parameter instead of explicit type

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

Hello Chris and Emil. Could we make a final decision? Because I'm bit confused what you are expecting exactly. I would prefer to left initial patch as is (if its possible). On Tue, Mar 27, 2018 at 9:20 AM, Sergii Romantsov < sergii.romant...@gmail.com> wrote: > Hello Stuart, > Nice to hear. >

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

Hello Stuart, Nice to hear. And thanks for your time and contribution. On Tue, Mar 27, 2018 at 8:40 AM, Stuart Young wrote: > Hi Sergii, > > I built this into mesa 17.3.7 and it seems to solve all the issues I've > seen that were mentioned in 101408. > > This includes not just

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

Hello, Emil. Thanks for involving. > Fixes: cee9f3890351 ("i965: Allow 48-bit addressing on Gen8+.") Actually that patch doesn't fix exactly cee9f3890351. Also I wrote earlier (probably, my e-mails may go into spam :)): "That issue is present even on mesa 13-0.0 and also solved with similar

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

On 26 March 2018 at 13:31, Chris Wilson wrote: > Quoting Sergii Romantsov (2018-03-26 13:16:24) >> Negative deltas are used to fake a range in a large buffer. >> See 900a5c91eeb3 >> "i965: Use negative relocation deltas to minimise vertex uploads" >> >> Gen8+ use 48-bit

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

Quoting Sergii Romantsov (2018-03-26 14:11:26) > Hello, Chris. Thank you for reviewing patch. > Do you mean changing just only emit_reloc() parameter type or all the > preceding > callers too? If you insist, but you don't have to. int32_t on the parameter is enough to document and correct the

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

Hello, Chris. Thank you for reviewing patch. Do you mean changing just only emit_reloc() parameter type or all the preceding callers too? Also, please, explain what you mean about patch cee9f3890351? That issue is present even on mesa 13-0.0 and also solved with similar type-conversion fix.

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

Quoting Sergii Romantsov (2018-03-26 13:16:24) > Negative deltas are used to fake a range in a large buffer. > See 900a5c91eeb3 > "i965: Use negative relocation deltas to minimise vertex uploads" > > Gen8+ use 48-bit address relocations so need to extend the sign Note that 48-bit relocations

Re: [Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

Hello, Stuart. Could You, please, test this patch? On Mon, Mar 26, 2018 at 3:16 PM, Sergii Romantsov < sergii.romant...@gmail.com> wrote: > Negative deltas are used to fake a range in a large buffer. > See 900a5c91eeb3 > "i965: Use negative relocation deltas to minimise vertex uploads" > > Gen8+

[Mesa-dev] [PATCH] i965: Extend the negative 32-bit deltas to 64-bits

Negative deltas are used to fake a range in a large buffer. See 900a5c91eeb3 "i965: Use negative relocation deltas to minimise vertex uploads" Gen8+ use 48-bit address relocations so need to extend the sign to 64-bit return value. Without it we have higher bits zeroed and missing the negavive