Re: [Mesa-dev] [PATCH] i965: Fix move_interpolation_to_top() pass.

2016-07-29 Thread Matt Turner
On Tue, Jul 26, 2016 at 1:19 PM, Kenneth Graunke wrote: > Papers over GPU hangs on Ivybridge and Baytrail caused by the > recent NIR FS input rework by restoring the old behavior. > (I'm not honestly sure why they hang with PLN not at the top.) I think this is because of

Re: [Mesa-dev] [PATCH] i965: Fix move_interpolation_to_top() pass.

2016-07-29 Thread Matt Turner
On Tue, Jul 26, 2016 at 1:19 PM, Kenneth Graunke wrote: > The pass I introduced in commit a2dc11a7818c04d8dc0324e8fcba98d60bae > was entirely broken. A missing "break" made the load_interpolated_input > case always fall through to "default" and hit a "continue", making it

Re: [Mesa-dev] [PATCH] i965: Fix move_interpolation_to_top() pass.

2016-07-26 Thread Kenneth Graunke
On Tuesday, July 26, 2016 2:12:47 PM PDT Matt Turner wrote: > On Tue, Jul 26, 2016 at 1:19 PM, Kenneth Graunke > wrote: > > The pass I introduced in commit a2dc11a7818c04d8dc0324e8fcba98d60bae > > was entirely broken. A missing "break" made the load_interpolated_input > >

Re: [Mesa-dev] [PATCH] i965: Fix move_interpolation_to_top() pass.

2016-07-26 Thread Mark Janes
Tested-by: Mark Janes Kenneth Graunke writes: > The pass I introduced in commit a2dc11a7818c04d8dc0324e8fcba98d60bae > was entirely broken. A missing "break" made the load_interpolated_input > case always fall through to "default" and hit a

Re: [Mesa-dev] [PATCH] i965: Fix move_interpolation_to_top() pass.

2016-07-26 Thread Matt Turner
On Tue, Jul 26, 2016 at 1:19 PM, Kenneth Graunke wrote: > The pass I introduced in commit a2dc11a7818c04d8dc0324e8fcba98d60bae > was entirely broken. A missing "break" made the load_interpolated_input > case always fall through to "default" and hit a "continue", making it

[Mesa-dev] [PATCH] i965: Fix move_interpolation_to_top() pass.

2016-07-26 Thread Kenneth Graunke
The pass I introduced in commit a2dc11a7818c04d8dc0324e8fcba98d60bae was entirely broken. A missing "break" made the load_interpolated_input case always fall through to "default" and hit a "continue", making it not actually move any load_interpolated_input intrinsics at all. It would only move