Re: [Mesa-dev] [PATCH] i965: Flip arguments to load_register_reg helpers.

2018-12-07 Thread Lionel Landwerlin
Rb On 08/12/2018 00:32, Kenneth Graunke wrote: load_register_imm and load_register_mem take the destination as the first argument, so I'd like load_register_reg to do the same the sake of consistency. Otherwise, reading sequences of mixed LRI/LRM/LRR is needlessly confusing. --- src/mesa/driv

[Mesa-dev] [PATCH] i965: Flip arguments to load_register_reg helpers.

2018-12-07 Thread Kenneth Graunke
load_register_imm and load_register_mem take the destination as the first argument, so I'd like load_register_reg to do the same the sake of consistency. Otherwise, reading sequences of mixed LRI/LRM/LRR is needlessly confusing. --- src/mesa/drivers/dri/i965/brw_conditional_render.c | 2 +- src/m